Can't actually require FILENAME or REMOTE_FILENAME because I don't know
if you're going to upload or download. However, there shouldn't be a
stacktrace when you just try to go with neither.
get() should get get_once() (intent is to get 4 bytes,
not timeout after 4 seconds), no need to escape equals
signs in regexes, no need to newline the unexpected
responses.
get() should get get_once() (intent is to get 4 bytes,
not timeout after 4 seconds), no need to escape equals
signs in regexes, no need to newline the unexpected
responses.
Also refers to port 264/TCP as the SecuRemote service instead of the
Topology service (I believe this is correct)
Reporting is initially conservative -- if we don't get something for
fw_hostname, then don't bother reporting at all; assume we're
mis-identifying the target.
Also refers to port 264/TCP as the SecuRemote service instead of the
Topology service (I believe this is correct)
Reporting is initially conservative -- if we don't get something for
fw_hostname, then don't bother reporting at all; assume we're
mis-identifying the target.
Squashed commit of the following:
commit 11a27a1e61
Author: Tod Beardsley <todb@metasploit.com>
Date: Tue Dec 20 10:06:44 2011 -0600
Renaming TFTP transfer util.
See #5291. Just renaming the file.
commit 24d53efa7c
Author: Tod Beardsley <todb@metasploit.com>
Date: Tue Dec 20 10:03:04 2011 -0600
Final touches on TFTP client
See #5291. Adds an option to mess with the block size in case someone
wants to write a fuzzer or exploit that leverages that. Adds a cleanup
method to the module (pretty much required, it turns out). Looking
nearly final, just need to rename the module and I think we're good to
push to master.
commit 677cb4b152
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 19 21:56:03 2011 -0600
Handle empty data sends sanely for TFTP.
Don't just hang forever -- let the user know they just send empty data.
TFTP servers don't like this of course.
commit 2b3e3725ac
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 19 18:15:19 2011 -0600
TFTP adding comment docs, ability to send w/out a file.
Commenting the tricksy parts a little better for general usage.
Adding the ability to set FILEDATA instead of FILENAME, in case
only short bits of data are desired and the user doesn't want
to go to the trouble of creating a source file to upload.
commit 431ef826c9
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 19 16:33:25 2011 -0600
TFTP client now uses constants, preserves trailing spaces/nulls in data
See #5291, just rediscovered the bug on this.
commit 5eaf2e7535
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 19 15:50:50 2011 -0600
Adding download and loot functionality.
Still need to deal with the use case of not passing a block; blocks
should not be required, it should be okay to invoke and just wait for
the complete attribute to be true. You'll miss out on error messages but
eh, maybe those should be return values.
commit aecde6fea4
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 19 12:14:40 2011 -0600
Updating TFTP client. Now with grown-up thread handling.
No longer blocks on successful connections.
commit 902d7f5ea7
Author: Tod Beardsley <todb@metasploit.com>
Date: Sun Dec 18 21:05:27 2011 -0600
Adding more to TFTP. Still need a read tho
Adds error checking and some helpful messaging in the event of an error.
In the event of a failed transfer the module exits immediately, but in
success, I'm still hanging around for several seconds after. Not a deal
breaker but can be annoying.
Also, need to implement a read as well as a write and store it as loot,
to be actually useful for most TFTP checking.
commit 23aadd04f7
Author: Tod Beardsley <todb@metasploit.com>
Date: Sun Dec 18 13:28:52 2011 -0600
Fixing merge conflict cruft
Dangit teach me to merge quickly. TFTP module now loads again.
commit 1201d7fbf2
Merge: 0b89140a6867ef
Author: Tod Beardsley <todb@metasploit.com>
Date: Fri Dec 16 22:41:22 2011 -0600
Merge branch 'tftp_client' of github_r7:rapid7/metasploit-framework into tftp_client
Conflicts:
modules/auxiliary/admin/tftp/tftp_upload_file.rb
commit 0b8914021c
Author: Tod Beardsley <todb@metasploit.com>
Date: Fri Dec 16 21:06:10 2011 -0600
Switch to vprint_status, also add skeletal cleanup def.
commit 50fa10679b
Author: Tod Beardsley <todb@metasploit.com>
Date: Fri Dec 16 18:39:09 2011 -0600
First draft of a TFTP client.
Could use some actual error checking and also needs to expose
more options.
commit a6867ef128
Author: Tod Beardsley <todb@metasploit.com>
Date: Fri Dec 16 18:39:09 2011 -0600
First draft of a TFTP client.
Could use some actual error checking and also needs to expose
more options.
See #5291. Adds an option to mess with the block size in case someone
wants to write a fuzzer or exploit that leverages that. Adds a cleanup
method to the module (pretty much required, it turns out). Looking
nearly final, just need to rename the module and I think we're good to
push to master.
Commenting the tricksy parts a little better for general usage.
Adding the ability to set FILEDATA instead of FILENAME, in case
only short bits of data are desired and the user doesn't want
to go to the trouble of creating a source file to upload.
Still need to deal with the use case of not passing a block; blocks
should not be required, it should be okay to invoke and just wait for
the complete attribute to be true. You'll miss out on error messages but
eh, maybe those should be return values.
Adds error checking and some helpful messaging in the event of an error.
In the event of a failed transfer the module exits immediately, but in
success, I'm still hanging around for several seconds after. Not a deal
breaker but can be annoying.
Also, need to implement a read as well as a write and store it as loot,
to be actually useful for most TFTP checking.
Jonathan Cran
Jonathan Cran
Tod Beardsley
sinn3r
David Maloney
HD Moore
Joshua Smith
Marc Bevand
Tod Beardsley
alhazred
Stephen Haywood