Commit Graph

215 Commits (8ae5d67a80a8c0de000a7a6a3599aab5896af149)

Author SHA1 Message Date
Jason Simmons 8ae5d67a80 Add cronjob-concurrency to checks.md 2020-11-09 14:04:30 -05:00
jasimmons 9abf246c1c Add cronJobConcurrencyCheck 2020-10-26 09:32:23 -04:00
jasimmons 0075a30aea Add CronJob as a resource type 2020-10-26 09:32:01 -04:00
Adam Wolfe Gordon 3ab1800043
Merge pull request #90 from uplol/master
Fix reference to loop variables in doks admission controller checks
2020-08-13 14:07:28 -06:00
Spencer 99bb81f367 change approach 2020-08-13 19:52:35 +00:00
Spencer Sharkey 973b3f4c54 Fix reference to loop variables in doks admission controllers 2020-08-13 19:44:15 +00:00
Adam Wolfe Gordon 37326c1fc5
Merge pull request #91 from digitalocean/awg/label-check-stable-output
Make "details" for the label check stable
2020-08-13 13:22:52 -06:00
Adam Wolfe Gordon a1e68fdd59 Make "details" for the label check stable
The tests for #90 failed because the order of map iteration is
non-deterministic, causing custom labels in the node label check to appear in
random order in the diagnostic details. Sort the slice of labels so that the
output is stable.
2020-08-13 13:09:02 -06:00
Varsha Varadarajan 6b6f1ed38a
Merge pull request #89 from varshavaradarajan/clusterlint-panic-recovery
Recover from panic when running checks
2020-07-10 10:44:13 -07:00
Varsha Varadarajan 23208e1872 recover from panic when running checks 2020-07-09 10:42:21 -07:00
Jeremy L. Morris 3555522677
Merge pull request #88 from MorrisLaw/fix-nil-timeout-error
Update timeout check to account for nil TimeoutSeconds value
2020-07-07 12:19:41 -04:00
Jeremy L. Morris 161c7a1a7c Add comment on why we just continue for nil TimeoutSeconds value 2020-07-07 11:06:27 -04:00
Jeremy L. Morris b3915f299d Update timeout check to account for nil TimeoutSeconds value 2020-06-30 17:44:32 -04:00
Varsha Varadarajan c571ab598b
Merge pull request #86 from varshavaradarajan/update-to-1.18
Update k8s dependencies to 0.18.3
2020-06-22 11:08:49 -07:00
Varsha Varadarajan 8de65f1dbb Update circle ci jobs to run on go 1.13 2020-06-22 10:45:05 -07:00
Jeremy L. Morris 65df37b007
Merge pull request #85 from MorrisLaw/add-webhook-check-for-timeout
Add webhook check for timeouts
2020-06-15 13:18:57 -04:00
Varsha Varadarajan 6d9242c943 Update api interactions to pass along context 2020-06-15 09:56:12 -07:00
Varsha Varadarajan 8fbeb3af6a update vendor 2020-06-15 09:55:34 -07:00
Varsha Varadarajan ee3fb78aac Update k8s deps to 0.18.3 2020-06-15 09:55:21 -07:00
Jeremy L. Morris e6ec7b4515 Add webhook check for timeouts
* Update docs to include Admission Controller Webhook Timeout check with fix

 * Update file naming to be more consistent for admission controller webhooks

 * Fix typo in webhook replacement struct name
2020-06-15 12:07:35 -04:00
Varsha Varadarajan ee0ddd9885
Merge pull request #82 from varshavaradarajan/upgrade-dependencies
modules: upgrade dependencies
2020-06-11 11:58:57 -07:00
Varsha Varadarajan a8eb024dcf Update vendor 2020-06-11 11:39:40 -07:00
Varsha Varadarajan ebb738cc25 upgrade k8s.io modules to 0.17.3, upgrade others to latest 2020-06-11 11:39:26 -07:00
Varsha Varadarajan ce3b53339f
Merge pull request #80 from varshavaradarajan/varsha/add-details-to-diagnostics
Add additional details to diagnostics, provide specific labels and taint keys  for nodeLabelsTaints check
2020-05-29 07:35:32 -07:00
Varsha Varadarajan aa7e326e5a Update node labels diagnostics to mention persistent node pool labels 2020-05-28 09:15:28 -07:00
Varsha Varadarajan ac38530e46 Add additional details to diagnostics, provide specific labels and taint keys for nodeLabelsTaints check 2020-05-26 15:07:24 -07:00
Varsha Varadarajan 20916379b3
Merge pull request #79 from varshavaradarajan/config-map-key-ref
Check for config map key ref for unused config map check
2020-02-10 15:16:35 -08:00
Varsha Varadarajan a3ccd62f2d Check for config map key ref for unused config map test 2020-02-10 11:29:59 -08:00
Adam Wolfe Gordon cb603bc39a
Merge pull request #77 from valbeat/feature/add-flag-namspace
Add flag namspace
2020-01-24 13:02:31 -07:00
valbeat fa7a915f07 Remove unused code 2020-01-23 15:06:29 +09:00
valbeat 653f22aac2 Use `FieldSelector` to filter Namespace 2020-01-22 19:27:40 +09:00
valbeat 0fe6e35217 Rename ObjectFilter and Fix comment. 2020-01-20 18:04:18 +09:00
valbeat 6ef333871c Add flag namspace 2020-01-20 17:01:59 +09:00
Adam Wolfe Gordon 4db75f7c7f
Merge pull request #73 from digitalocean/awg/plugins
Add support for local checks via Go plugins
2020-01-15 16:59:41 -07:00
Adam Wolfe Gordon 7b02846fa5 Expand on the caveats of using Go plugins 2020-01-15 16:56:43 -07:00
Adam Wolfe Gordon 0131e2f570
Merge pull request #76 from valbeat/feature/bare-pods-skip-static-pod
checks bare-pods: skip static pods
2020-01-15 16:43:21 -07:00
valbeat 5b77ddab97 Skip static pod 2020-01-07 15:26:46 +09:00
Adam Wolfe Gordon e0df92b809
Merge pull request #72 from digitalocean/awg/latest-tag-handle-parse-errors
checks/latest-tag: Handle unparseable image names
2019-12-10 11:13:59 -07:00
Adam Wolfe Gordon afdd52117e Add support for local checks via Go plugins
We've had questions a few times about whether it's possible to implement
organization-specific checks that are not appropriate for inclusion in
the clusterlint codebase. For example, a company may have some highly
specific best practice that isn't relevant anywhere else, but want to
enforce it using clusterlint alongside all their other best practices.

Implement this capability by allowing Go plugins to be loaded into
clusterlint at runtime. Document how to build plugins, and provide an
example.
2019-12-09 16:53:59 -07:00
Adam Wolfe Gordon 73396932c9 checks/latest-tag: Handle unparseable image names
We don't expect to see unparseable image names in running pods, since
k8s was able to parse all the image names when the pod was
created. However, that appears to be what's happening in #71, so we
should handle the case to avoid dereferencing a nil pointer.
2019-12-09 15:37:09 -07:00
Nan Zhong eebd18af4b
Merge pull request #69 from digitalocean/admission-webhook-changes
Introduce basic admission webhook checks to handle error case
2019-11-25 12:25:01 -05:00
Nan Zhong 21df8a7b4b Rework service and namespace checking into helpers 2019-11-25 14:52:11 +00:00
Nan Zhong 60ca69cadc Add missing heading for check 2019-11-25 14:44:54 +00:00
Bouke van der Bijl d658b20107
Merge pull request #70 from digitalocean/http-transport-option
kube: allow wrapping the underlying http.RoundTripper
2019-11-25 14:04:25 +01:00
Bouke van der Bijl 7ef7080a2b kube: allow wrapping the underlying http.RoundTripper
This will allow us to access the *http.Transport and close the
connections after we're done linting.
2019-11-25 10:21:20 +00:00
Nan Zhong 08da1a28bb Introduce basic admission webhook checks to handle error case 2019-11-25 04:57:32 +00:00
Varsha Varadarajan 73f0904f3c
Merge pull request #68 from bengadbois/client-go-1.16.2
modules: upgrade k8s.io/client-go to kubernetes-1.16.2
2019-11-20 12:49:52 -08:00
Ben Gadbois e09d86d508 modules: upgrade k8s.io/client-go to kubernetes-1.16.2 2019-11-18 12:21:06 -08:00
Adam Wolfe Gordon 33d2b89909
Merge pull request #65 from digitalocean/awg/fill-check-names
Add check names to diagnostics from the check runner
2019-10-28 20:02:04 -06:00
Adam Wolfe Gordon 68416bd367 Add check names to diagnostics from the check runner
Rather than relying on each check to fill in its name correctly when
producing diagnostics, fill in the name in the check runner after
running the check. This reduces the likelihood that a check gets its
name wrong or forgets to fill it in.

This also fixes a bug where the admission control webhook check was not
filling in its name at all.
2019-10-28 18:07:01 -06:00