Commit Graph

2368 Commits (b0d37376274788db03d9d7f69089dc938b95eaa7)

Author SHA1 Message Date
Tonis Tiigi b0d3737627 contenthash: allow security.capability in cache checksum
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-06-07 22:16:56 -07:00
Akihiro Suda 920772c593
Merge pull request #1525 from tonistiigi/timeout-increase
increase test context timeouts
2020-06-08 03:17:35 +09:00
Tonis Tiigi cc88b8f4f4 increase test context timeouts
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-06-06 15:48:55 -07:00
Tõnis Tiigi 598a0bdc9a
Merge pull request #1523 from keyolk/userns
fix mount options for userns env
2020-06-06 15:26:51 -07:00
Tõnis Tiigi 422d5ead4f
Merge pull request #1524 from coryb/getmount-index-test
add unit test for getmount output index
2020-06-05 11:39:55 -07:00
Cory Bennett e351bfdd01 add unit test for getmount output index
Signed-off-by: Cory Bennett <cbennett@netflix.com>
2020-06-04 18:25:03 -07:00
Tõnis Tiigi f720548416
Merge pull request #1521 from coryb/tmpfs-no-output
skip tmpfs mounts when calculating indexes for llb.GetMount
2020-06-04 17:53:15 -07:00
Chanhun Jeong d3d9abb100 fix mount options for userns env
Signed-off-by: Chanhun Jeong <chanhun.jeong@navercorp.com>
Signed-off-by: Sunho Kim <z.sunno@navercorp.com>
2020-06-05 03:52:00 +09:00
Cory Bennett 2b462fc6ca skip tmpfs mounts when calculating indexes for llb.GetMount
Signed-off-by: Cory Bennett <cbennett@netflix.com>
2020-06-04 10:54:32 -07:00
Akihiro Suda 643f0ffb56
Merge pull request #1511 from tonistiigi/nil-cast-fix
cache: avoid nil dereference
2020-05-29 10:33:01 +09:00
Tonis Tiigi 8cd41468c0 cache: avoid nil dereference
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-27 14:58:16 -07:00
Tõnis Tiigi 08c91e0407
Merge pull request #1508 from smira/add-bldr
Add `bldr` project link to README as LLB language frontend
2020-05-27 10:53:57 -07:00
Akihiro Suda be58c5a425
Merge pull request #1409 from tonistiigi/travis-rm
travis: avoid cleaning up container
2020-05-27 07:08:53 +09:00
Andrey Smirnov 1155ddc02b Add `bldr` project link to README as LLB language frontend
Project [bldr](https://github.com/talos-systems/bldr) provides a way to package and build software as container
images leveraging LLB/buildkit as backend. It translates high-level
`.yaml` build instructions into LLB instructions.

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
2020-05-27 00:18:19 +03:00
Tonis Tiigi 3f18388316 travis: avoid cleaning up container
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-26 09:03:21 -07:00
Akihiro Suda d6f5e972de
Merge pull request #1494 from tonistiigi/errdefs2
llb: add source tracking support
2020-05-25 23:15:20 +09:00
Akihiro Suda 7f4214f5b4
Merge pull request #1504 from anurag/ag/fix-shell-expansion
Fix shell args expansion in buildctl-daemonless.sh
2020-05-23 02:38:00 +09:00
Anurag Goel 3cca542065
Fix shell args expansion in buildctl-daemonless.sh
When the special positional params character isn't enclosed in double
quotes it prevents users from passing in arguments spanning multiple
words. For example, `--opt build-arg:"word1 word2"` fails. Enclosing in
double quotes treats each parameter as a separate word.

More here:
https://tiswww.case.edu/php/chet/bash/bashref.html#index-_0024_0040

Signed-off-by: Anurag Goel <anurag@render.com>
2020-05-21 17:35:39 -07:00
Edgar Lee fbee6cccbd Fix source map test in client_test
Signed-off-by: Edgar Lee <edgarl@netflix.com>
2020-05-20 19:04:25 -07:00
Edgar Lee 7c81e16b8a Fix duplicate source maps and fix issue preventing multiple locations per source map
Signed-off-by: Edgar Lee <edgarl@netflix.com>
2020-05-20 18:48:20 -07:00
Edgar Lee 59fa9fc9a0 Allow multiple source locations to be added as a constraint
Signed-off-by: Edgar Lee <edgarl@netflix.com>
2020-05-20 16:48:44 -07:00
Edgar Lee 7a90a36b46 Support multiple source maps and locations for source-level stacktraces
Signed-off-by: Edgar Lee <edgarl@netflix.com>
2020-05-20 16:17:35 -07:00
Tonis Tiigi d173e3dca8 pb: add more comments
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-19 17:23:03 -07:00
Tonis Tiigi 6dee7ee0fc dockerfile: add source mapping tests
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-19 17:22:21 -07:00
Tonis Tiigi 90c5e67496 client: add source mapping tests
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-19 17:22:14 -07:00
Tõnis Tiigi 83bda57e53
Merge pull request #1499 from AkihiroSuda/ditch-external-base
Dockerfile: ditch ROOTLESS_BASE_MODE=external
2020-05-19 16:44:04 -07:00
Akihiro Suda 43f66b7f75
Merge pull request #1498 from tonistiigi/cache-load-errors
solver: gracefully handle cache loading errors
2020-05-20 08:06:26 +09:00
Akihiro Suda 671ed21cd6 .travis.yml: build images on daily cron
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-20 08:05:32 +09:00
Akihiro Suda f026da9f1a Dockerfile: fix linking newuidmap and newgidmap (partially reverts #1405)
* Existing releases v0.3.0...v0.7.1 use newuidmap dynamically linked with musl

* #1405 attempted to link newuidmap statically with glibc, but it was actually dynamically linked by accident and was never used as the external base.
Switching from musl (Alpine) to glibc (Debian) is just because we don't have `cross.sh` for Alpine.
We could fix the script to link the binary statically, but statically linked binary doesn't work on Alpine because of "Cannot determine your user name." error.

* This commit reverts #1405 for newuidmap, and build the stage with `--platform=$TARGETPLATFORM`.
In future we should port over `cross.sh` to Alpine and use `--platform=$BUILDPLATFORM`.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-20 08:05:32 +09:00
Akihiro Suda 9380d34799 Dockerfile: ditch ROOTLESS_BASE_MODE=external
Fix #1378

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-19 11:41:38 +09:00
Tonis Tiigi dd765674fb solver: gracefully handle cache loading errors
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-18 18:21:34 -07:00
Tonis Tiigi 75d64ffb4a fix proto indentions
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-18 15:50:08 -07:00
Tonis Tiigi e536302180 dockerfile: keep mapping on #syntax error
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-18 15:50:08 -07:00
Tonis Tiigi 6073e6cff3 llb: enable source tracking
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-18 15:50:03 -07:00
Tonis Tiigi 1f9599aba3 llb: move source mapping to llb metadata
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-18 15:49:41 -07:00
Akihiro Suda 24f4838730
Merge pull request #1497 from tonistiigi/travis-update
travis: update base image
2020-05-18 10:03:02 +09:00
Tonis Tiigi a213ce76a0 travis: update base image
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-17 16:32:33 -07:00
Tõnis Tiigi 6af5aa88f9
Merge pull request #1496 from AkihiroSuda/fix-typo-20200517
create-certs.sh: fix a typo
2020-05-17 00:01:23 -07:00
Tõnis Tiigi 4d1e92cc9a
Merge pull request #1495 from AkihiroSuda/prohibit-attempt-rootless-in-initial-userns
buildkitd: prohibit --oci-worker-rootless for real root
2020-05-17 00:01:12 -07:00
Akihiro Suda 5fd091cedc create-certs.sh: fix a typo
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-17 10:23:09 +09:00
Akihiro Suda eb8c8eeb67 buildkitd: prohibit --oci-worker-rootless for real root
Specifying `--oci-worker-rootless` for real root is meaningless and
should be prohibited

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-17 10:16:43 +09:00
Tõnis Tiigi 8fc0f63d6e
Merge pull request #1493 from azoff/master
Allow dynamic max retries on socket connect for buildctl
2020-05-16 14:11:21 -07:00
Jonathan Azoff f592be2bbc
Allow max retries on socket connect for buildctl
Signed-off-by: Jonathan Azoff <jon@azof.fr>
2020-05-15 00:25:02 -07:00
Tõnis Tiigi 61dcb101c9
Merge pull request #1482 from thaJeztah/bump_containerd
vendor: update containerd and dependencies to current master
2020-05-14 17:07:00 -07:00
Sebastiaan van Stijn 17e495e01a
vendor: update containerd and dependencies to current master
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-14 21:01:44 +02:00
Tõnis Tiigi e356741262
Merge pull request #1488 from thaJeztah/fix_deprecation_warning
CI: fix "--import-cache" deprecation warnings
2020-05-13 10:48:11 -07:00
Tõnis Tiigi 72a8a7844d
Merge pull request #1489 from thaJeztah/fix_goimports
Fix goimports linting
2020-05-13 10:47:49 -07:00
Sebastiaan van Stijn 3ddd1fc23c
Fix goimports linting
```
[5/5] RUN --mount=target=/go/src/github.com/moby/buildkit 	gometalinter ...
0.435 util/rootless/specconv/specconv_linux.go:1:⚠️ file is not goimported (goimports)
1.320 cache/manager.go:1:⚠️ file is not goimported (goimports)
1.335 cache/manager_test.go:1:⚠️ file is not goimported (goimports)
1.337 cache/migrate_v2.go:1:⚠️ file is not goimported (goimports)
1.342 cache/refs.go:1:⚠️ file is not goimported (goimports)
1.454 cache/remotecache/registry/registry.go:1:⚠️ file is not goimported (goimports)
2.285 cmd/buildctl/build.go:1:⚠️ file is not goimported (goimports)
3.082 executor/oci/user.go:1:⚠️ file is not goimported (goimports)
4.333 session/content/content_test.go:1:⚠️ file is not goimported (goimports)
4.614 snapshot/containerd/content.go:1:⚠️ file is not goimported (goimports)
4.721 solver/errdefs/vertex.go:1:⚠️ file is not goimported (goimports)
6.066 util/network/cniprovider/cni.go:1:⚠️ file is not goimported (goimports)
ERROR: executor failed running [/bin/sh -c gometalinter --config=gometalinter.json ./...]: buildkit-runc did not terminate successfully
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-13 17:38:56 +02:00
Sebastiaan van Stijn c34699f8dd
CI: fix "--import-cache" deprecation warnings
I noticed these warnings in CI logs;

    +buildctl build --progress=plain --frontend=dockerfile.v0 --opt context=git://github.com/moby/buildkit#refs/pull/1482/merge --opt build-arg:BUILDKIT_CONTEXT_KEEP_GIT_DIR=1 --opt platform=linux/amd64,linux/arm/v7,linux/arm64,linux/s390x,linux/ppc64le,darwin/amd64,windows/amd64 --import-cache cicache.buildk.it/moby/buildkit/master:binaries-cross-helper
    WARN[0000] --import-cache <ref> is deprecated. Please use --import-cache type=registry,ref=<ref>,<opt>=<optval>[,<opt>=<optval>] instead.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-13 16:49:52 +02:00
Akihiro Suda 6f83882a0b
Merge pull request #1486 from tonistiigi/terminal-height
progressui: fix panic on terminals with zero height
2020-05-13 02:49:43 +09:00