Commit Graph

2334 Commits (9380d34799cb500b320d47415da52f9fc2232a59)

Author SHA1 Message Date
Akihiro Suda 9380d34799 Dockerfile: ditch ROOTLESS_BASE_MODE=external
Fix #1378

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-19 11:41:38 +09:00
Akihiro Suda 24f4838730
Merge pull request #1497 from tonistiigi/travis-update
travis: update base image
2020-05-18 10:03:02 +09:00
Tonis Tiigi a213ce76a0 travis: update base image
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-17 16:32:33 -07:00
Tõnis Tiigi 6af5aa88f9
Merge pull request #1496 from AkihiroSuda/fix-typo-20200517
create-certs.sh: fix a typo
2020-05-17 00:01:23 -07:00
Tõnis Tiigi 4d1e92cc9a
Merge pull request #1495 from AkihiroSuda/prohibit-attempt-rootless-in-initial-userns
buildkitd: prohibit --oci-worker-rootless for real root
2020-05-17 00:01:12 -07:00
Akihiro Suda 5fd091cedc create-certs.sh: fix a typo
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-17 10:23:09 +09:00
Akihiro Suda eb8c8eeb67 buildkitd: prohibit --oci-worker-rootless for real root
Specifying `--oci-worker-rootless` for real root is meaningless and
should be prohibited

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-05-17 10:16:43 +09:00
Tõnis Tiigi 8fc0f63d6e
Merge pull request #1493 from azoff/master
Allow dynamic max retries on socket connect for buildctl
2020-05-16 14:11:21 -07:00
Jonathan Azoff f592be2bbc
Allow max retries on socket connect for buildctl
Signed-off-by: Jonathan Azoff <jon@azof.fr>
2020-05-15 00:25:02 -07:00
Tõnis Tiigi 61dcb101c9
Merge pull request #1482 from thaJeztah/bump_containerd
vendor: update containerd and dependencies to current master
2020-05-14 17:07:00 -07:00
Sebastiaan van Stijn 17e495e01a
vendor: update containerd and dependencies to current master
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-14 21:01:44 +02:00
Tõnis Tiigi e356741262
Merge pull request #1488 from thaJeztah/fix_deprecation_warning
CI: fix "--import-cache" deprecation warnings
2020-05-13 10:48:11 -07:00
Tõnis Tiigi 72a8a7844d
Merge pull request #1489 from thaJeztah/fix_goimports
Fix goimports linting
2020-05-13 10:47:49 -07:00
Sebastiaan van Stijn 3ddd1fc23c
Fix goimports linting
```
[5/5] RUN --mount=target=/go/src/github.com/moby/buildkit 	gometalinter ...
0.435 util/rootless/specconv/specconv_linux.go:1:⚠️ file is not goimported (goimports)
1.320 cache/manager.go:1:⚠️ file is not goimported (goimports)
1.335 cache/manager_test.go:1:⚠️ file is not goimported (goimports)
1.337 cache/migrate_v2.go:1:⚠️ file is not goimported (goimports)
1.342 cache/refs.go:1:⚠️ file is not goimported (goimports)
1.454 cache/remotecache/registry/registry.go:1:⚠️ file is not goimported (goimports)
2.285 cmd/buildctl/build.go:1:⚠️ file is not goimported (goimports)
3.082 executor/oci/user.go:1:⚠️ file is not goimported (goimports)
4.333 session/content/content_test.go:1:⚠️ file is not goimported (goimports)
4.614 snapshot/containerd/content.go:1:⚠️ file is not goimported (goimports)
4.721 solver/errdefs/vertex.go:1:⚠️ file is not goimported (goimports)
6.066 util/network/cniprovider/cni.go:1:⚠️ file is not goimported (goimports)
ERROR: executor failed running [/bin/sh -c gometalinter --config=gometalinter.json ./...]: buildkit-runc did not terminate successfully
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-13 17:38:56 +02:00
Sebastiaan van Stijn c34699f8dd
CI: fix "--import-cache" deprecation warnings
I noticed these warnings in CI logs;

    +buildctl build --progress=plain --frontend=dockerfile.v0 --opt context=git://github.com/moby/buildkit#refs/pull/1482/merge --opt build-arg:BUILDKIT_CONTEXT_KEEP_GIT_DIR=1 --opt platform=linux/amd64,linux/arm/v7,linux/arm64,linux/s390x,linux/ppc64le,darwin/amd64,windows/amd64 --import-cache cicache.buildk.it/moby/buildkit/master:binaries-cross-helper
    WARN[0000] --import-cache <ref> is deprecated. Please use --import-cache type=registry,ref=<ref>,<opt>=<optval>[,<opt>=<optval>] instead.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-13 16:49:52 +02:00
Akihiro Suda 6f83882a0b
Merge pull request #1486 from tonistiigi/terminal-height
progressui: fix panic on terminals with zero height
2020-05-13 02:49:43 +09:00
Tonis Tiigi a82c3c0728 progressui: fix panic on terminals with zero height
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-11 22:35:06 -07:00
Tõnis Tiigi 8d50628a29
Merge pull request #1481 from thaJeztah/tidy_gomod
Small changes to go.mod
2020-05-11 13:45:05 -07:00
Sebastiaan van Stijn 33b547d29e
vendor: uber/jaeger-client-go v2.11.2
full diff: https://github.com/jaegertracing/jaeger-client-go/compare/e02c85f9069e...v2.11.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-11 20:07:06 +02:00
Sebastiaan van Stijn e0e61e9bc6
vendor: mitchellh/hashstructure v1.0.0
adds a go.mod

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-11 19:54:15 +02:00
Akihiro Suda b67f93529b
Merge pull request #1478 from tonistiigi/close-err
filesync: avoid ignoring close error
2020-05-10 14:53:24 +09:00
Akihiro Suda fa89e7cd3d
Merge pull request #1477 from tonistiigi/userns-fix
file: fix double-remap of old uid value
2020-05-10 14:52:54 +09:00
Tonis Tiigi 6bd2d45527 filesync: avoid ignoring close error
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-08 17:48:56 -07:00
Tonis Tiigi 625f6ecc82 file: fix double-remap of old uid value
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-08 11:33:01 -07:00
Tõnis Tiigi 1e4c221194
Merge pull request #1473 from NewJorg/40726-addchwonexpand
Expand chown value of ADD command
2020-05-07 09:12:52 -07:00
Jörg Franke 5f23bdf9d0 Expand chown value of ADD command
Signed-off-by: Jörg Franke <359489+NewJorg@users.noreply.github.com>
2020-05-02 19:37:23 +02:00
Tibor Vass 99b2abfb76
Merge pull request #1466 from tonistiigi/error-print
buildctl: cleaner typed error printing
2020-04-29 14:22:54 -07:00
Tibor Vass da4e440dbd buidlctl: upon error add line number in addition to filename
Signed-off-by: Tibor Vass <tibor@docker.com>
2020-04-29 20:41:26 +00:00
Tonis Tiigi 365a58177e buildctl: cleaner typed error printing
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-27 21:25:47 -07:00
Tibor Vass 10889212c4
Merge pull request #1454 from tonistiigi/errdefs
errdefs: add support for typed errors
2020-04-27 15:57:55 -07:00
Tõnis Tiigi e0b4ba5d85
Merge pull request #1462 from simonferquel/dont-create-files-on-windows
Avoid creation of irrelevant temporary files on Windows
2020-04-27 08:25:14 -07:00
Simon Ferquel 6d3f568629 Avoid creation of irrelevant temporary files on Windows
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
2020-04-27 15:44:57 +02:00
Tonis Tiigi c78e875977 remove last instances of errors cause
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-24 11:25:53 -07:00
Tonis Tiigi 90288ab716 errdefs: update to new packages
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-24 11:25:44 -07:00
Tonis Tiigi 725f5e1207 grpc interceptors for errors
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-22 18:31:32 -07:00
Tonis Tiigi 2fc9aee26f Revert "grpc: add error handling wrappers to client/server"
This reverts commit 3f77f0495b.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-22 18:31:27 -07:00
Tonis Tiigi c511cdb35a util: add grpcerrors and stack package
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-22 15:58:20 -07:00
Tonis Tiigi 4b2636acca dockerfile: add more source information to errors
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 23:46:17 -07:00
Tonis Tiigi abbda4e941 errdefs: attach source to an error
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 23:46:17 -07:00
Tonis Tiigi cce301badd solver: attach causing vertex in an error
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 23:46:17 -07:00
Tonis Tiigi ae3b75d56d errdefs: report component version in stack
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 23:46:17 -07:00
Tonis Tiigi e4cc0866f5 gateway: fix error details passing through gateway
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 23:46:17 -07:00
Tonis Tiigi 3f77f0495b grpc: add error handling wrappers to client/server
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 23:46:11 -07:00
Tonis Tiigi 02fff48cbd errdefs: add support for typed errors
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 22:57:23 -07:00
Tõnis Tiigi 1c4b5d11b3
Merge pull request #1455 from tonistiigi/remove-func
dockerfile: remove IsUnknownInstruction
2020-04-21 14:15:32 -07:00
Tonis Tiigi bb484dcce3 dockerfile: remove IsUnknownInstruction
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-21 10:44:24 -07:00
Tõnis Tiigi 29ade013e1
Merge pull request #1452 from tonistiigi/parse-errors
dockerfile: include parser error location
2020-04-21 10:40:25 -07:00
Tõnis Tiigi bbd14d2852
Merge pull request #1449 from tonistiigi/gateway-metadata
gateway: fix metadata getting lost on subsolve
2020-04-21 10:40:10 -07:00
Tonis Tiigi e2835e55ad dockerfile: store error location in instructions parser
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-19 20:56:31 -07:00
Akihiro Suda dc792e75b9
Merge pull request #1451 from tonistiigi/errors-is
upgrade errors checks to Is()
2020-04-20 12:53:07 +09:00