From 48768fbba44ae10f9bb1dd0bea1a8c845235c75c Mon Sep 17 00:00:00 2001 From: Joel Smith Date: Wed, 22 Feb 2023 11:02:48 -0800 Subject: [PATCH] fix sql query building (#220) * fix sql query building * adding deps (#221) --------- Co-authored-by: jkennedyvz <65985482+jkennedyvz@users.noreply.github.com> --- .github/workflows/ci.yaml | 2 +- src/db/databaseconnection.cpp | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 95e7d68..a193faf 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -127,7 +127,7 @@ jobs: shell: bash run: | if [ "$RUNNER_OS" == "Linux" ]; then - sudo apt-get update > /dev/null && sudo apt-get install -qqq libxcb-keysyms1-dev libxkbcommon-dev > /dev/null + sudo apt-get update > /dev/null && sudo apt-get install -qqq libxcb-keysyms1-dev libxkbcommon-dev libxkbcommon-x11-dev > /dev/null elif [ "$RUNNER_OS" == "Windows" ]; then choco install ninja --ignore-checksums fi diff --git a/src/db/databaseconnection.cpp b/src/db/databaseconnection.cpp index 28fe008..d6ae2f8 100644 --- a/src/db/databaseconnection.cpp +++ b/src/db/databaseconnection.cpp @@ -194,9 +194,8 @@ bool DatabaseConnection::setEvidenceTags(const QList &newTags, qint6 // sqlite indicates it's default is 100 passed parameter, but it can "handle thousands" if (!tagDataToInsert.empty()) { QVariantList args; - baseQuery.append(QStringLiteral("(?, ?, ?")); + baseQuery.append(QStringLiteral("(?,?,?)")); baseQuery.append(QString(", (?,?,?)").repeated(int(tagDataToInsert.size() - 1))); - baseQuery.append(QStringLiteral(")")); for (const auto &item : tagDataToInsert) { args.append(item.evidenceID); args.append(item.tagID);