This reverts commit adee5315265cc46aa6a3057071527abb16e1cd94.
Turns out one of the "other things" is a dealbreaker.
We only create kegs using a formula's canonical name. However, we do not
check that this is the case when mapping existing kegs back to formula
objects, and thus a keg with a name that happens to be an alias can fool
Homebrew into thinking the canonically-named keg exists.
So anything that enumerates kegs and then tries to do stuff with the
resulting formula objects will just break. This is obviously worse than
the debugger being broken, so reverting this for the time being.
The Readline class clashes with the Readline module from the Ruby
stdlib. This has mostly worked, but with the recent debugging support's
integration of IRB, it is no longer possible for them to coexist. So we
need to rename it.
The implications of this are:
- Anything that depends on readline will reinstall it as
"gnu-readline". Anything already installed will continue to function.
- "brew upgrade readline" will say "gnu-readline not installed", as
"readline" is now an alias.
- Probably other things.
So there are some downsides, but we will just have to deal with them.
FixesHomebrew/homebrew#15776.
*Note*: the docs tarball was not updated in this release, but I
incremented the version for consistency.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
- Make readline a recommended dep in preparation for upcoming
dependency changes
- Remove redundant ENV.Os, as that is the current default
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This is the configure default, but may as well make it explicit. Without this
functionality any library which builds on top of SQLite, such as SpatiaLite,
won't work.
Using readline rather than libedit allows, among other things, the
sharing of the same line-editing config file (.inputrc) across BSDish
and Linux systems. And I'm lazy, and don't want to learn how to
configure editline.
We currently just throw away :optional when processing dependencies, so
if someone really wants libedit instead, we can either make this into an
install option (--with-readline) or vice-versa (--with-libedit).
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
-O3/-O2 leads to corrupt rtree indexes on 10.6/10.7 with both gcc and llvm-gcc.
This issue also affects SpatiaLite.
ClosesHomebrew/homebrew#8584.
Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
* Use new "url" features
* Use keg_only DSL
* Use "skip_clean :all" DSL
* Whitespace and style cleanups
* Make bash invocations less silly
* Use new man2-man8 helpers
* Remove "FileUtils." since it is included in Formula
* Use real names for deps instead of aliases
* ENV.x11 now updates path, so remove that from individual brews
Fixes a potential database corruption problem and a possible performance
regression caused by the introduction of automatic indexing.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
brewkit.rb changes ENV destructively, so lets not do that everytime a formula
is required. Now it's possible for other tools to require a formula
description without worrying about side-effects.
Manuel Reinhardt
Misty De Meo
Samuel John
Lester Cheung
Jack Nagel
Mike McQuaid
Charlie Sharpsteen
Adam Vandenberg
ioxenus
Dane Springmeyer
Lars
Andrew Nesbitt
leafy7382
Oliver Galloway-Lunn
Birger J. Nordølum
Aku Kotkavuo
aktowns
Kashif Rasul
Tojek Anselm
David Höppner
Barry Sears
Max Howell