The MacOS.version? family of methods (other than "leopard?") are poorly
defined and lead to confusing code. Replace them in formulae with more
explicit comparisons.
"MacOS.version" is a special version object that can be compared to
numerics, symbols, and strings using the standard Ruby comparison
methods.
The old methods were moved to compat when the version comparison code
was merged, and they must remain there "forever", but they should not be
used in new code.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Some configure scripts are checking for nspr via pkg-config since most
Linux distros seem to add that to their package.
ClosesHomebrew/homebrew#9705.
Note: upstream has been asked several times over the last few years to
provide pkg-config files, but nothing has come of it.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snow_leopard_64? (defined in Hardware) is a short-cut for:
MACOS_VERSION >= 10.6 and Hardware.is_64_bit?
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
The build was failing under various conditions due to the removal of some link flags at: 26b760ba4f92d67edadae5d3e6b70ff98867fcef
Linking to Carbon is at least required on 10.5 and also for some 10.6 users.
Needed to avoid a bug in OS X when a library was linked against
CoreFoundation without having it initialized in the main thread.
http://openradar.appspot.com/7209349
brewkit.rb changes ENV destructively, so lets not do that everytime a formula
is required. Now it's possible for other tools to require a formula
description without worrying about side-effects.
Signed-off-by: Max Howell <max@methylblue.com>
I squashed a number of commits here, and also replaced the use of nspr.prefix with HOMEBREW_PREFIX as in theory we are flexible with our requirement for dependencies, although with the limited build system that SpiderMonkey possesses this is difficult for us to achieve anyway…
Jack Nagel
Adam Vandenberg
Harald Fernengel
Justin Clift
Alexis Hildebrandt
benoitc
Max Howell
Paul J. Davis
Kieran Pilkington
Sean Wolfe