The MacOS.version? family of methods (other than "leopard?") are poorly
defined and lead to confusing code. Replace them in formulae with more
explicit comparisons.
"MacOS.version" is a special version object that can be compared to
numerics, symbols, and strings using the standard Ruby comparison
methods.
The old methods were moved to compat when the version comparison code
was merged, and they must remain there "forever", but they should not be
used in new code.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Currently we patch mysql_config to sanitize the CFLAGS that are exported
to software that queries it during builds, such as the mysql gem. Since
there isn't any way to control what compiler is used by Ruby/gem to
build native extensions, we must remove any compiler or CPU specific
flags.
Instead, let's build without these flags to begin with, which will keep
mysql_config clean and provide consistency between the flags used to
build mysql and those used to build software that links to it.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
pidof can be replaced with pgrep from proctools on Mountain Lion
and readline uses the system version which, if too old, will use
the bundled version anyway (doesn't on Mountain Lion).
ClosesHomebrew/homebrew#13942.
conflicts_with is a thin wrapper around Requirement which simplifies
marking conflicts between formulae.
ClosesHomebrew/homebrew#13687.
Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
These will be used to unify the label namespaces in embedded plists,
i.e. 'homebrew.mxcl.<formula>'.
plist_path returns the full path to a plist file located at the top
level of the keg; plist_path.basename can be used if just the filename
is needed.
c.f. Homebrew/homebrew#9346.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Added install flags to the mysql formula to allow the ARCHIVE and BLACKHOLE
storage engines to be compiled in.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Not sure how I failed so badly at logic. This should be rewritten so that the build info has a tested MacOS version too. However it seems unlikely that the same LLVM versions on different platforms would have different compile errors. So we'll risk it, and it'll be informative for us too.
MySQL client compiles with EditLine wrapper by default. This formula
configures the build to use readline since it's superior in handling
multibyte input, enabling use of non-English languages in the mysql
prompt.
Users can still choose to use EditLine with the `--with-libedit` flag.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Jack Nagel
Mike McQuaid
Robson Roberto Souza Peixoto
Misty De Meo
Adam Vandenberg
Dan Burkert
onewheelskyward
Steve King
Matthew Lewinski
Jaik Dean
Marian Theisen
Max Howell
Andrew
CharlieRoot
Mislav Marohnić
Felix Schulze
skim
Matthew Rudy Jacobs