Commit Graph

22 Commits (00a22131e2097e9443788f3d62744c8da0e6e68b)

Author SHA1 Message Date
Serhiy Yefremenko 0d02dcabdf do not modify frozen string 2020-09-07 15:15:46 +01:00
Mike McQuaid 7e8631862d cmd: cleanup commands.
Cleanup the code and remove some unused requires.

Needed for https://github.com/Homebrew/brew/pull/8556.
2020-09-01 13:54:03 +01:00
Markus Reiter 8123eba9a7 Fix code style for commands. 2020-08-31 07:49:22 +02:00
Mike McQuaid fccbd331ad
cmd/aspell-dictionaries: fix brew style. 2020-05-22 08:47:18 +01:00
Mike McQuaid fd22985e33
cmd/postgresql-upgrade-database: fix RuboCop Style/ConditionalAssignment. 2020-03-13 20:59:20 +00:00
Mike McQuaid 6399ee19cb cmd: use CLI::Parser.
Migrate all commands to use CLI::Parser.
2020-02-03 18:22:05 +01:00
Bo Anderson 992e817c65
brew-postgresql-upgrade-database: fix locale issues (#47123)
Now all locale and encoding settings are migrated properly.

Also ensure that the old server is not running via `brew services`.

Fixes #47110.
2019-11-25 19:47:36 +00:00
Mike McQuaid b038c78b26
brew-postgresql-upgrade-database: brew style --fix. 2019-10-15 08:59:55 +01:00
Mike McQuaid 11ec1594b4
brew-aspell-dictionaries: brew style --fix. 2019-10-15 08:59:36 +01:00
Mike McQuaid 1dfc565550 brew-aspell-dictionaries: use new Resource#fetch API.
Also improve the code and output so we output everything in a
copy-pasteable format at the end.
2019-06-15 20:44:46 +01:00
Mike McQuaid 6010b3a8d9
brew-postgresql-upgrade-database: re-add strips.
These were mistakenly removed in https://github.com/Homebrew/homebrew-core/pull/39895.

Fixes https://github.com/Homebrew/homebrew-core/issues/40904
2019-06-12 08:34:06 +01:00
Logan Leger 02df2994aa cmd/brew-postgresql-upgrade-database: fix initdb issues.
* Add `safe_system` to `initdb` call to catch errors

If the `initdb` step fails (which it can if the options passed are
invalid), then the script will continue having marked `initdb_run` as
`true`. This causes the script to continue to `pg_upgrade` step which
will fail, ultimately triggering the `ensure` block. Since `initdb_run`
is `true`, the script tries to remove `datadir` which we don't want
since that step failed.

The change here adds `safe_system` to ensure if the `initdb` step fails,
it correctly bails out.

* Add -X to `psql` call to ignore `.psqlrc` files

Customizations in `.psqlrc` files can make the output of `psql`
unpredictable, which can break parsing of the command's output. Using -X
causes `psql` to ignore any such files and use the default output
behavior, which can be parsed with consistency.
2019-06-11 19:05:47 +01:00
Tetsu 0f598dec43 cmd/brew-postgresql-upgrade-database: use --lc-collate and --lc-ctype (#36497) 2019-02-15 15:37:31 +00:00
Mike McQuaid b156521d13 aspell: remove options.
See https://github.com/Homebrew/homebrew-core/issues/31510.

Closes #36225.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>
2019-01-21 18:36:03 +01:00
Mike McQuaid 49dcf82cb4
brew-postgresql-upgrade-database: don't use old kegs. (#35169)
Instead always rely on the versioned formulae that are properly supported.

Reference #34879.
2018-12-16 20:01:17 +00:00
Hugo Hache 2507b57357
brew-postgresql-upgrade-database: abort upgrade if pg_upgrade fails
* Use dedicated safe_system to raise exception

Closes #31175.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2018-08-21 06:04:59 +01:00
Mike McQuaid e453837304 brew-aspell-dictionaries: use more explicit open. 2018-03-06 10:15:39 +00:00
Mike McQuaid d474d480f3 brew-postgresql-upgrade-database: fix name. 2018-01-09 09:06:37 +00:00
Mike McQuaid 25d5a9ef6c brew-postgresql-upgrade-database: add new command. 2018-01-08 16:47:15 +00:00
Mike McQuaid 64b2ddc7e3 aspell-dictionaries: fix help text. 2018-01-08 16:47:15 +00:00
Mike McQuaid 9f0ac390e2 brew-aspell-dictionaries: reverse url/mirror. 2017-12-05 08:59:50 +00:00
Mike McQuaid a8ec9ccd7f brew-aspell-dictionaries: move to homebrew/core.
Experiment with moving this from Homebrew/brew to Homebrew/homebrew-core
(to allow future additions of formula-specific `cmd`s).
2017-12-05 08:59:50 +00:00