From fd85b251f3927cb2a391f0a66b98c706ddc5c9a3 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sun, 4 Dec 2016 14:53:23 +0000 Subject: [PATCH] node@6: import from homebrew/versions. --- Formula/node@6.rb | 170 +++++++++++++++++++++++++++++++++++++++++++ formula_renames.json | 1 + 2 files changed, 171 insertions(+) create mode 100644 Formula/node@6.rb diff --git a/Formula/node@6.rb b/Formula/node@6.rb new file mode 100644 index 00000000000..26dbe6c3a04 --- /dev/null +++ b/Formula/node@6.rb @@ -0,0 +1,170 @@ +class NodeAT6 < Formula + desc "Platform built on V8 to build network applications" + homepage "https://nodejs.org/" + url "https://nodejs.org/dist/v6.9.1/node-v6.9.1.tar.xz" + sha256 "0bdd8d1305777cc8cd206129ea494d6c6ce56001868dd80147aff531d6df0729" + head "https://github.com/nodejs/node.git", :branch => "v6.x-staging" + + option "with-debug", "Build with debugger hooks" + option "with-openssl", "Build against Homebrew's OpenSSL instead of the bundled OpenSSL" + option "without-npm", "npm will not be installed" + option "without-completion", "npm bash completion will not be installed" + option "with-full-icu", "Build with full-icu (all locales) instead of small-icu (English only)" + + depends_on :python => :build if MacOS.version <= :snow_leopard + depends_on "pkg-config" => :build + depends_on "openssl" => :optional + + conflicts_with "node", :because => "Differing versions of the same formula" + conflicts_with "node@0.10", :because => "Differing versions of the same formulae." + conflicts_with "node@0.12", :because => "Differing versions of the same formulae." + conflicts_with "node@4", :because => "Differing versions of the same formulae." + conflicts_with "node@5", :because => "Differing versions of the same formulae." + + # Per upstream - "Need g++ 4.8 or clang++ 3.4". + fails_with :clang if MacOS.version <= :snow_leopard + fails_with :gcc_4_0 + fails_with :gcc + ("4.3".."4.7").each do |n| + fails_with :gcc => n + end + + # We track major/minor from upstream Node releases. + # We will accept *important* npm patch releases when necessary. + # https://github.com/Homebrew/homebrew/pull/46098#issuecomment-157802319 + resource "npm" do + url "https://registry.npmjs.org/npm/-/npm-3.10.8.tgz" + sha256 "1121a75a370fd0efb320fffb7c9e4a8bcb3840d1cf2fbd585c54837b7014dd76" + end + + resource "icu4c" do + url "https://ssl.icu-project.org/files/icu4c/57.1/icu4c-57_1-src.tgz" + mirror "https://fossies.org/linux/misc/icu4c-57_1-src.tgz" + version "57.1" + sha256 "ff8c67cb65949b1e7808f2359f2b80f722697048e90e7cfc382ec1fe229e9581" + end + + def install + # Never install the bundled "npm", always prefer our + # installation from tarball for better packaging control. + args = %W[--prefix=#{prefix} --without-npm] + args << "--debug" if build.with? "debug" + args << "--shared-openssl" if build.with? "openssl" + + if build.with? "full-icu" + resource("icu4c").stage buildpath/"deps/icu" + args << "--with-intl=full-icu" + end + + system "./configure", *args + system "make", "install" + + if build.with? "npm" + resource("npm").stage buildpath/"npm_install" + + # make sure npm can find node + ENV.prepend_path "PATH", bin + # set log level temporarily for npm's `make install` + ENV["NPM_CONFIG_LOGLEVEL"] = "verbose" + # unset prefix temporarily for npm's `make install` + ENV.delete "NPM_CONFIG_PREFIX" + + cd buildpath/"npm_install" do + system "./configure", "--prefix=#{libexec}/npm" + system "make", "install" + # `package.json` has relative paths to the npm_install directory. + # This copies back over the vanilla `package.json` that is expected. + # https://github.com/Homebrew/homebrew/issues/46131#issuecomment-157845008 + cp buildpath/"npm_install/package.json", libexec/"npm/lib/node_modules/npm" + # Remove manpage symlinks from the buildpath, they are breaking bottle + # creation. The real manpages are living in libexec/npm/lib/node_modules/npm/man/ + # https://github.com/Homebrew/homebrew/pull/47081#issuecomment-165280470 + rm_rf libexec/"npm/share/" + end + + if build.with? "completion" + bash_completion.install \ + buildpath/"npm_install/lib/utils/completion.sh" => "npm" + end + end + end + + def post_install + return if build.without? "npm" + + node_modules = HOMEBREW_PREFIX/"lib/node_modules" + node_modules.mkpath + npm_exec = node_modules/"npm/bin/npm-cli.js" + # Kill npm but preserve all other modules across node updates/upgrades. + rm_rf node_modules/"npm" + + cp_r libexec/"npm/lib/node_modules/npm", node_modules + # This symlink doesn't hop into homebrew_prefix/bin automatically so + # remove it and make our own. This is a small consequence of our bottle + # npm make install workaround. All other installs **do** symlink to + # homebrew_prefix/bin correctly. We ln rather than cp this because doing + # so mimics npm's normal install. + ln_sf npm_exec, "#{HOMEBREW_PREFIX}/bin/npm" + + # Let's do the manpage dance. It's just a jump to the left. + # And then a step to the right, with your hand on rm_f. + ["man1", "man3", "man5", "man7"].each do |man| + # Dirs must exist first: https://github.com/Homebrew/homebrew/issues/35969 + mkdir_p HOMEBREW_PREFIX/"share/man/#{man}" + rm_f Dir[HOMEBREW_PREFIX/"share/man/#{man}/{npm.,npm-,npmrc.,package.json.}*"] + ln_sf Dir[libexec/"npm/lib/node_modules/npm/man/#{man}/{npm,package.json}*"], HOMEBREW_PREFIX/"share/man/#{man}" + end + + npm_root = node_modules/"npm" + npmrc = npm_root/"npmrc" + npmrc.atomic_write("prefix = #{HOMEBREW_PREFIX}\n") + end + + def caveats + s = "" + + if build.without? "npm" + s += <<-EOS.undent + Homebrew has NOT installed npm. If you later install it, you should supplement + your NODE_PATH with the npm module folder: + #{HOMEBREW_PREFIX}/lib/node_modules + EOS + end + + if build.without? "full-icu" + s += <<-EOS.undent + Please note by default only English locale support is provided. If you need + full locale support you should either rebuild with full icu: + `brew reinstall node --with-full-icu` + or add full icu data at runtime following: + https://github.com/nodejs/node/wiki/Intl#using-and-customizing-the-small-icu-build + EOS + end + + s + end + + test do + path = testpath/"test.js" + path.write "console.log('hello');" + + output = shell_output("#{bin}/node #{path}").strip + assert_equal "hello", output + output = shell_output("#{bin}/node -e 'console.log(new Intl.NumberFormat(\"en-EN\").format(1234.56))'").strip + assert_equal "1,234.56", output + if build.with? "full-icu" + output = shell_output("#{bin}/node -e 'console.log(new Intl.NumberFormat(\"de-DE\").format(1234.56))'").strip + assert_equal "1.234,56", output + end + + if build.with? "npm" + # make sure npm can find node + ENV.prepend_path "PATH", opt_bin + ENV.delete "NVM_NODEJS_ORG_MIRROR" + assert_equal which("node"), opt_bin/"node" + assert (HOMEBREW_PREFIX/"bin/npm").exist?, "npm must exist" + assert (HOMEBREW_PREFIX/"bin/npm").executable?, "npm must be executable" + system "#{HOMEBREW_PREFIX}/bin/npm", "--verbose", "install", "npm@latest" + end + end +end diff --git a/formula_renames.json b/formula_renames.json index 5ae07933dfb..f18aad18590 100644 --- a/formula_renames.json +++ b/formula_renames.json @@ -32,6 +32,7 @@ "node012": "node@0.12", "node4-lts": "node@4", "node5": "node@5", + "node6-lts": "node@6", "objective-caml": "ocaml", "offline-imap": "offlineimap", "plt-racket": "racket",