isc-dhcp 4.2.1-P1

Ensures that all config and state files are under HOMEBREW_PREFIX.
Configs are in #{etc}, state (leases and pids) in #{var}/dhcpd.

Prevents installed sample config files from clobbering existing
configs by renaming them to #{file}.sample.

Includes launchd plists for both DHCPv4 and DHCPv6.

Creates empty lease files so dhcpd will start on first use.

Added caveats explaining all of the above.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

Formula/isc-dhcp.rb

@@ -1,18 +1,150 @@
 require 'formula'
 
 class IscDhcp < Formula
-  url 'ftp://ftp.isc.org/isc/dhcp/dhcp-3.1.3.tar.gz'
+  version '4.2.1-P1'
+  url 'http://ftp.isc.org/isc/dhcp/dhcp-4.2.1-P1.tar.gz'
   homepage 'http://www.isc.org/software/dhcp'
-  md5 '6ee8af8b283c95b3b4db5e88b6dd9a26'
+  md5 '22e6f1eff6d5cfe2621a06cc62ba5b70'
 
   def install
-    inreplace "Makefile.conf" do |s|
-      s.gsub! "/usr", ""
-      s.gsub! %r[man/cat(\d)], "man/man\\1"
+    # use one dir under var for all runtime state.
+    dhcpd_dir = var+'dhcpd'
+
+    # Change the locations of various files to match Homebrew
+    # we pass these in through CFLAGS since some cannot be changed
+    # via configure args.
+    path_opts = {
+      '_PATH_DHCPD_CONF'    => etc+'dhcpd.conf',
+      '_PATH_DHCLIENT_CONF' => etc+'dhclient.conf',
+      '_PATH_DHCPD_DB'      => dhcpd_dir+'dhcpd.leases',
+      '_PATH_DHCPD6_DB'     => dhcpd_dir+'dhcpd6.leases',
+      '_PATH_DHCLIENT_DB'   => dhcpd_dir+'dhclient.leases',
+      '_PATH_DHCLIENT6_DB'  => dhcpd_dir+'dhclient6.leases',
+      '_PATH_DHCPD_PID'     => dhcpd_dir+'dhcpd.pid',
+      '_PATH_DHCPD6_PID'    => dhcpd_dir+'dhcpd6.pid',
+      '_PATH_DHCLIENT_PID'  => dhcpd_dir+'dhclient.pid',
+      '_PATH_DHCLIENT6_PID' => dhcpd_dir+'dhclient6.pid',
+      '_PATH_DHCRELAY_PID'  => dhcpd_dir+'dhcrelay.pid',
+      '_PATH_DHCRELAY6_PID' => dhcpd_dir+'dhcrelay6.pid',
+    }
+
+    path_opts.each do |symbol,path|
+      ENV.append 'CFLAGS', "-D#{symbol}='\"#{path}\"'"
     end
 
-    system "./configure"
-    system "make"
-    system "make install DESTDIR=#{prefix}"
+    system './configure', "--disable-dependency-tracking",
+                          "--prefix=#{prefix}",
+                          "--localstatedir=#{dhcpd_dir}"
+
+    # the 'bind' subdirectory doesn't like overly parallel builds
+    # so build it sequentially. deparallelizing the whole build
+    # can be slow.
+    previous_makeflags = ENV['MAKEFLAGS']
+    ENV.deparallelize
+    system 'make -C bind'
+    ENV['MAKEFLAGS'] = previous_makeflags
+
+    # build everything else
+    inreplace 'Makefile', 'SUBDIRS = bind', 'SUBDIRS = '
+    system 'make'
+    system 'make install'
+
+    # rename all the installed sample etc/* files so they don't clobber
+    # any existing config files at symlink time.
+    Dir.open(prefix+'etc') do |dir|
+      dir.each do |f|
+        file = "#{dir.path}/#{f}"
+        File.rename(file, "#{file}.sample") if File.stat(file).file?
+      end
+    end
+
+    # create the state dir and lease files else dhcpd will not start up.
+    dhcpd_dir.mkpath
+    %w(dhcpd dhcpd6 dhclient dhclient6).each do |f|
+      file = "#{dhcpd_dir}/#{f}.leases"
+      File.new(file, File::CREAT|File::RDONLY).close
+    end
+
+    # sample launchd plists
+    (prefix+'org.isc.dhcpd.plist').write dhcpd_plist
+    (prefix+'org.isc.dhcpd6.plist').write dhcpd6_plist
+  end
+
+  def caveats
+    <<-EOCAVEATS.undent
+    This install of dhcpd expects config files to be in /usr/local/etc.
+    All state files (leases and pids) are stored in /usr/local/var/dhcpd.
+
+    Dhcpd needs to run as root since it listens on privileged ports.
+    Sample launchd plists to achieve this have been provided at:
+      #{prefix}/org.isc.dhcpd.plist
+    and:
+      #{prefix}/org.isc.dhcpd6.plist
+
+    There are two plists because a single dhcpd process may do either
+    DHCPv4 or DHCPv6 but not both. Use one or both as needed.
+
+    Copy the plists to /Library/LaunchDaemons and start the services with
+      cd /Library/LaunchDaemons
+      launchctl load -w org.isc.dhcpd.plist
+      launchctl load -w org.isc.dhcpd6.plist
+
+    Note that you must create the appropriate config files before starting
+    the services or dhcpd will refuse to run.
+      DHCPv4: /usr/local/etc/dhcpd.conf
+      DHCPv6: /usr/local/etc/dhcpd6.conf
+
+    Sample config files may be found in #{etc}.
+    If you change the config, restart dhcpd with one or both of
+      launchctl stop org.isc.dhcpd
+      launchctl stop org.isc.dhcpd6
+    EOCAVEATS
+  end
+
+  def dhcpd_plist
+    <<-EOPLIST.undent
+    <?xml version='1.0' encoding='UTF-8'?>
+    <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"
+                    "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+    <plist version='1.0'>
+    <dict>
+    <key>Label</key><string>org.isc.dhcpd</string>
+    <key>ProgramArguments</key>
+      <array>
+        <string>/usr/local/sbin/dhcpd</string>
+        <string>-f</string>
+      </array>
+    <key>Disabled</key><false/>
+    <key>KeepAlive</key><true/>
+    <key>RunAtLoad</key><true/>
+    <key>LowPriorityIO</key><true/>
+    </dict>
+    </plist>
+    EOPLIST
+  end
+
+  def dhcpd6_plist
+    <<-EOPLIST.undent
+    <?xml version='1.0' encoding='UTF-8'?>
+    <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"
+                    "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+    <plist version='1.0'>
+    <dict>
+    <key>Label</key><string>org.isc.dhcpd</string>
+    <key>ProgramArguments</key>
+      <array>
+        <string>/usr/local/sbin/dhcpd</string>
+        <string>-f</string>
+        <string>-6</string>
+        <string>-cf</string>
+        <string>/usr/local/etc/dhcpd6.conf</string>
+      </array>
+    <key>Disabled</key><false/>
+    <key>KeepAlive</key><true/>
+    <key>RunAtLoad</key><true/>
+    <key>LowPriorityIO</key><true/>
+    </dict>
+    </plist>
+    EOPLIST
   end
 end