Prefer Dir[] to Dir.glob when not passing a block

master
Jack Nagel 2014-05-30 12:38:30 -05:00
parent b67b2e10f9
commit 2257ca4e29
3 changed files with 3 additions and 5 deletions

View File

@ -172,7 +172,7 @@ class Boost < Formula
s = ''
# ENV.compiler doesn't exist in caveats. Check library availability
# instead.
if Dir.glob("#{lib}/libboost_log*").empty?
if Dir["#{lib}/libboost_log*"].empty?
s += <<-EOS.undent
Building of Boost.Log is disabled because it requires newer GCC or Clang.

View File

@ -52,7 +52,7 @@ class Geoip < Formula
# Since default data directory moved, copy existing DBs
legacy_data = Pathname.new "#{HOMEBREW_PREFIX}/share/GeoIP"
cp Dir.glob("#{legacy_data}/*"), geoip_data if legacy_data.exist?
cp Dir["#{legacy_data}/*"], geoip_data if legacy_data.exist?
["City", "Country"].each do |type|
full = Pathname.new "#{geoip_data}/GeoIP#{type}.dat"

View File

@ -111,9 +111,7 @@ class Python3 < Formula
system "make", "quicktest" if build.include? "quicktest"
# Any .app get a " 3" attached, so it does not conflict with python 2.x.
Dir.glob(prefix/"*.app").each do |app|
mv app, app.gsub(".app", " 3.app")
end
Dir.glob("#{prefix}/*.app") { |app| mv app, app.sub(".app", " 3.app") }
# A fix, because python and python3 both want to install Python.framework
# and therefore we can't link both into HOMEBREW_PREFIX/Frameworks