package remote import ( "testing" awssdk "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/awserr" "github.com/aws/aws-sdk-go/aws/session" "github.com/aws/aws-sdk-go/service/s3" "github.com/cloudskiff/driftctl/mocks" "github.com/cloudskiff/driftctl/pkg/remote/aws" "github.com/cloudskiff/driftctl/pkg/remote/cache" "github.com/cloudskiff/driftctl/pkg/remote/common" tf "github.com/cloudskiff/driftctl/pkg/remote/terraform" testresource "github.com/cloudskiff/driftctl/test/resource" terraform2 "github.com/cloudskiff/driftctl/test/terraform" "github.com/stretchr/testify/mock" "github.com/cloudskiff/driftctl/pkg/remote/aws/client" "github.com/cloudskiff/driftctl/pkg/remote/aws/repository" "github.com/cloudskiff/driftctl/pkg/resource" resourceaws "github.com/cloudskiff/driftctl/pkg/resource/aws" "github.com/cloudskiff/driftctl/pkg/terraform" "github.com/cloudskiff/driftctl/test" "github.com/cloudskiff/driftctl/test/goldenfile" "github.com/stretchr/testify/assert" ) func TestS3Bucket(t *testing.T) { tests := []struct { test string dirName string mocks func(repository *repository.MockS3Repository) wantErr error }{ { test: "multiple bucket", dirName: "aws_s3_bucket_multiple", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, {Name: awssdk.String("bucket-martin-test-drift2")}, {Name: awssdk.String("bucket-martin-test-drift3")}, }, nil) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-1", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift2", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift3", ).Return( "ap-northeast-1", nil, ) }, }, { test: "cannot list bucket", dirName: "s3_bucket_list", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return(nil, awserr.NewRequestFailure(nil, 403, "")) }, wantErr: nil, }, } schemaRepository := testresource.InitFakeSchemaRepository("aws", "3.19.0") resourceaws.InitResourcesMetadata(schemaRepository) factory := terraform.NewTerraformResourceFactory(schemaRepository) deserializer := resource.NewDeserializer(factory) for _, c := range tests { t.Run(c.test, func(tt *testing.T) { shouldUpdate := c.dirName == *goldenfile.Update session := session.Must(session.NewSessionWithOptions(session.Options{ SharedConfigState: session.SharedConfigEnable, })) scanOptions := ScannerOptions{Deep: true} providerLibrary := terraform.NewProviderLibrary() remoteLibrary := common.NewRemoteLibrary() // Initialize mocks alerter := &mocks.AlerterInterface{} alerter.On("SendAlert", mock.Anything, mock.Anything).Maybe().Return() fakeRepo := &repository.MockS3Repository{} c.mocks(fakeRepo) var repo repository.S3Repository = fakeRepo providerVersion := "3.19.0" realProvider, err := terraform2.InitTestAwsProvider(providerLibrary, providerVersion) if err != nil { t.Fatal(err) } provider := terraform2.NewFakeTerraformProvider(realProvider) provider.WithResponse(c.dirName) // Replace mock by real resources if we are in update mode if shouldUpdate { err := realProvider.Init() if err != nil { t.Fatal(err) } provider.ShouldUpdate() repo = repository.NewS3Repository(client.NewAWSClientFactory(session), cache.New(0)) } remoteLibrary.AddEnumerator(aws.NewS3BucketEnumerator(repo, factory, tf.TerraformProviderConfig{ Name: "test", DefaultAlias: "eu-west-3", })) remoteLibrary.AddDetailsFetcher(resourceaws.AwsS3BucketResourceType, aws.NewS3BucketDetailsFetcher(provider, deserializer)) s := NewScanner(nil, remoteLibrary, alerter, scanOptions) got, err := s.Resources() assert.Equal(tt, err, c.wantErr) if err != nil { return } test.TestAgainstGoldenFile(got, resourceaws.AwsS3BucketResourceType, c.dirName, provider, deserializer, shouldUpdate, tt) }) } } func TestS3BucketInventory(t *testing.T) { tests := []struct { test string dirName string mocks func(repository *repository.MockS3Repository) wantErr error }{ { test: "multiple bucket with multiple inventories", dirName: "s3_bucket_inventories_multiple", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, {Name: awssdk.String("bucket-martin-test-drift2")}, {Name: awssdk.String("bucket-martin-test-drift3")}, }, nil) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-1", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift2", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift3", ).Return( "eu-west-1", nil, ) repository.On( "ListBucketInventoryConfigurations", &s3.Bucket{Name: awssdk.String("bucket-martin-test-drift2")}, "eu-west-3", ).Return( []*s3.InventoryConfiguration{ {Id: awssdk.String("Inventory_Bucket2")}, {Id: awssdk.String("Inventory2_Bucket2")}, }, nil, ) }, }, { test: "cannot list bucket", dirName: "s3_bucket_inventories_list_bucket", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return(nil, awserr.NewRequestFailure(nil, 403, "")) }, wantErr: nil, }, { test: "cannot list bucket inventories", dirName: "s3_bucket_inventories_list_inventories", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return( []*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, }, nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-3", nil, ) repository.On( "ListBucketInventoryConfigurations", &s3.Bucket{Name: awssdk.String("bucket-martin-test-drift")}, "eu-west-3", ).Return( nil, awserr.NewRequestFailure(nil, 403, ""), ) }, wantErr: nil, }, } schemaRepository := testresource.InitFakeSchemaRepository("aws", "3.19.0") resourceaws.InitResourcesMetadata(schemaRepository) factory := terraform.NewTerraformResourceFactory(schemaRepository) deserializer := resource.NewDeserializer(factory) for _, c := range tests { t.Run(c.test, func(tt *testing.T) { shouldUpdate := c.dirName == *goldenfile.Update session := session.Must(session.NewSessionWithOptions(session.Options{ SharedConfigState: session.SharedConfigEnable, })) scanOptions := ScannerOptions{Deep: true} providerLibrary := terraform.NewProviderLibrary() remoteLibrary := common.NewRemoteLibrary() // Initialize mocks alerter := &mocks.AlerterInterface{} alerter.On("SendAlert", mock.Anything, mock.Anything).Maybe().Return() fakeRepo := &repository.MockS3Repository{} c.mocks(fakeRepo) var repo repository.S3Repository = fakeRepo providerVersion := "3.19.0" realProvider, err := terraform2.InitTestAwsProvider(providerLibrary, providerVersion) if err != nil { t.Fatal(err) } provider := terraform2.NewFakeTerraformProvider(realProvider) provider.WithResponse(c.dirName) // Replace mock by real resources if we are in update mode if shouldUpdate { err := realProvider.Init() if err != nil { t.Fatal(err) } provider.ShouldUpdate() repo = repository.NewS3Repository(client.NewAWSClientFactory(session), cache.New(0)) } remoteLibrary.AddEnumerator(aws.NewS3BucketInventoryEnumerator(repo, factory, tf.TerraformProviderConfig{ Name: "test", DefaultAlias: "eu-west-3", })) remoteLibrary.AddDetailsFetcher(resourceaws.AwsS3BucketInventoryResourceType, aws.NewS3BucketInventoryDetailsFetcher(provider, deserializer)) s := NewScanner(nil, remoteLibrary, alerter, scanOptions) got, err := s.Resources() assert.Equal(tt, err, c.wantErr) if err != nil { return } test.TestAgainstGoldenFile(got, resourceaws.AwsS3BucketInventoryResourceType, c.dirName, provider, deserializer, shouldUpdate, tt) }) } } func TestS3BucketNotification(t *testing.T) { tests := []struct { test string dirName string mocks func(repository *repository.MockS3Repository) wantErr error }{ { test: "single bucket without notifications", dirName: "s3_bucket_notifications_no_notif", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("dritftctl-test-no-notifications")}, }, nil) repository.On( "GetBucketLocation", "dritftctl-test-no-notifications", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketNotification", "dritftctl-test-no-notifications", "eu-west-3", ).Return( nil, nil, ) }, }, { test: "multiple bucket with notifications", dirName: "s3_bucket_notifications_multiple", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, {Name: awssdk.String("bucket-martin-test-drift2")}, {Name: awssdk.String("bucket-martin-test-drift3")}, }, nil) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-1", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift2", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketNotification", "bucket-martin-test-drift2", "eu-west-3", ).Return( &s3.NotificationConfiguration{ LambdaFunctionConfigurations: []*s3.LambdaFunctionConfiguration{ { Id: awssdk.String("tf-s3-lambda-20201103165354926600000001"), }, { Id: awssdk.String("tf-s3-lambda-20201103165354926600000002"), }, }, }, nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift3", ).Return( "ap-northeast-1", nil, ) }, }, { test: "Cannot get bucket notification", dirName: "s3_bucket_notifications_list_bucket", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("dritftctl-test-notifications-error")}, }, nil) repository.On( "GetBucketLocation", "dritftctl-test-notifications-error", ).Return( "eu-west-3", nil, ) repository.On("GetBucketNotification", "dritftctl-test-notifications-error", "eu-west-3").Return(nil, awserr.NewRequestFailure(nil, 403, "")) }, wantErr: nil, }, { test: "Cannot list bucket", dirName: "s3_bucket_notifications_list_bucket", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return(nil, awserr.NewRequestFailure(nil, 403, "")) }, wantErr: nil, }, } schemaRepository := testresource.InitFakeSchemaRepository("aws", "3.19.0") resourceaws.InitResourcesMetadata(schemaRepository) factory := terraform.NewTerraformResourceFactory(schemaRepository) deserializer := resource.NewDeserializer(factory) for _, c := range tests { t.Run(c.test, func(tt *testing.T) { shouldUpdate := c.dirName == *goldenfile.Update session := session.Must(session.NewSessionWithOptions(session.Options{ SharedConfigState: session.SharedConfigEnable, })) scanOptions := ScannerOptions{Deep: true} providerLibrary := terraform.NewProviderLibrary() remoteLibrary := common.NewRemoteLibrary() // Initialize mocks alerter := &mocks.AlerterInterface{} alerter.On("SendAlert", mock.Anything, mock.Anything).Maybe().Return() fakeRepo := &repository.MockS3Repository{} c.mocks(fakeRepo) var repo repository.S3Repository = fakeRepo providerVersion := "3.19.0" realProvider, err := terraform2.InitTestAwsProvider(providerLibrary, providerVersion) if err != nil { t.Fatal(err) } provider := terraform2.NewFakeTerraformProvider(realProvider) provider.WithResponse(c.dirName) // Replace mock by real resources if we are in update mode if shouldUpdate { err := realProvider.Init() if err != nil { t.Fatal(err) } provider.ShouldUpdate() repo = repository.NewS3Repository(client.NewAWSClientFactory(session), cache.New(0)) } remoteLibrary.AddEnumerator(aws.NewS3BucketNotificationEnumerator(repo, factory, tf.TerraformProviderConfig{ Name: "test", DefaultAlias: "eu-west-3", })) remoteLibrary.AddDetailsFetcher(resourceaws.AwsS3BucketNotificationResourceType, aws.NewS3BucketNotificationDetailsFetcher(provider, deserializer)) s := NewScanner(nil, remoteLibrary, alerter, scanOptions) got, err := s.Resources() assert.Equal(tt, err, c.wantErr) if err != nil { return } test.TestAgainstGoldenFile(got, resourceaws.AwsS3BucketNotificationResourceType, c.dirName, provider, deserializer, shouldUpdate, tt) }) } } func TestS3BucketMetrics(t *testing.T) { tests := []struct { test string dirName string mocks func(repository *repository.MockS3Repository) wantErr error }{ { test: "multiple bucket with multiple metrics", dirName: "s3_bucket_metrics_multiple", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, {Name: awssdk.String("bucket-martin-test-drift2")}, {Name: awssdk.String("bucket-martin-test-drift3")}, }, nil) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-1", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift2", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift3", ).Return( "ap-northeast-1", nil, ) repository.On( "ListBucketMetricsConfigurations", &s3.Bucket{Name: awssdk.String("bucket-martin-test-drift2")}, "eu-west-3", ).Return( []*s3.MetricsConfiguration{ {Id: awssdk.String("Metrics_Bucket2")}, {Id: awssdk.String("Metrics2_Bucket2")}, }, nil, ) }, }, { test: "cannot list bucket", dirName: "s3_bucket_metrics_list_bucket", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return(nil, awserr.NewRequestFailure(nil, 403, "")) }, wantErr: nil, }, { test: "cannot list metrics", dirName: "s3_bucket_metrics_list_metrics", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return( []*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, }, nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-3", nil, ) repository.On( "ListBucketMetricsConfigurations", &s3.Bucket{Name: awssdk.String("bucket-martin-test-drift")}, "eu-west-3", ).Return( nil, awserr.NewRequestFailure(nil, 403, ""), ) }, wantErr: nil, }, } schemaRepository := testresource.InitFakeSchemaRepository("aws", "3.19.0") resourceaws.InitResourcesMetadata(schemaRepository) factory := terraform.NewTerraformResourceFactory(schemaRepository) deserializer := resource.NewDeserializer(factory) for _, c := range tests { t.Run(c.test, func(tt *testing.T) { shouldUpdate := c.dirName == *goldenfile.Update session := session.Must(session.NewSessionWithOptions(session.Options{ SharedConfigState: session.SharedConfigEnable, })) scanOptions := ScannerOptions{Deep: true} providerLibrary := terraform.NewProviderLibrary() remoteLibrary := common.NewRemoteLibrary() // Initialize mocks alerter := &mocks.AlerterInterface{} alerter.On("SendAlert", mock.Anything, mock.Anything).Maybe().Return() fakeRepo := &repository.MockS3Repository{} c.mocks(fakeRepo) var repo repository.S3Repository = fakeRepo providerVersion := "3.19.0" realProvider, err := terraform2.InitTestAwsProvider(providerLibrary, providerVersion) if err != nil { t.Fatal(err) } provider := terraform2.NewFakeTerraformProvider(realProvider) provider.WithResponse(c.dirName) // Replace mock by real resources if we are in update mode if shouldUpdate { err := realProvider.Init() if err != nil { t.Fatal(err) } provider.ShouldUpdate() repo = repository.NewS3Repository(client.NewAWSClientFactory(session), cache.New(0)) } remoteLibrary.AddEnumerator(aws.NewS3BucketMetricsEnumerator(repo, factory, tf.TerraformProviderConfig{ Name: "test", DefaultAlias: "eu-west-3", })) remoteLibrary.AddDetailsFetcher(resourceaws.AwsS3BucketMetricResourceType, aws.NewS3BucketMetricsDetailsFetcher(provider, deserializer)) s := NewScanner(nil, remoteLibrary, alerter, scanOptions) got, err := s.Resources() assert.Equal(tt, err, c.wantErr) if err != nil { return } test.TestAgainstGoldenFile(got, resourceaws.AwsS3BucketMetricResourceType, c.dirName, provider, deserializer, shouldUpdate, tt) }) } } func TestS3BucketPolicy(t *testing.T) { tests := []struct { test string dirName string mocks func(repository *repository.MockS3Repository) wantErr error }{ { test: "single bucket without policy", dirName: "s3_bucket_policy_no_policy", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("dritftctl-test-no-policy")}, }, nil) repository.On( "GetBucketLocation", "dritftctl-test-no-policy", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketPolicy", "dritftctl-test-no-policy", "eu-west-3", ).Return( nil, nil, ) }, }, { test: "multiple bucket with policies", dirName: "s3_bucket_policies_multiple", mocks: func(repository *repository.MockS3Repository) { repository.On( "ListAllBuckets", ).Return([]*s3.Bucket{ {Name: awssdk.String("bucket-martin-test-drift")}, {Name: awssdk.String("bucket-martin-test-drift2")}, {Name: awssdk.String("bucket-martin-test-drift3")}, }, nil) repository.On( "GetBucketLocation", "bucket-martin-test-drift", ).Return( "eu-west-1", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift2", ).Return( "eu-west-3", nil, ) repository.On( "GetBucketLocation", "bucket-martin-test-drift3", ).Return( "ap-northeast-1", nil, ) repository.On( "GetBucketPolicy", "bucket-martin-test-drift2", "eu-west-3", ).Return( // The value here not matter, we only want something not empty // to trigger the detail fetcher awssdk.String("foobar"), nil, ) }, }, { test: "cannot list bucket", dirName: "s3_bucket_policies_list_bucket", mocks: func(repository *repository.MockS3Repository) { repository.On("ListAllBuckets").Return(nil, awserr.NewRequestFailure(nil, 403, "")) }, wantErr: nil, }, } schemaRepository := testresource.InitFakeSchemaRepository("aws", "3.19.0") resourceaws.InitResourcesMetadata(schemaRepository) factory := terraform.NewTerraformResourceFactory(schemaRepository) deserializer := resource.NewDeserializer(factory) for _, c := range tests { t.Run(c.test, func(tt *testing.T) { shouldUpdate := c.dirName == *goldenfile.Update session := session.Must(session.NewSessionWithOptions(session.Options{ SharedConfigState: session.SharedConfigEnable, })) scanOptions := ScannerOptions{Deep: true} providerLibrary := terraform.NewProviderLibrary() remoteLibrary := common.NewRemoteLibrary() // Initialize mocks alerter := &mocks.AlerterInterface{} alerter.On("SendAlert", mock.Anything, mock.Anything).Maybe().Return() fakeRepo := &repository.MockS3Repository{} c.mocks(fakeRepo) var repo repository.S3Repository = fakeRepo providerVersion := "3.19.0" realProvider, err := terraform2.InitTestAwsProvider(providerLibrary, providerVersion) if err != nil { t.Fatal(err) } provider := terraform2.NewFakeTerraformProvider(realProvider) provider.WithResponse(c.dirName) // Replace mock by real resources if we are in update mode if shouldUpdate { err := realProvider.Init() if err != nil { t.Fatal(err) } provider.ShouldUpdate() repo = repository.NewS3Repository(client.NewAWSClientFactory(session), cache.New(0)) } remoteLibrary.AddEnumerator(aws.NewS3BucketPolicyEnumerator(repo, factory, tf.TerraformProviderConfig{ Name: "test", DefaultAlias: "eu-west-3", })) remoteLibrary.AddDetailsFetcher(resourceaws.AwsS3BucketPolicyResourceType, aws.NewS3BucketPolicyDetailsFetcher(provider, deserializer)) s := NewScanner(nil, remoteLibrary, alerter, scanOptions) got, err := s.Resources() assert.Equal(tt, err, c.wantErr) if err != nil { return } test.TestAgainstGoldenFile(got, resourceaws.AwsS3BucketPolicyResourceType, c.dirName, provider, deserializer, shouldUpdate, tt) }) } }