sundowndev
/
driftctl
mirror of https://github.com/sundowndev/driftctl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make enumeration diagnostic messages more generic

main
Elie 2022-08-18 12:10:10 +02:00
parent a1a4d70e64
commit de753eb4cb
No known key found for this signature in database
GPG Key ID: 399AF69092C727B6
6 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
enumeration/remote/alerts/alerts.go
View File

@ -31,21 +31,21 @@ func NewRemoteAccessDeniedAlert(provider string, scanErr *remoteerror.ResourceSc
switch scanningPhase {
case EnumerationPhase:
message = fmt.Sprintf(
"Ignoring %s from drift calculation: Listing %s is forbidden: %s",
"An error occured listing %s: listing %s is forbidden: %s",
scanErr.Resource(),
scanErr.ListedTypeError(),
scanErr.RootCause().Error(),
)
case DetailsFetchingPhase:
message = fmt.Sprintf(
"Ignoring %s from drift calculation: Reading details of %s is forbidden: %s",
"An error occured listing %s: reading details of %s is forbidden: %s",
scanErr.Resource(),
scanErr.ListedTypeError(),
scanErr.RootCause().Error(),
)
default:
message = fmt.Sprintf(
"Ignoring %s from drift calculation: %s",
"An error occured listing %s: %s",
scanErr.Resource(),
scanErr.RootCause().Error(),
)

6
pkg/cmd/scan/output/testdata/output.html vendored
View File

@ -681,17 +681,17 @@ input[type="search"], select {
<li data-kind="resource-alerts" class="resource-item">
<span>Ignoring aws_vpc from drift calculation: Listing aws_vpc is forbidden: dummy error</span>
<span>An error occured listing aws_vpc: listing aws_vpc is forbidden: dummy error</span>
</li>
<li data-kind="resource-alerts" class="resource-item">
<span>Ignoring aws_sqs from drift calculation: Listing aws_sqs is forbidden: dummy error</span>
<span>An error occured listing aws_sqs: listing aws_sqs is forbidden: dummy error</span>
</li>
<li data-kind="resource-alerts" class="resource-item">
<span>Ignoring aws_sns from drift calculation: Listing aws_sns is forbidden: dummy error</span>
<span>An error occured listing aws_sns: listing aws_sns is forbidden: dummy error</span>
</li>

6
pkg/cmd/scan/output/testdata/output_access_denied_alert_aws.json vendored
View File

@ -20,13 +20,13 @@
"alerts": {
"": [
{
"message": "Ignoring aws_vpc from drift calculation: Listing aws_vpc is forbidden: dummy error"
"message": "An error occured listing aws_vpc: listing aws_vpc is forbidden: dummy error"
},
{
"message": "Ignoring aws_sqs from drift calculation: Listing aws_sqs is forbidden: dummy error"
"message": "An error occured listing aws_sqs: listing aws_sqs is forbidden: dummy error"
},
{
"message": "Ignoring aws_sns from drift calculation: Listing aws_sns is forbidden: dummy error"
"message": "An error occured listing aws_sns: listing aws_sns is forbidden: dummy error"
}
]
},

6
pkg/cmd/scan/output/testdata/output_access_denied_alert_aws.txt vendored
View File

@ -1,9 +1,9 @@
Found 0 resource(s)
- 0% coverage
Congrats! Your infrastructure is fully in sync.
Ignoring aws_vpc from drift calculation: Listing aws_vpc is forbidden: dummy error
Ignoring aws_sqs from drift calculation: Listing aws_sqs is forbidden: dummy error
Ignoring aws_sns from drift calculation: Listing aws_sns is forbidden: dummy error
An error occured listing aws_vpc: listing aws_vpc is forbidden: dummy error
An error occured listing aws_sqs: listing aws_sqs is forbidden: dummy error
An error occured listing aws_sns: listing aws_sns is forbidden: dummy error
It seems that we got access denied exceptions while listing resources.
The latest minimal read-only IAM policy for driftctl is always available here, please update yours: https://docs.driftctl.com/aws/policy

4
pkg/cmd/scan/output/testdata/output_access_denied_alert_github.json vendored
View File

@ -20,10 +20,10 @@
"alerts": {
"": [
{
"message": "Ignoring github_team from drift calculation: Listing github_team is forbidden: dummy error"
"message": "An error occured listing github_team: listing github_team is forbidden: dummy error"
},
{
"message": "Ignoring github_team_membership from drift calculation: Listing github_team is forbidden: dummy error"
"message": "An error occured listing github_team_membership: listing github_team is forbidden: dummy error"
}
]
},

4
pkg/cmd/scan/output/testdata/output_access_denied_alert_github.txt vendored
View File

@ -1,8 +1,8 @@
Found 0 resource(s)
- 0% coverage
Congrats! Your infrastructure is fully in sync.
Ignoring github_team from drift calculation: Listing github_team is forbidden: dummy error
Ignoring github_team_membership from drift calculation: Listing github_team is forbidden: dummy error
An error occured listing github_team: listing github_team is forbidden: dummy error
An error occured listing github_team_membership: listing github_team is forbidden: dummy error
It seems that we got access denied exceptions while listing resources.
Please be sure that your Github token has the right permissions, check the last up-to-date documentation there: https://docs.driftctl.com/github/policy