sundowndev
/
driftctl
mirror of https://github.com/sundowndev/driftctl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue 331: Update test to check diff.Changelog and not resource.Resource

main
Louis TOUSSAINT 2021-03-30 18:23:04 +02:00 committed by sundowndev
parent 1927fd07f6
commit cfdb6801a9
1 changed files with 20 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
pkg/middlewares/aws_iam_policy_attachment_defaults_test.go
View File

@ -16,7 +16,7 @@ func TestAwsIamPolicyAttachmentDefaults_Execute(t *testing.T) {
name string
remoteResources []resource.Resource
resourcesFromState []resource.Resource
expected []resource.Resource
expected diff.Changelog
}{
{
"test that default iam policy attachment are excluded when not managed by IaC",
@ -33,11 +33,7 @@ func TestAwsIamPolicyAttachmentDefaults_Execute(t *testing.T) {
Id: "driftctl_test-arn:aws:iam::0123456789:policy/driftctl",
},
},
[]resource.Resource{
&aws.AwsIamPolicyAttachment{
Id: "driftctl_test-arn:aws:iam::0123456789:policy/driftctl",
},
},
diff.Changelog{},
},
{
"test that default iam policy attachment are not excluded when managed by IaC",
@ -53,16 +49,15 @@ func TestAwsIamPolicyAttachmentDefaults_Execute(t *testing.T) {
&aws.AwsIamPolicyAttachment{
Id: "AWSServiceRoleForSSO-arn:aws:iam::aws:policy/aws-service-role/AWSSSOServiceRolePolicy",
},
&aws.AwsIamPolicyAttachment{
Id: "driftctl_test-arn:aws:iam::0123456789:policy/driftctl",
},
},
[]resource.Resource{
&aws.AwsIamPolicyAttachment{
Id: "AWSServiceRoleForSSO-arn:aws:iam::aws:policy/aws-service-role/AWSSSOServiceRolePolicy",
},
&aws.AwsIamPolicyAttachment{
Id: "driftctl_test-arn:aws:iam::0123456789:policy/driftctl",
diff.Changelog{
{
Type: "delete",
Path: []string{"1"},
From: &aws.AwsIamPolicyAttachment{
Id: "driftctl_test-arn:aws:iam::0123456789:policy/driftctl",
},
To: nil,
},
},
},
@ -80,12 +75,18 @@ func TestAwsIamPolicyAttachmentDefaults_Execute(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if len(changelog) > 0 {
for _, change := range changelog {
t.Errorf("%s got = %v, want %v", strings.Join(change.Path, "."), awsutil.Prettify(change.From), awsutil.Prettify(change.To))
}
diffs, err := diff.Diff(tt.expected, changelog)
if err != nil {
t.Fatal(err)
}
if len(diffs) == 0 {
return
}
for _, change := range diffs {
t.Errorf("%s got = %v, want %v", strings.Join(change.Path, "."), awsutil.Prettify(change.From), awsutil.Prettify(change.To))
}
})
}
}