sundowndev
/
driftctl
mirror of https://github.com/sundowndev/driftctl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1188 from cloudskiff/retry-policy-comment 

Add missing comment for retry policy in ACC tests
main
Elie 2021-10-27 15:59:53 +02:00 committed by GitHub
parent 7225d4c0a8 331fbe6b89
commit 791be3553c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/resource/google/google_cloudfunctions_function_test.go
View File

@ -18,7 +18,7 @@ func TestAcc_Google_CloudFunctionsFunction(t *testing.T) {
},
Checks: []acceptance.AccCheck{
{
// New cloud function resources are not visible immediatly on GCP api after an apply
// New resources are not visible immediately on GCP api after an apply
// Logic below retry driftctl scan until we can retrieve the results (infra will be in sync) and for maximum 60 seconds
ShouldRetry: func(result *test.ScanResult, retryDuration time.Duration, retryCount uint8) bool {
return !result.IsSync() && retryDuration < time.Minute

2
pkg/resource/google/google_storage_bucket_test.go
View File

@ -18,6 +18,8 @@ func TestAcc_Google_StorageBucket(t *testing.T) {
},
Checks: []acceptance.AccCheck{
{
// New resources are not visible immediately on GCP api after an apply
// Logic below retry driftctl scan until we can retrieve the results (infra will be in sync) and for maximum 60 seconds
ShouldRetry: func(result *test.ScanResult, retryDuration time.Duration, retryCount uint8) bool {
return !result.IsSync() && retryDuration < time.Minute
},