Merge pull request #864 from cloudskiff/feat/emptyResultsGoldenfile

Avoid the need of golden files for empty results in remote testing
2021-07-21 18:36:56 +02:00 · 2021-07-21 18:36:56 +02:00 · 134f8dce18
parent 751a836993 d1436cdac3
commit 134f8dce18
142 changed files with 20 additions and 93 deletions
--- a/pkg/iac/terraform/state/terraform_state_reader_test.go
+++ b/pkg/iac/terraform/state/terraform_state_reader_test.go
@ -140,7 +140,7 @@ func TestTerraformStateReader_AWS_Resources(t *testing.T) {
 			}

 			got, err := r.Resources()
-			resGoldenName := "result.golden.json"
+			resGoldenName := goldenfile.ResultsFilename
 			if shouldUpdate {
 				unm, err := json.Marshal(got)
 				if err != nil {
@ -224,7 +224,7 @@ func TestTerraformStateReader_Github_Resources(t *testing.T) {
 			}

 			got, err := r.Resources()
-			resGoldenName := "result.golden.json"
+			resGoldenName := goldenfile.ResultsFilename
 			if shouldUpdate {
 				unm, err := json.Marshal(got)
 				if err != nil {
--- a/pkg/iac/terraform/state/test/aws_lambda_event_source_mapping/results.golden.json
+++ b/pkg/iac/terraform/state/test/aws_lambda_event_source_mapping/results.golden.json
--- a/pkg/iac/terraform/state/test/aws_nat_gateway/results.golden.json
+++ b/pkg/iac/terraform/state/test/aws_nat_gateway/results.golden.json
--- a/pkg/iac/terraform/state/test/cloudfront_distribution/results.golden.json
+++ b/pkg/iac/terraform/state/test/cloudfront_distribution/results.golden.json
--- a/pkg/iac/terraform/state/test/data_source/result.golden.json
+++ b/pkg/iac/terraform/state/test/data_source/result.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/iac/terraform/state/test/db_instance/results.golden.json
+++ b/pkg/iac/terraform/state/test/db_instance/results.golden.json
--- a/pkg/iac/terraform/state/test/db_subnet_group/results.golden.json
+++ b/pkg/iac/terraform/state/test/db_subnet_group/results.golden.json
--- a/pkg/iac/terraform/state/test/dynamodb_table/results.golden.json
+++ b/pkg/iac/terraform/state/test/dynamodb_table/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_ami/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_ami/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_ebs_snapshot/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_ebs_snapshot/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_ebs_volume/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_ebs_volume/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_eip/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_eip/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_eip_association/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_eip_association/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_instance/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_instance/results.golden.json
--- a/pkg/iac/terraform/state/test/ec2_key_pair/results.golden.json
+++ b/pkg/iac/terraform/state/test/ec2_key_pair/results.golden.json
--- a/pkg/iac/terraform/state/test/ecr_repository/results.golden.json
+++ b/pkg/iac/terraform/state/test/ecr_repository/results.golden.json
--- a/pkg/iac/terraform/state/test/github_branch_protection/results.golden.json
+++ b/pkg/iac/terraform/state/test/github_branch_protection/results.golden.json
--- a/pkg/iac/terraform/state/test/github_membership/results.golden.json
+++ b/pkg/iac/terraform/state/test/github_membership/results.golden.json
--- a/pkg/iac/terraform/state/test/github_repository/results.golden.json
+++ b/pkg/iac/terraform/state/test/github_repository/results.golden.json
--- a/pkg/iac/terraform/state/test/github_team/results.golden.json
+++ b/pkg/iac/terraform/state/test/github_team/results.golden.json
--- a/pkg/iac/terraform/state/test/github_team_membership/results.golden.json
+++ b/pkg/iac/terraform/state/test/github_team_membership/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_access_key_multiple/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_access_key_multiple/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_policy_multiple/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_policy_multiple/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_role_multiple/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_role_multiple/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_role_policy_attachment/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_role_policy_attachment/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_role_policy_multiple/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_role_policy_multiple/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_user_multiple/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_user_multiple/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_user_policy_attachment/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_user_policy_attachment/results.golden.json
--- a/pkg/iac/terraform/state/test/iam_user_policy_multiple/results.golden.json
+++ b/pkg/iac/terraform/state/test/iam_user_policy_multiple/results.golden.json
--- a/pkg/iac/terraform/state/test/internet_gateway/results.golden.json
+++ b/pkg/iac/terraform/state/test/internet_gateway/results.golden.json
--- a/pkg/iac/terraform/state/test/kms_alias/results.golden.json
+++ b/pkg/iac/terraform/state/test/kms_alias/results.golden.json
--- a/pkg/iac/terraform/state/test/kms_key/results.golden.json
+++ b/pkg/iac/terraform/state/test/kms_key/results.golden.json
--- a/pkg/iac/terraform/state/test/lambda_function/results.golden.json
+++ b/pkg/iac/terraform/state/test/lambda_function/results.golden.json
--- a/pkg/iac/terraform/state/test/module.iam_iam-user/results.golden.json
+++ b/pkg/iac/terraform/state/test/module.iam_iam-user/results.golden.json
--- a/pkg/iac/terraform/state/test/route/results.golden.json
+++ b/pkg/iac/terraform/state/test/route/results.golden.json
--- a/pkg/iac/terraform/state/test/route53_health_check/results.golden.json
+++ b/pkg/iac/terraform/state/test/route53_health_check/results.golden.json
--- a/pkg/iac/terraform/state/test/route53_record/results.golden.json
+++ b/pkg/iac/terraform/state/test/route53_record/results.golden.json
--- a/pkg/iac/terraform/state/test/route53_record_multiples/results.golden.json
+++ b/pkg/iac/terraform/state/test/route53_record_multiples/results.golden.json
--- a/pkg/iac/terraform/state/test/route53_record_null_records/results.golden.json
+++ b/pkg/iac/terraform/state/test/route53_record_null_records/results.golden.json
--- a/pkg/iac/terraform/state/test/route53_zone/results.golden.json
+++ b/pkg/iac/terraform/state/test/route53_zone/results.golden.json
--- a/pkg/iac/terraform/state/test/route_assoc/results.golden.json
+++ b/pkg/iac/terraform/state/test/route_assoc/results.golden.json
--- a/pkg/iac/terraform/state/test/route_table/results.golden.json
+++ b/pkg/iac/terraform/state/test/route_table/results.golden.json
--- a/pkg/iac/terraform/state/test/s3_full/results.golden.json
+++ b/pkg/iac/terraform/state/test/s3_full/results.golden.json
--- a/pkg/iac/terraform/state/test/sns_topic/results.golden.json
+++ b/pkg/iac/terraform/state/test/sns_topic/results.golden.json
--- a/pkg/iac/terraform/state/test/sns_topic_policy/results.golden.json
+++ b/pkg/iac/terraform/state/test/sns_topic_policy/results.golden.json
--- a/pkg/iac/terraform/state/test/sns_topic_subscription/results.golden.json
+++ b/pkg/iac/terraform/state/test/sns_topic_subscription/results.golden.json
--- a/pkg/iac/terraform/state/test/sqs_queue/results.golden.json
+++ b/pkg/iac/terraform/state/test/sqs_queue/results.golden.json
--- a/pkg/iac/terraform/state/test/sqs_queue_policy/results.golden.json
+++ b/pkg/iac/terraform/state/test/sqs_queue_policy/results.golden.json
--- a/pkg/iac/terraform/state/test/subnet/results.golden.json
+++ b/pkg/iac/terraform/state/test/subnet/results.golden.json
--- a/pkg/iac/terraform/state/test/unsupported_attribute/results.golden.json
+++ b/pkg/iac/terraform/state/test/unsupported_attribute/results.golden.json
--- a/pkg/iac/terraform/state/test/unsupported_provider/results.golden.json
+++ b/pkg/iac/terraform/state/test/unsupported_provider/results.golden.json
--- a/pkg/iac/terraform/state/test/unsupported_resource/result.golden.json
+++ b/pkg/iac/terraform/state/test/unsupported_resource/result.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/iac/terraform/state/test/vpc/results.golden.json
+++ b/pkg/iac/terraform/state/test/vpc/results.golden.json
--- a/pkg/iac/terraform/state/test/vpc_security_group/results.golden.json
+++ b/pkg/iac/terraform/state/test/vpc_security_group/results.golden.json
--- a/pkg/iac/terraform/state/test/vpc_security_group_rule/results.golden.json
+++ b/pkg/iac/terraform/state/test/vpc_security_group_rule/results.golden.json
--- a/pkg/remote/test/aws_cloudfront_distribution_empty/results.golden.json
+++ b/pkg/remote/test/aws_cloudfront_distribution_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_cloudfront_distribution_list/results.golden.json
+++ b/pkg/remote/test/aws_cloudfront_distribution_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_ami_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_ami_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_ami_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_ami_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_default_route_table_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_default_route_table_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_default_route_table_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_default_route_table_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_default_subnet_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_default_subnet_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_default_subnet_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_default_subnet_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_ebs_snapshot_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_ebs_snapshot_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_ebs_snapshot_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_ebs_snapshot_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_ebs_volume_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_ebs_volume_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_ebs_volume_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_ebs_volume_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_eip_association_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_eip_association_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_eip_association_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_eip_association_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_eip_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_eip_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_eip_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_eip_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_instance_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_instance_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_instance_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_instance_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_internet_gateway_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_internet_gateway_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_internet_gateway_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_internet_gateway_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_key_pair_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_key_pair_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_key_pair_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_key_pair_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_nat_gateway_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_nat_gateway_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_nat_gateway_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_nat_gateway_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_route_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_route_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_route_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_route_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_route_table_association_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_route_table_association_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_route_table_association_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_route_table_association_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_route_table_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_route_table_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_route_table_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_route_table_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_subnet_empty/results.golden.json
+++ b/pkg/remote/test/aws_ec2_subnet_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ec2_subnet_list/results.golden.json
+++ b/pkg/remote/test/aws_ec2_subnet_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_ecr_repository_empty/results.golden.json
+++ b/pkg/remote/test/aws_ecr_repository_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_iam_role_policy_attachment_empty/results.golden.json
+++ b/pkg/remote/test/aws_iam_role_policy_attachment_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_iam_role_policy_empty/results.golden.json
+++ b/pkg/remote/test/aws_iam_role_policy_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_kms_alias_empty/results.golden.json
+++ b/pkg/remote/test/aws_kms_alias_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_kms_alias_list/results.golden.json
+++ b/pkg/remote/test/aws_kms_alias_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_kms_key_empty/results.golden.json
+++ b/pkg/remote/test/aws_kms_key_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_kms_key_list/results.golden.json
+++ b/pkg/remote/test/aws_kms_key_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_rds_db_instance_empty/results.golden.json
+++ b/pkg/remote/test/aws_rds_db_instance_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_rds_db_instance_list/results.golden.json
+++ b/pkg/remote/test/aws_rds_db_instance_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_rds_db_subnet_group_empty/results.golden.json
+++ b/pkg/remote/test/aws_rds_db_subnet_group_empty/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_rds_db_subnet_group_list/results.golden.json
+++ b/pkg/remote/test/aws_rds_db_subnet_group_list/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_s3_bucket_analytics_list_analytics/results.golden.json
+++ b/pkg/remote/test/aws_s3_bucket_analytics_list_analytics/results.golden.json
@ -1 +0,0 @@
-[]
--- a/pkg/remote/test/aws_s3_bucket_analytics_list_bucket/results.golden.json
+++ b/pkg/remote/test/aws_s3_bucket_analytics_list_bucket/results.golden.json
@ -1 +0,0 @@
-[]
--- a/Show More
+++ b/Show More