driftctl/pkg/remote/aws/iam_role_policy_attachment_...

218 lines
7.0 KiB
Go
Raw Normal View History

package aws
import (
"context"
"testing"
remoteerror "github.com/cloudskiff/driftctl/pkg/remote/error"
2021-05-04 16:37:45 +00:00
awstest "github.com/cloudskiff/driftctl/test/aws"
2021-05-21 14:09:45 +00:00
testresource "github.com/cloudskiff/driftctl/test/resource"
resourceaws "github.com/cloudskiff/driftctl/pkg/resource/aws"
"github.com/aws/aws-sdk-go/aws/awserr"
2021-01-15 11:44:13 +00:00
"github.com/cloudskiff/driftctl/pkg/parallel"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/iam"
"github.com/cloudskiff/driftctl/test/goldenfile"
mocks2 "github.com/cloudskiff/driftctl/test/mocks"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/cloudskiff/driftctl/pkg/resource"
"github.com/cloudskiff/driftctl/pkg/terraform"
"github.com/cloudskiff/driftctl/test"
)
func TestIamRolePolicyAttachmentSupplier_Resources(t *testing.T) {
cases := []struct {
test string
dirName string
2021-05-04 16:37:45 +00:00
mocks func(client *awstest.MockFakeIAM)
err error
}{
{
test: "iam multiples roles multiple policies",
dirName: "iam_role_policy_attachment_multiple",
2021-05-04 16:37:45 +00:00
mocks: func(client *awstest.MockFakeIAM) {
client.On("ListRolesPages",
&iam.ListRolesInput{},
mock.MatchedBy(func(callback func(res *iam.ListRolesOutput, lastPage bool) bool) bool {
callback(&iam.ListRolesOutput{Roles: []*iam.Role{
{
RoleName: aws.String("test-role"),
},
{
RoleName: aws.String("test-role2"),
},
}}, true)
return true
})).Return(nil).Once()
shouldSkipfirst := false
shouldSkipSecond := false
client.On("ListAttachedRolePoliciesPages",
&iam.ListAttachedRolePoliciesInput{
RoleName: aws.String("test-role"),
},
mock.MatchedBy(func(callback func(res *iam.ListAttachedRolePoliciesOutput, lastPage bool) bool) bool {
if shouldSkipfirst {
return false
}
callback(&iam.ListAttachedRolePoliciesOutput{AttachedPolicies: []*iam.AttachedPolicy{
2021-05-21 14:09:45 +00:00
{
PolicyArn: aws.String("arn:aws:iam::047081014315:policy/test-policy"),
PolicyName: aws.String("test-policy"),
},
2021-05-21 14:09:45 +00:00
{
PolicyArn: aws.String("arn:aws:iam::047081014315:policy/test-policy2"),
PolicyName: aws.String("test-policy2"),
},
}}, false)
callback(&iam.ListAttachedRolePoliciesOutput{AttachedPolicies: []*iam.AttachedPolicy{
2021-05-21 14:09:45 +00:00
{
PolicyArn: aws.String("arn:aws:iam::047081014315:policy/test-policy3"),
PolicyName: aws.String("test-policy3"),
},
}}, true)
shouldSkipfirst = true
return true
})).Return(nil).Once()
client.On("ListAttachedRolePoliciesPages",
&iam.ListAttachedRolePoliciesInput{
RoleName: aws.String("test-role2"),
},
mock.MatchedBy(func(callback func(res *iam.ListAttachedRolePoliciesOutput, lastPage bool) bool) bool {
if shouldSkipSecond {
return false
}
callback(&iam.ListAttachedRolePoliciesOutput{AttachedPolicies: []*iam.AttachedPolicy{
2021-05-21 14:09:45 +00:00
{
PolicyArn: aws.String("arn:aws:iam::047081014315:policy/test-policy"),
PolicyName: aws.String("test-policy"),
},
2021-05-21 14:09:45 +00:00
{
PolicyArn: aws.String("arn:aws:iam::047081014315:policy/test-policy2"),
PolicyName: aws.String("test-policy2"),
},
}}, false)
callback(&iam.ListAttachedRolePoliciesOutput{AttachedPolicies: []*iam.AttachedPolicy{
2021-05-21 14:09:45 +00:00
{
PolicyArn: aws.String("arn:aws:iam::047081014315:policy/test-policy3"),
PolicyName: aws.String("test-policy3"),
},
}}, true)
shouldSkipSecond = true
return true
})).Return(nil).Once()
},
err: nil,
},
{
test: "check that we ignore policy for ignored roles",
dirName: "iam_role_policy_attachment_for_ignored_roles",
2021-05-04 16:37:45 +00:00
mocks: func(client *awstest.MockFakeIAM) {
client.On("ListRolesPages",
&iam.ListRolesInput{},
mock.MatchedBy(func(callback func(res *iam.ListRolesOutput, lastPage bool) bool) bool {
callback(&iam.ListRolesOutput{Roles: []*iam.Role{
{
RoleName: aws.String("AWSServiceRoleForOrganizations"),
},
{
RoleName: aws.String("AWSServiceRoleForSupport"),
},
{
RoleName: aws.String("AWSServiceRoleForTrustedAdvisor"),
},
}}, true)
return true
})).Return(nil)
},
err: nil,
},
{
test: "Cannot list roles",
dirName: "iam_role_policy_attachment_for_ignored_roles",
2021-05-04 16:37:45 +00:00
mocks: func(client *awstest.MockFakeIAM) {
client.On("ListRolesPages",
&iam.ListRolesInput{},
mock.MatchedBy(func(callback func(res *iam.ListRolesOutput, lastPage bool) bool) bool {
callback(&iam.ListRolesOutput{Roles: []*iam.Role{}}, true)
return true
})).Return(awserr.NewRequestFailure(nil, 403, ""))
},
err: remoteerror.NewResourceEnumerationErrorWithType(awserr.NewRequestFailure(nil, 403, ""), resourceaws.AwsIamRolePolicyAttachmentResourceType, resourceaws.AwsIamRoleResourceType),
},
{
test: "Cannot list roles policies",
dirName: "iam_role_policy_attachment_for_ignored_roles",
2021-05-04 16:37:45 +00:00
mocks: func(client *awstest.MockFakeIAM) {
client.On("ListRolesPages",
&iam.ListRolesInput{},
mock.MatchedBy(func(callback func(res *iam.ListRolesOutput, lastPage bool) bool) bool {
callback(&iam.ListRolesOutput{Roles: []*iam.Role{
{
RoleName: aws.String("test-role"),
},
{
RoleName: aws.String("test-role2"),
},
}}, true)
return true
})).Return(nil).Once()
client.On("ListAttachedRolePoliciesPages",
mock.Anything,
mock.MatchedBy(func(callback func(res *iam.ListAttachedRolePoliciesOutput, lastPage bool) bool) bool {
return true
})).Return(awserr.NewRequestFailure(nil, 403, "")).Once()
},
err: remoteerror.NewResourceEnumerationErrorWithType(awserr.NewRequestFailure(nil, 403, ""), resourceaws.AwsIamRolePolicyAttachmentResourceType, resourceaws.AwsIamRolePolicyResourceType),
},
}
for _, c := range cases {
shouldUpdate := c.dirName == *goldenfile.Update
providerLibrary := terraform.NewProviderLibrary()
supplierLibrary := resource.NewSupplierLibrary()
2021-05-21 14:09:45 +00:00
repo := testresource.InitFakeSchemaRepository("aws", "3.19.0")
resourceaws.InitResourcesMetadata(repo)
factory := terraform.NewTerraformResourceFactory(repo)
deserializer := resource.NewDeserializer(factory)
if shouldUpdate {
provider, err := InitTestAwsProvider(providerLibrary)
if err != nil {
t.Fatal(err)
}
2021-05-21 14:09:45 +00:00
supplierLibrary.AddSupplier(NewIamRolePolicyAttachmentSupplier(provider, deserializer))
}
t.Run(c.test, func(tt *testing.T) {
2021-05-04 16:37:45 +00:00
fakeIam := awstest.MockFakeIAM{}
c.mocks(&fakeIam)
provider := mocks2.NewMockedGoldenTFProvider(c.dirName, providerLibrary.Provider(terraform.AWS), shouldUpdate)
s := &IamRolePolicyAttachmentSupplier{
provider,
deserializer,
&fakeIam,
2021-01-15 11:44:13 +00:00
terraform.NewParallelResourceReader(parallel.NewParallelRunner(context.TODO(), 1)),
}
got, err := s.Resources()
assert.Equal(tt, c.err, err)
mock.AssertExpectationsForObjects(tt)
2021-05-21 14:09:45 +00:00
test.CtyTestDiff(got, c.dirName, provider, deserializer, shouldUpdate, t)
})
}
}