driftctl/pkg/cmd/scan/output/output_test.go

595 lines
14 KiB
Go
Raw Normal View History

package output
import (
"fmt"
"reflect"
"testing"
"github.com/pkg/errors"
"github.com/r3labs/diff/v2"
2021-12-06 13:29:39 +00:00
"github.com/snyk/driftctl/pkg/alerter"
"github.com/snyk/driftctl/pkg/analyser"
"github.com/snyk/driftctl/pkg/output"
"github.com/snyk/driftctl/pkg/remote/alerts"
"github.com/snyk/driftctl/pkg/remote/common"
remoteerr "github.com/snyk/driftctl/pkg/remote/error"
"github.com/snyk/driftctl/pkg/resource"
)
func fakeAnalysis(opts analyser.AnalyzerOptions) *analyser.Analysis {
if opts == (analyser.AnalyzerOptions{}) {
opts = analyser.AnalyzerOptions{Deep: true}
}
a := analyser.NewAnalysis(opts)
a.AddUnmanaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "unmanaged-id-1",
Type: "aws_unmanaged_resource",
},
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "unmanaged-id-2",
Type: "aws_unmanaged_resource",
},
)
a.AddDeleted(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "deleted-id-1",
Type: "aws_deleted_resource",
Source: &resource.TerraformStateSource{
State: "tfstate://delete_state.tfstate",
Module: "module",
Name: "name",
},
2021-08-09 14:03:04 +00:00
}, &resource.Resource{
Id: "deleted-id-2",
Type: "aws_deleted_resource",
},
)
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "diff-id-1",
Type: "aws_diff_resource",
},
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "no-diff-id-1",
Type: "aws_no_diff_resource",
},
)
2021-09-07 11:47:13 +00:00
// Cover the case when a diff occur on a resource without a source
a.AddDifference(analyser.Difference{
Res: &resource.Resource{
Id: "diff-id-2",
Type: "aws_diff_resource",
},
Changelog: []analyser.Change{
{
Change: diff.Change{
Type: diff.UPDATE,
Path: []string{"updated", "field"},
From: "foobar",
To: "barfoo",
},
},
},
})
2021-08-09 14:03:04 +00:00
a.AddDifference(analyser.Difference{Res: &resource.Resource{
Id: "diff-id-1",
Type: "aws_diff_resource",
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
},
},
Changelog: []analyser.Change{
{
Change: diff.Change{
Type: diff.UPDATE,
Path: []string{"updated", "field"},
From: "foobar",
To: "barfoo",
},
2021-01-08 17:14:26 +00:00
},
{
Change: diff.Change{
Type: diff.CREATE,
Path: []string{"new", "field"},
From: nil,
To: "newValue",
},
2021-01-08 17:14:26 +00:00
},
{
Change: diff.Change{
Type: diff.DELETE,
Path: []string{"a"},
From: "oldValue",
To: nil,
},
},
}})
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return a
}
2021-04-22 16:21:00 +00:00
func fakeAnalysisWithAlerts() *analyser.Analysis {
a := fakeAnalysis(analyser.AnalyzerOptions{})
2021-04-22 16:21:00 +00:00
a.SetAlerts(alerter.Alerts{
"": []alerter.Alert{
alerts.NewRemoteAccessDeniedAlert(common.RemoteAWSTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "aws_vpc", "aws_vpc"), alerts.EnumerationPhase),
alerts.NewRemoteAccessDeniedAlert(common.RemoteAWSTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "aws_sqs", "aws_sqs"), alerts.EnumerationPhase),
alerts.NewRemoteAccessDeniedAlert(common.RemoteAWSTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "aws_sns", "aws_sns"), alerts.EnumerationPhase),
2021-04-22 16:21:00 +00:00
},
})
2021-07-29 09:50:35 +00:00
a.ProviderVersion = "3.19.0"
2021-04-22 16:21:00 +00:00
return a
}
func fakeAnalysisNoDrift() *analyser.Analysis {
a := analyser.Analysis{}
for i := 0; i < 5; i++ {
2021-08-09 14:03:04 +00:00
a.AddManaged(&resource.Resource{
Id: "managed-id-" + fmt.Sprintf("%d", i),
Type: "aws_managed_resource",
})
}
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return &a
}
func fakeAnalysisWithJsonFields() *analyser.Analysis {
a := analyser.NewAnalysis(analyser.AnalyzerOptions{Deep: true})
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "diff-id-1",
Type: "aws_diff_resource",
},
)
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "diff-id-2",
Type: "aws_diff_resource",
},
)
a.AddDifference(analyser.Difference{
2021-08-09 14:03:04 +00:00
Res: &resource.Resource{
Id: "diff-id-1",
Type: "aws_diff_resource",
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
2021-01-08 17:14:26 +00:00
},
},
Changelog: []analyser.Change{
{
JsonString: true,
Change: diff.Change{
Type: diff.UPDATE,
Path: []string{"Json"},
From: "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Removed\":\"Added\",\"Changed\":[\"oldValue1\", \"oldValue2\"],\"Effect\":\"Allow\",\"Resource\":\"*\"}]}",
To: "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Changed\":\"newValue\",\"NewField\":[\"foobar\"],\"Effect\":\"Allow\",\"Resource\":\"*\"}]}",
},
},
}})
a.AddDifference(analyser.Difference{
2021-08-09 14:03:04 +00:00
Res: &resource.Resource{
Id: "diff-id-2",
Type: "aws_diff_resource",
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
2021-01-08 17:14:26 +00:00
},
},
Changelog: []analyser.Change{
{
JsonString: true,
Change: diff.Change{
Type: diff.UPDATE,
Path: []string{"Json"},
From: "{\"foo\":\"bar\"}",
To: "{\"bar\":\"foo\"}",
},
},
}})
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return a
}
func fakeAnalysisWithoutAttrs() *analyser.Analysis {
a := analyser.NewAnalysis(analyser.AnalyzerOptions{Deep: true})
a.AddDeleted(
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-05-21 14:09:45 +00:00
Id: "dfjkgnbsgj",
2021-08-09 14:03:04 +00:00
Type: "FakeResourceStringer",
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{},
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
},
},
)
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-05-21 14:09:45 +00:00
Id: "usqyfsdbgjsdgjkdfg",
2021-08-09 14:03:04 +00:00
Type: "FakeResourceStringer",
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{},
},
)
a.AddUnmanaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-05-21 14:09:45 +00:00
Id: "duysgkfdjfdgfhd",
2021-08-09 14:03:04 +00:00
Type: "FakeResourceStringer",
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{},
},
)
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return a
}
func fakeAnalysisWithStringerResources() *analyser.Analysis {
a := analyser.NewAnalysis(analyser.AnalyzerOptions{Deep: true})
2021-08-09 14:03:04 +00:00
schema := &resource.Schema{HumanReadableAttributesFunc: func(res *resource.Resource) map[string]string {
return map[string]string{
"Name": (*res.Attrs)["name"].(string),
}
}}
a.AddDeleted(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "dfjkgnbsgj",
Type: "FakeResourceStringer",
2021-08-09 14:03:04 +00:00
Sch: schema,
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{
"name": "deleted resource",
},
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
},
},
)
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "usqyfsdbgjsdgjkdfg",
Type: "FakeResourceStringer",
2021-08-09 14:03:04 +00:00
Sch: schema,
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{
"name": "managed resource",
},
},
)
a.AddUnmanaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
Id: "duysgkfdjfdgfhd",
Type: "FakeResourceStringer",
2021-08-09 14:03:04 +00:00
Sch: schema,
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{
"name": "unmanaged resource",
},
},
)
2021-08-09 14:03:04 +00:00
a.AddDifference(analyser.Difference{Res: &resource.Resource{
Id: "gdsfhgkbn",
Type: "FakeResourceStringer",
2021-08-09 14:03:04 +00:00
Sch: schema,
2021-05-21 14:09:45 +00:00
Attrs: &resource.Attributes{
"name": "resource with diff",
},
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
},
2021-01-08 17:14:26 +00:00
}, Changelog: []analyser.Change{
{
2021-01-08 17:14:26 +00:00
Change: diff.Change{
Type: diff.UPDATE,
Path: []string{"Name"},
From: "",
To: "resource with diff",
},
},
}})
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return a
}
2020-12-16 12:02:02 +00:00
func fakeAnalysisWithComputedFields() *analyser.Analysis {
a := analyser.NewAnalysis(analyser.AnalyzerOptions{Deep: true})
2020-12-16 12:02:02 +00:00
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
2020-12-16 12:02:02 +00:00
Id: "diff-id-1",
Type: "aws_diff_resource",
},
)
a.AddDifference(analyser.Difference{
2021-08-09 14:03:04 +00:00
Res: &resource.Resource{
Id: "diff-id-1",
Type: "aws_diff_resource",
Source: &resource.TerraformStateSource{
State: "tfstate://state.tfstate",
Module: "module",
Name: "name",
2021-01-08 17:14:26 +00:00
},
}, Changelog: []analyser.Change{
{
Change: diff.Change{
Type: diff.UPDATE,
Path: []string{"updated", "field"},
From: "foobar",
To: "barfoo",
},
Computed: true,
2021-01-08 17:14:26 +00:00
},
{
Change: diff.Change{
Type: diff.CREATE,
Path: []string{"new", "field"},
From: nil,
To: "newValue",
},
2021-01-08 17:14:26 +00:00
},
{
Change: diff.Change{
Type: diff.DELETE,
Path: []string{"a"},
From: "oldValue",
To: nil,
2021-01-08 17:14:26 +00:00
},
Computed: true,
2020-12-16 12:02:02 +00:00
},
{
Change: diff.Change{
Type: diff.UPDATE,
From: "foo",
To: "oof",
Path: []string{
"struct",
"0",
"array",
"0",
},
2021-01-08 17:14:26 +00:00
},
Computed: true,
2020-12-16 12:02:02 +00:00
},
{
Change: diff.Change{
Type: diff.UPDATE,
From: "one",
To: "two",
Path: []string{
"struct",
"0",
"string",
},
},
Computed: true,
},
}})
2021-01-11 16:33:23 +00:00
a.SetAlerts(alerter.Alerts{
"": []alerter.Alert{
analyser.NewComputedDiffAlert(),
},
})
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return a
}
func fakeAnalysisWithAWSEnumerationError() *analyser.Analysis {
a := analyser.Analysis{}
a.SetAlerts(alerter.Alerts{
"": []alerter.Alert{
alerts.NewRemoteAccessDeniedAlert(common.RemoteAWSTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "aws_vpc", "aws_vpc"), alerts.EnumerationPhase),
alerts.NewRemoteAccessDeniedAlert(common.RemoteAWSTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "aws_sqs", "aws_sqs"), alerts.EnumerationPhase),
alerts.NewRemoteAccessDeniedAlert(common.RemoteAWSTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "aws_sns", "aws_sns"), alerts.EnumerationPhase),
},
})
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return &a
}
func fakeAnalysisWithGithubEnumerationError() *analyser.Analysis {
a := analyser.Analysis{}
a.SetAlerts(alerter.Alerts{
"": []alerter.Alert{
alerts.NewRemoteAccessDeniedAlert(common.RemoteGithubTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "github_team", "github_team"), alerts.EnumerationPhase),
alerts.NewRemoteAccessDeniedAlert(common.RemoteGithubTerraform, remoteerr.NewResourceListingErrorWithType(errors.New("dummy error"), "github_team_membership", "github_team"), alerts.EnumerationPhase),
2020-12-16 12:02:02 +00:00
},
})
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
2020-12-16 12:02:02 +00:00
return &a
}
2021-06-09 14:06:21 +00:00
func fakeAnalysisForJSONPlan() *analyser.Analysis {
a := analyser.Analysis{}
a.AddUnmanaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-06-09 14:06:21 +00:00
Id: "unmanaged-id-1",
Type: "aws_unmanaged_resource",
Attrs: &resource.Attributes{
"name": "First unmanaged resource",
},
},
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-06-09 14:06:21 +00:00
Id: "unmanaged-id-2",
Type: "aws_unmanaged_resource",
Attrs: &resource.Attributes{
"name": "Second unmanaged resource",
},
},
)
a.AddManaged(
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-06-09 14:06:21 +00:00
Id: "managed-id-1",
Type: "aws_managed_resource",
Attrs: &resource.Attributes{
"name": "First managed resource",
},
},
2021-08-09 14:03:04 +00:00
&resource.Resource{
2021-06-09 14:06:21 +00:00
Id: "managed-id-2",
Type: "aws_managed_resource",
Attrs: &resource.Attributes{
"name": "Second managed resource",
},
},
)
2021-07-29 09:50:35 +00:00
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
2021-06-09 14:06:21 +00:00
return &a
}
func fakeAnalysisWithoutDeep() *analyser.Analysis {
a := analyser.Analysis{}
a.AddUnmanaged(
&resource.Resource{
Id: "unmanaged-id-1",
Type: "aws_unmanaged_resource",
Attrs: &resource.Attributes{
"name": "First unmanaged resource",
},
},
)
a.ProviderName = "AWS"
a.ProviderVersion = "3.19.0"
return &a
}
func TestGetPrinter(t *testing.T) {
tests := []struct {
name string
path string
key string
quiet bool
want output.Printer
}{
{
name: "json file output",
path: "/path/to/file",
key: JSONOutputType,
want: output.NewConsolePrinter(),
},
{
name: "json file output quiet",
path: "/path/to/file",
key: JSONOutputType,
quiet: true,
want: &output.VoidPrinter{},
},
{
name: "json stdout output",
path: "stdout",
key: JSONOutputType,
want: &output.VoidPrinter{},
},
{
name: "json /dev/stdout output",
path: "/dev/stdout",
key: JSONOutputType,
want: &output.VoidPrinter{},
},
{
name: "console stdout output",
path: "stdout",
key: ConsoleOutputType,
want: output.NewConsolePrinter(),
},
{
name: "quiet console stdout output",
path: "stdout",
quiet: true,
key: ConsoleOutputType,
want: &output.VoidPrinter{},
},
2021-06-09 14:06:21 +00:00
{
name: "jsonplan file output",
path: "/path/to/file",
key: PlanOutputType,
want: output.NewConsolePrinter(),
},
{
name: "jsonplan stdout output",
path: "stdout",
key: PlanOutputType,
want: &output.VoidPrinter{},
},
{
name: "jsonplan /dev/stdout output",
path: "/dev/stdout",
key: PlanOutputType,
want: &output.VoidPrinter{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := GetPrinter(OutputConfig{
Key: tt.key,
Path: tt.path,
}, tt.quiet); !reflect.DeepEqual(got, tt.want) {
t.Errorf("GetPrinter() = %v, want %v", got, tt.want)
}
})
}
}
2021-11-10 16:58:11 +00:00
func TestShouldPrint(t *testing.T) {
tests := []struct {
name string
outputs []OutputConfig
quiet bool
want bool
}{
{
name: "test stdout prevents printing",
outputs: []OutputConfig{
{
Path: "stdout",
Key: JSONOutputType,
},
},
want: false,
},
{
name: "test output to file doesn't prevent printing",
outputs: []OutputConfig{
{
Path: "result.json",
Key: JSONOutputType,
},
},
want: true,
},
{
name: "test stdout prevents printing",
outputs: []OutputConfig{
{
Path: "result.json",
Key: JSONOutputType,
},
{
Path: "stdout",
Key: PlanOutputType,
},
},
want: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := ShouldPrint(tt.outputs, tt.quiet); got != tt.want {
t.Errorf("ShouldPrint() = %v, want %v", got, tt.want)
}
})
}
}