67 lines
2.0 KiB
Go
67 lines
2.0 KiB
Go
/*
|
|
Copyright 2019 DigitalOcean
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package doks
|
|
|
|
import (
|
|
"github.com/digitalocean/clusterlint/checks"
|
|
"github.com/digitalocean/clusterlint/kube"
|
|
corev1 "k8s.io/api/core/v1"
|
|
)
|
|
|
|
func init() {
|
|
checks.Register(&podSelectorCheck{})
|
|
}
|
|
|
|
type podSelectorCheck struct{}
|
|
|
|
// Name returns a unique name for this check.
|
|
func (p *podSelectorCheck) Name() string {
|
|
return "node-name-pod-selector"
|
|
}
|
|
|
|
// Groups returns a list of group names this check should be part of.
|
|
func (p *podSelectorCheck) Groups() []string {
|
|
return []string{"doks"}
|
|
}
|
|
|
|
// Description returns a detailed human-readable description of what this check
|
|
// does.
|
|
func (p *podSelectorCheck) Description() string {
|
|
return "Checks if there are pods which use kubernetes.io/hostname label in the node selector."
|
|
}
|
|
|
|
// Run runs this check on a set of Kubernetes objects. It can return warnings
|
|
// (low-priority problems) and errors (high-priority problems) as well as an
|
|
// error value indicating that the check failed to run.
|
|
func (p *podSelectorCheck) Run(objects *kube.Objects) ([]checks.Diagnostic, error) {
|
|
var diagnostics []checks.Diagnostic
|
|
for _, pod := range objects.Pods.Items {
|
|
nodeSelectorMap := pod.Spec.NodeSelector
|
|
if _, ok := nodeSelectorMap[corev1.LabelHostname]; ok {
|
|
d := checks.Diagnostic{
|
|
Severity: checks.Warning,
|
|
Message: "Avoid node name label for node selector.",
|
|
Kind: checks.Pod,
|
|
Object: &pod.ObjectMeta,
|
|
Owners: pod.ObjectMeta.GetOwnerReferences(),
|
|
}
|
|
diagnostics = append(diagnostics, d)
|
|
}
|
|
}
|
|
return diagnostics, nil
|
|
}
|