Change assertion order in tests.

checks/basic/latest_tag_test.go

@@ -144,9 +144,9 @@ func TestLatestTagWarning(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			w, e, err := latestTagCheck.Run(scenario.arg)
+			assert.NoError(t, err)
 			assert.ElementsMatch(t, scenario.expected, w)
 			assert.Empty(t, e)
-			assert.Nil(t, err)
 		})
 	}
 }

checks/basic/namespace_test.go

@@ -40,9 +40,9 @@ func TestNamespaceWarning(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			w, e, err := namespace.Run(scenario.arg)
+			assert.NoError(t, err)
 			assert.ElementsMatch(t, scenario.expected, w)
 			assert.Empty(t, e)
-			assert.Nil(t, err)
 		})
 	}
 }

checks/doks/node_name_pod_selector_test.go

@@ -47,8 +47,10 @@ func TestNodeNameError(t *testing.T) {
 
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
-			_, e, _ := podSelectorCheck.Run(scenario.arg)
+			w, e, err := podSelectorCheck.Run(scenario.arg)
+			assert.NoError(t, err)
 			assert.ElementsMatch(t, scenario.expected, e)
+			assert.Empty(t, w)
 		})
 	}
 }

checks/security/privileged_containers_test.go

@@ -83,9 +83,9 @@ func TestPrivilegedContainerWarning(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			w, e, err := privilegedContainerCheck.Run(scenario.arg)
+			assert.NoError(t, err)
 			assert.ElementsMatch(t, scenario.expected, w)
 			assert.Empty(t, e)
-			assert.Nil(t, err)
 		})
 	}
 }