Merge pull request #90 from uplol/master
Fix reference to loop variables in doks admission controller checkswwarren/update-k8s-deps v0.2.3
commit
3ab1800043
|
@ -54,7 +54,9 @@ func (w *webhookReplacementCheck) Run(objects *kube.Objects) ([]checks.Diagnosti
|
||||||
var diagnostics []checks.Diagnostic
|
var diagnostics []checks.Diagnostic
|
||||||
|
|
||||||
for _, config := range objects.ValidatingWebhookConfigurations.Items {
|
for _, config := range objects.ValidatingWebhookConfigurations.Items {
|
||||||
|
config := config
|
||||||
for _, wh := range config.Webhooks {
|
for _, wh := range config.Webhooks {
|
||||||
|
wh := wh
|
||||||
if *wh.FailurePolicy == ar.Ignore {
|
if *wh.FailurePolicy == ar.Ignore {
|
||||||
// Webhooks with failurePolicy: Ignore are fine.
|
// Webhooks with failurePolicy: Ignore are fine.
|
||||||
continue
|
continue
|
||||||
|
@ -74,6 +76,7 @@ func (w *webhookReplacementCheck) Run(objects *kube.Objects) ([]checks.Diagnosti
|
||||||
}
|
}
|
||||||
var svcNamespace *v1.Namespace
|
var svcNamespace *v1.Namespace
|
||||||
for _, ns := range objects.Namespaces.Items {
|
for _, ns := range objects.Namespaces.Items {
|
||||||
|
ns := ns
|
||||||
if ns.Name == wh.ClientConfig.Service.Namespace {
|
if ns.Name == wh.ClientConfig.Service.Namespace {
|
||||||
svcNamespace = &ns
|
svcNamespace = &ns
|
||||||
}
|
}
|
||||||
|
@ -103,7 +106,9 @@ func (w *webhookReplacementCheck) Run(objects *kube.Objects) ([]checks.Diagnosti
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, config := range objects.MutatingWebhookConfigurations.Items {
|
for _, config := range objects.MutatingWebhookConfigurations.Items {
|
||||||
|
config := config
|
||||||
for _, wh := range config.Webhooks {
|
for _, wh := range config.Webhooks {
|
||||||
|
wh := wh
|
||||||
if *wh.FailurePolicy == ar.Ignore {
|
if *wh.FailurePolicy == ar.Ignore {
|
||||||
// Webhooks with failurePolicy: Ignore are fine.
|
// Webhooks with failurePolicy: Ignore are fine.
|
||||||
continue
|
continue
|
||||||
|
@ -123,6 +128,7 @@ func (w *webhookReplacementCheck) Run(objects *kube.Objects) ([]checks.Diagnosti
|
||||||
}
|
}
|
||||||
var svcNamespace *v1.Namespace
|
var svcNamespace *v1.Namespace
|
||||||
for _, ns := range objects.Namespaces.Items {
|
for _, ns := range objects.Namespaces.Items {
|
||||||
|
ns := ns
|
||||||
if ns.Name == wh.ClientConfig.Service.Namespace {
|
if ns.Name == wh.ClientConfig.Service.Namespace {
|
||||||
svcNamespace = &ns
|
svcNamespace = &ns
|
||||||
}
|
}
|
||||||
|
|
|
@ -48,7 +48,9 @@ func (w *webhookTimeoutCheck) Run(objects *kube.Objects) ([]checks.Diagnostic, e
|
||||||
var diagnostics []checks.Diagnostic
|
var diagnostics []checks.Diagnostic
|
||||||
|
|
||||||
for _, config := range objects.ValidatingWebhookConfigurations.Items {
|
for _, config := range objects.ValidatingWebhookConfigurations.Items {
|
||||||
|
config := config
|
||||||
for _, wh := range config.Webhooks {
|
for _, wh := range config.Webhooks {
|
||||||
|
wh := wh
|
||||||
if wh.TimeoutSeconds == nil {
|
if wh.TimeoutSeconds == nil {
|
||||||
// TimeoutSeconds value should be set to a non-nil value (greater than or equal to 1 and less than 30).
|
// TimeoutSeconds value should be set to a non-nil value (greater than or equal to 1 and less than 30).
|
||||||
// If the TimeoutSeconds value is set to nil and the cluster version is 1.13.*, users are
|
// If the TimeoutSeconds value is set to nil and the cluster version is 1.13.*, users are
|
||||||
|
@ -70,7 +72,9 @@ func (w *webhookTimeoutCheck) Run(objects *kube.Objects) ([]checks.Diagnostic, e
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, config := range objects.MutatingWebhookConfigurations.Items {
|
for _, config := range objects.MutatingWebhookConfigurations.Items {
|
||||||
|
config := config
|
||||||
for _, wh := range config.Webhooks {
|
for _, wh := range config.Webhooks {
|
||||||
|
wh := wh
|
||||||
if wh.TimeoutSeconds == nil {
|
if wh.TimeoutSeconds == nil {
|
||||||
// TimeoutSeconds value should be set to a non-nil value (greater than or equal to 1 and less than 30).
|
// TimeoutSeconds value should be set to a non-nil value (greater than or equal to 1 and less than 30).
|
||||||
// If the TimeoutSeconds value is set to nil and the cluster version is 1.13.*, users are
|
// If the TimeoutSeconds value is set to nil and the cluster version is 1.13.*, users are
|
||||||
|
|
Loading…
Reference in New Issue