From c143c0b0830189e341cab58ac88d53f775e20754 Mon Sep 17 00:00:00 2001
From: WalcoFPV <walcofpv@gmail.com>
Date: Wed, 8 Jul 2020 11:35:24 +0200
Subject: [PATCH] Fix HSV tab in LED tab (Android App)

Fix code smells


Fix code smells
---
 src/js/tabs/led_strip.js | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/src/js/tabs/led_strip.js b/src/js/tabs/led_strip.js
index 95b3dd45..5bc14c05 100644
--- a/src/js/tabs/led_strip.js
+++ b/src/js/tabs/led_strip.js
@@ -227,6 +227,8 @@ TABS.led_strip.initialize = function (callback, scrollPosition) {
             updateColors(ip.eq(i).val(), i);
         }
 
+        const colorDefineSliders = $('.colorDefineSliders');
+
         // Color Buttons
         $('.colors').on('click', 'button', function(e) {
             var that = this;
@@ -266,15 +268,26 @@ TABS.led_strip.initialize = function (callback, scrollPosition) {
         });
 
         $('.colors').on('dblclick', 'button', function() {
-            $('.colorDefineSliders').css('left', $(this).position().left - $('.colorDefineSliders').width() / 2 + $(this).width());
-            $('.colorDefineSliders').css('top', $(this).position().top + 26);
-            $('.colorDefineSliders').show();
+            const position = $(this).position();
+            const colorDefineSlidersWidth = colorDefineSliders.width();
+            const width = $(this).width();
+            const calc = $(this).offset().left + colorDefineSlidersWidth / 2 + width + 14;
+            if (calc > $(window).width()) {
+                colorDefineSliders.css('left', 'auto');
+                colorDefineSliders.css('right', 0);
+            } else {
+                colorDefineSliders.css('left', position.left - colorDefineSlidersWidth / 2 + width);
+                colorDefineSliders.css('right', 'auto');
+            }
+            colorDefineSliders.css('top', position.top + 26);
+            colorDefineSliders.show();
         });
 
         $('.colors').children().on({
             mouseleave: function () {
-                if (!$('.colorDefineSliders').is(":hover"))
-                    $('.colorDefineSliders').hide();
+                if (!colorDefineSliders.is(":hover")) {
+                    colorDefineSliders.hide();
+                }
             }
         });
 
@@ -585,7 +598,7 @@ TABS.led_strip.initialize = function (callback, scrollPosition) {
 
         });
 
-        $('.colorDefineSliders').hide();
+        colorDefineSliders.hide();
 
         applyFunctionToSelectedLeds();
         drawColorBoxesInColorLedPoints();