Auto merged - #2553 at Mon, 16 Aug 2021 15:17:11 GMT

Fix Expert Mode Switch
10.8-maintenance
J Blackman 2021-08-17 01:17:11 +10:00 committed by GitHub
commit bfa9a38fef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View File

@ -501,12 +501,12 @@ function startProcess() {
}); });
ConfigStorage.get('permanentExpertMode', function (result) { ConfigStorage.get('permanentExpertMode', function (result) {
const experModeCheckbox = 'input[name="expertModeCheckbox"]'; const expertModeCheckbox = 'input[name="expertModeCheckbox"]';
if (result.permanentExpertMode) { if (result.permanentExpertMode) {
$(experModeCheckbox).prop('checked', true); $(expertModeCheckbox).prop('checked', true);
} }
$(experModeCheckbox).change(function () { $(expertModeCheckbox).change(function () {
const checked = $(this).is(':checked'); const checked = $(this).is(':checked');
checkSetupAnalytics(function (analyticsService) { checkSetupAnalytics(function (analyticsService) {
analyticsService.setDimension(analyticsService.DIMENSIONS.CONFIGURATOR_EXPERT_MODE, checked ? 'On' : 'Off'); analyticsService.setDimension(analyticsService.DIMENSIONS.CONFIGURATOR_EXPERT_MODE, checked ? 'On' : 'Off');

View File

@ -376,7 +376,7 @@ firmware_flasher.initialize = function (callback) {
function showOrHideBuildTypeSelect() { function showOrHideBuildTypeSelect() {
const expertModeChecked = $(this).is(':checked'); const expertModeChecked = $(this).is(':checked');
globalExpertMode_e.prop('checked', expertModeChecked); globalExpertMode_e.prop('checked', expertModeChecked).trigger('change');
if (expertModeChecked) { if (expertModeChecked) {
buildTypesToShow = buildTypes.concat(ciBuildsTypes); buildTypesToShow = buildTypes.concat(ciBuildsTypes);
buildBuildTypeOptionsList(); buildBuildTypeOptionsList();