From 67eccc43e42bd9eea16135a31cd3cdf186b8d40c Mon Sep 17 00:00:00 2001
From: KiteAnton <anton.stalheim@gmail.com>
Date: Tue, 2 Aug 2016 21:19:37 +0200
Subject: [PATCH 1/3] Additional localization cleanup

---
 _locales/en/messages.json | 3 +++
 tabs/onboard_logging.html | 3 +--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index a50cd00e..fc261625 100755
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -1798,6 +1798,9 @@
     },
       "onboardLoggingEraseInProgress": {
     	"message": "Erase in progress, please wait..."  
+    },
+      "onboardLoggingOnboardSDCard": {
+    	"message": "Onboard SD card"
     }
     
     
diff --git a/tabs/onboard_logging.html b/tabs/onboard_logging.html
index af7be6ad..2a70b0b5 100644
--- a/tabs/onboard_logging.html
+++ b/tabs/onboard_logging.html
@@ -108,8 +108,7 @@
             <div class="require-sdcard-supported">
                 <div class="gui_box grey">
                     <div class="gui_box_titlebar" align="left">
-                        <div class="spacer_box_title">
-                            Onboard SD card
+                        <div class="spacer_box_title" i18n="onboardLoggingOnboardSDCard">
                         </div>
                     </div>
                     <div class="spacer_box">

From 24e06f56f074b1052f8230c7db503e930ed44dbb Mon Sep 17 00:00:00 2001
From: KiteAnton <anton.stalheim@gmail.com>
Date: Tue, 2 Aug 2016 22:26:50 +0200
Subject: [PATCH 2/3] Modified blackbox rate selection

---
 tabs/onboard_logging.js | 51 +++++++++++++++++++----------------------
 1 file changed, 23 insertions(+), 28 deletions(-)

diff --git a/tabs/onboard_logging.js b/tabs/onboard_logging.js
index efa05b28..0b953c12 100644
--- a/tabs/onboard_logging.js
+++ b/tabs/onboard_logging.js
@@ -29,7 +29,9 @@ TABS.onboard_logging.initialize = function (callback) {
                 MSP.send_message(MSP_codes.MSP_DATAFLASH_SUMMARY, false, false, function() {
                     if (semver.gte(CONFIG.flightControllerVersion, "1.11.0")) {
                         MSP.send_message(MSP_codes.MSP_SDCARD_SUMMARY, false, false, function() {
-                            MSP.send_message(MSP_codes.MSP_BLACKBOX_CONFIG, false, false, load_html);
+                            MSP.send_message(MSP_codes.MSP_BLACKBOX_CONFIG, false, false, function() { 
+                            	MSP.send_message(MSP_codes.MSP_ADVANCED_CONFIG, false, false, load_html);
+                            });
                         });
                     } else {
                         load_html();
@@ -162,45 +164,38 @@ TABS.onboard_logging.initialize = function (callback) {
     }
     
     function populateLoggingRates() {
-        var
-            userRateGCD = gcd(BLACKBOX.blackboxRateNum, BLACKBOX.blackboxRateDenom),
-            userRate = {num: BLACKBOX.blackboxRateNum / userRateGCD, denom: BLACKBOX.blackboxRateDenom / userRateGCD};
         
         // Offer a reasonable choice of logging rates (if people want weird steps they can use CLI)
         var 
             loggingRates = [
-                 {num: 1, denom: 32},
-                 {num: 1, denom: 16},
-                 {num: 1, denom: 8},
-                 {num: 1, denom: 5},
-                 {num: 1, denom: 4},
-                 {num: 1, denom: 3},
-                 {num: 1, denom: 2},
-                 {num: 2, denom: 3},
-                 {num: 3, denom: 4},
-                 {num: 4, denom: 5},
-                 {num: 7, denom: 8},
                  {num: 1, denom: 1},
+                 {num: 1, denom: 2},
+                 {num: 1, denom: 3},
+                 {num: 1, denom: 4},
+                 {num: 1, denom: 5},
+                 {num: 1, denom: 6},
+                 {num: 1, denom: 7},
+                 {num: 1, denom: 8},
+                 {num: 1, denom: 16},
+                 {num: 1, denom: 32},
             ],
             loggingRatesSelect = $(".blackboxRate select");
         
-        var
-            addedCurrentValue = false;
-        
+        var addedCurrentValue = false;
+        var pidRate = 8000 / PID_ADVANCED_CONFIG.gyro_sync_denom / PID_ADVANCED_CONFIG.pid_process_denom; 
         for (var i = 0; i < loggingRates.length; i++) {
-            if (!addedCurrentValue && userRate.num / userRate.denom <= loggingRates[i].num / loggingRates[i].denom) {
-                if (userRate.num / userRate.denom < loggingRates[i].num / loggingRates[i].denom) {
-                    loggingRatesSelect.append('<option value="' + userRate.num + '/' + userRate.denom + '">' 
-                            + userRate.num + '/' + userRate.denom + ' (' + Math.round(userRate.num / userRate.denom * 100) + '%)</option>');
-                }
-                addedCurrentValue = true;
-            }
-            
+        	var loggingRate = Math.round(pidRate / loggingRates[i].denom);
+        	var loggingRateUnit = " Hz";
+        	if (gcd(loggingRate, 1000)==1000) {
+        		loggingRate /= 1000;
+        		loggingRateUnit = " KHz";
+        		
+        	}
             loggingRatesSelect.append('<option value="' + loggingRates[i].num + '/' + loggingRates[i].denom + '">' 
-                + loggingRates[i].num + '/' + loggingRates[i].denom + ' (' + Math.round(loggingRates[i].num / loggingRates[i].denom * 100) + '%)</option>');
+                + loggingRate + loggingRateUnit + ' (' + Math.round(loggingRates[i].num / loggingRates[i].denom * 100) + '%)</option>');
             
         }
-        loggingRatesSelect.val(userRate.num + '/' + userRate.denom);
+        loggingRatesSelect.val(BLACKBOX.blackboxRateNum + '/' + BLACKBOX.blackboxRateDenom);
     }
     
     function formatFilesizeKilobytes(kilobytes) {

From 2ed1db863b283e1d7feb6bff601b1cef2c57da6a Mon Sep 17 00:00:00 2001
From: KiteAnton <anton.stalheim@gmail.com>
Date: Tue, 2 Aug 2016 22:35:48 +0200
Subject: [PATCH 3/3] Changed text for logging rate

---
 _locales/en/messages.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index fc261625..4476f110 100755
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -1788,7 +1788,7 @@
     	"message": "Blackbox logging device"
     },
       "onboardLoggingRateOfLogging": {
-    	"message": "Portion of PID loop iterations to log (logging rate)"  
+    	"message": "Blackbox logging rate"  
     },
       "onboardLoggingSerialLogger": {
     	"message": "Outboard serial logging device"