From a2c2b8280699ed86e0d4a5f2f79929787b59e995 Mon Sep 17 00:00:00 2001
From: mikeller <github@ike.ch>
Date: Sun, 10 Feb 2019 12:17:14 +1300
Subject: [PATCH] Added deprecation warning for dataflash saving.

---
 locales/en/messages.json         | 4 ++++
 src/css/tabs/onboard_logging.css | 2 +-
 src/tabs/onboard_logging.html    | 2 ++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/locales/en/messages.json b/locales/en/messages.json
index 57debdfa..5e5dc5a9 100644
--- a/locales/en/messages.json
+++ b/locales/en/messages.json
@@ -2301,6 +2301,10 @@
     "dataflashFirmwareUpgradeRequired": {
         "message": "Dataflash requires firmware &gt;= 1.8.0."
     },
+    "dataflashSavingDeprecationNote": {
+        "message": "(Deprecated, use '<b>$t(onboardLoggingRebootMscText.message)</b>' below:",
+        "description": "Used to indicate that saving log files through configurator is deprecated if MSC is available. Note: The seemingly unbalanced opening brace is intentional, there is a closing brace in a separate DOM element after the button."
+    },
     "dataflashButtonSaveFile": {
         "message": "Save flash to file..."
     },
diff --git a/src/css/tabs/onboard_logging.css b/src/css/tabs/onboard_logging.css
index 11e5b431..c4dfbfce 100644
--- a/src/css/tabs/onboard_logging.css
+++ b/src/css/tabs/onboard_logging.css
@@ -211,7 +211,7 @@
 }
 
 .tab-onboard_logging.msc-supported .require-msc-supported {
-    display: block;
+    display: unset;
 }
 
 .require-msc-not-ready {
diff --git a/src/tabs/onboard_logging.html b/src/tabs/onboard_logging.html
index ca85163b..16f8c7d3 100644
--- a/src/tabs/onboard_logging.html
+++ b/src/tabs/onboard_logging.html
@@ -97,7 +97,9 @@
                         
                         <div>
                             <a class="regular-button erase-flash" href="#" i18n="dataflashButtonErase"></a>
+                            <span class="require-msc-supported" i18n="dataflashSavingDeprecationNote"></span>
                             <a class="regular-button save-flash" href="#" i18n="dataflashButtonSaveFile"></a>
+                            <span class="require-msc-supported">)</span>
                         </div>
                     </div>