From 4fcc9b3c1a032350b0faca25f2fdd9b082dcc1be Mon Sep 17 00:00:00 2001
From: Dan Nixon <dan@dan-nixon.com>
Date: Tue, 22 Aug 2017 18:22:13 +0100
Subject: [PATCH] Add tooltips to section headers in OSD tab

---
 _locales/en/messages.json | 22 ++++++++++++++++++++++
 tabs/osd.html             | 16 +++++++---------
 tabs/osd.js               |  8 ++++++++
 3 files changed, 37 insertions(+), 9 deletions(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 1a49b600..6f76a410 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -2593,6 +2593,28 @@
         "message": "Warns when flip over after crash mode is activated"
     },
 
+    "osdSectionHelpElements": {
+        "message": "Enable or disable OSD elements."
+    },
+    "osdSectionHelpVideoMode": {
+        "message": "Set the expected video mode of the camera (typically this can be left on AUTO, if you have difficulties then set this to match the camera output)."
+    },
+    "osdSectionHelpUnits": {
+        "message": "Sets the unit system used for numeric readouts."
+    },
+    "osdSectionHelpTimers": {
+        "message": "Configure flight timers."
+    },
+    "osdSectionHelpAlarms": {
+        "message": "Set the thresholds used for OSD elements with alarm states."
+    },
+    "osdSectionHelpStats": {
+        "message": "Set the values dispalyed on the post flight statistics screen."
+    },
+    "osdSectionHelpWarnings": {
+        "message": "Enable or disable warnings that are shown on the WARNINGS element."
+    },
+
     "mainHelpArmed": {
         "message": "Motor Arming"
     },
diff --git a/tabs/osd.html b/tabs/osd.html
index e277b639..bf576a4d 100755
--- a/tabs/osd.html
+++ b/tabs/osd.html
@@ -17,7 +17,7 @@
                 <div class="cf_column third_left elements requires-osd-feature">
                     <div class="spacer_right">
                         <div class="gui_box grey">
-                            <div class="gui_box_titlebar" style="margin-bottom: 0px;">
+                            <div class="gui_box_titlebar cf_tip" style="margin-bottom: 0px;">
                                 <div class="spacer_box_title">
                                     <span i18n="osdSetupElementsTitle" />
                                     <span class="switch-all-elements">
@@ -48,8 +48,8 @@
                         </div>
                     </div>
                     <div class="cf_column third_right" style="width: calc(100% - 377px);">
-                        <div class="gui_box grey requires-max7456">
-                            <div class="gui_box_titlebar">
+                        <div class="gui_box videomode-container grey requires-max7456">
+                            <div class="gui_box_titlebar cf_tip">
                                 <div class="spacer_box_title" i18n="osdSetupVideoFormatTitle" />
                             </div>
                             <div class="spacer_box">
@@ -57,7 +57,7 @@
                             </div>
                         </div>
                         <div class="gui_box grey units-container requires-osd-feature" style="display:none;">
-                            <div class="gui_box_titlebar">
+                            <div class="gui_box_titlebar cf_tip">
                                 <div class="spacer_box_title" i18n="osdSetupUnitsTitle" />
                             </div>
                             <div class="spacer_box">
@@ -65,8 +65,7 @@
                             </div>
                         </div>
                         <div class="gui_box grey timers-container requires-osd-feature" style="display:none;">
-                            <div class="gui_box_titlebar"
-                                 style="margin-bottom: 0px;">
+                            <div class="gui_box_titlebar cf_tip" style="margin-bottom: 0px;">
                                 <div class="spacer_box_title" i18n="osdSetupTimersTitle" />
                             </div>
                             <div class="spacer_box">
@@ -74,7 +73,7 @@
                             </div>
                         </div>
                         <div class="gui_box grey alarms-container requires-osd-feature" style="display:none;">
-                            <div class="gui_box_titlebar">
+                            <div class="gui_box_titlebar cf_tip">
                                 <div class="spacer_box_title" i18n="osdSetupAlarmsTitle" />
                             </div>
                             <div class="spacer_box">
@@ -82,8 +81,7 @@
                             </div>
                         </div>
                         <div class="gui_box grey warnings-container requires-osd-feature" style="display:none;">
-                            <div class="gui_box_titlebar"
-                                 style="margin-bottom: 0px;">
+                            <div class="gui_box_titlebar cf_tip" style="margin-bottom: 0px;">
                                 <div class="spacer_box_title">
                                   <div class="spacer_box_title" i18n="osdSetupWarningsTitle" />
                                 </div>
diff --git a/tabs/osd.js b/tabs/osd.js
index e7d867c7..e8bdee23 100755
--- a/tabs/osd.js
+++ b/tabs/osd.js
@@ -1156,6 +1156,14 @@ TABS.osd.initialize = function (callback) {
             content: $('#fontmanagercontent')
         });
 
+        $('.elements-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpElements'));
+        $('.videomode-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpVideoMode'));
+        $('.units-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpUnits'));
+        $('.timers-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpTimers'));
+        $('.alarms-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpAlarms'));
+        $('.stats-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpStats'));
+        $('.warnings-container div.cf_tip').attr('title', chrome.i18n.getMessage('osdSectionHelpWarnings'));
+
         // 2 way binding... sorta
         function updateOsdView() {
           // ask for the OSD config data