sundowndev
/
betaflight-configurator
mirror of https://github.com/sundowndev/betaflight-configurator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2250 from McGiverGim/inno_setup 

Delete old installation of Configurator before installing
10.8-maintenance
Michael Keller 2020-10-24 21:02:22 +13:00 committed by GitHub
parent 92ea872648 610071badb
commit 456d2dd6a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 48 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
assets/windows/installer.iss
View File

@ -92,44 +92,76 @@ WizardSmallImageFile=bf_installer_small.bmp
WizardStyle=modern WizardStyle=modern
[Code] [Code]
function GetOldNsisUninstallerPath(): String;
var
RegKey: String;
begin
Result := '';
// Look into the different registry entries: win32, win64 and without user rights
if not RegQueryStringValue(HKLM, 'SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Betaflight Configurator', 'UninstallString', Result) then
begin
if not RegQueryStringValue(HKLM, 'SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\Betaflight Configurator', 'UninstallString', Result) then
begin
RegQueryStringValue(HKCU, 'SOFTWARE\Betaflight\Betaflight Configurator', 'UninstallString', Result)
end;
end;
end;
function GetQuietUninstallerPath(): String;
var
RegKey: String;
begin
Result := '';
RegKey := Format('%s\%s_is1', ['Software\Microsoft\Windows\CurrentVersion\Uninstall', '{#emit SetupSetting("AppId")}']);
if not RegQueryStringValue(HKEY_LOCAL_MACHINE, RegKey, 'QuietUninstallString', Result) then
begin
RegQueryStringValue(HKEY_CURRENT_USER, RegKey, 'QuietUninstallString', Result);
end;
end;
function InitializeSetup(): Boolean; function InitializeSetup(): Boolean;
var var
ResultCode: Integer; ResultCode: Integer;
ResultStr: String;
ParameterStr : String; ParameterStr : String;
UninstPath : String;
begin begin
Result := True; Result := True;
// Check if the application is already installed by the old NSIS installer, and uninstall it // Check if the application is already installed by the old NSIS installer, and uninstall it
// Look into the different registry entries: win32, win64 and without user rights UninstPath := GetOldNsisUninstallerPath();
if not RegQueryStringValue(HKLM, 'SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Betaflight Configurator', 'UninstallString', ResultStr) then
begin
if not RegQueryStringValue(HKLM, 'SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\Betaflight Configurator', 'UninstallString', ResultStr) then
begin
RegQueryStringValue(HKCU, 'SOFTWARE\Betaflight\Betaflight Configurator', 'UninstallString', ResultStr)
end;
end;
// Found, start uninstall // Found, start uninstall
if ResultStr <> '' then if UninstPath <> '' then
begin begin
ResultStr:=RemoveQuotes(ResultStr); UninstPath := RemoveQuotes(UninstPath);
// Add this parameter to not return until uninstall finished. The drawback is that the uninstaller file is not deleted // Add this parameter to not return until uninstall finished. The drawback is that the uninstaller file is not deleted
ParameterStr := '_?=' + ExtractFilePath(ResultStr); ParameterStr := '_?=' + ExtractFilePath(UninstPath);
if Exec(ResultStr, ParameterStr, '', SW_SHOW, ewWaitUntilTerminated, ResultCode) then if Exec(UninstPath, ParameterStr, '', SW_SHOW, ewWaitUntilTerminated, ResultCode) then
begin begin
// Delete the unistaller file and empty folders. Not deleting the files. // Delete the unistaller file and empty folders. Not deleting the files.
DeleteFile(ResultStr); DeleteFile(UninstPath);
DelTree(ExtractFilePath(ResultStr), True, False, True); DelTree(ExtractFilePath(UninstPath), True, False, True);
end end
else begin else begin
Result := False; Result := False;
MsgBox('Error uninstalling old Configurator ' + SysErrorMessage(ResultCode) + '.', mbError, MB_OK); MsgBox('Error uninstalling old Configurator ' + SysErrorMessage(ResultCode) + '.', mbError, MB_OK);
end; end;
end; end
else begin
// Search for new Inno Setup installations
UninstPath := GetQuietUninstallerPath();
if UninstPath <> '' then
begin
if not Exec('>', UninstPath, '', SW_SHOW, ewWaitUntilTerminated, ResultCode) then
begin
Result := False;
MsgBox('Error uninstalling Configurator ' + SysErrorMessage(ResultCode) + '.', mbError, MB_OK);
end;
end;
end;
end; end;