Merge pull request #2697 from Asizon/motor_idle_change

Dshot idle fix for versions < 4.3
10.8-maintenance
Ivan Efimov 2021-12-19 21:31:09 -06:00 committed by GitHub
commit 12810e867f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

View File

@ -1298,7 +1298,7 @@
"message": "Motor Idle ( %, static)" "message": "Motor Idle ( %, static)"
}, },
"configurationDigitalIdlePercentDisabled": { "configurationDigitalIdlePercentDisabled": {
"message": "Motor Idle is disabled. Dynamic Idle is active at {{dynamicIdle}} rpm. See the PID tuning tab." "message": "Dynamic Idle is active at {{dynamicIdle}} rpm. See the PID tuning tab."
}, },
"configurationDigitalIdlePercentHelp": { "configurationDigitalIdlePercentHelp": {
"message": "The 'Motor Idle (static)' value is the percent of maximum throttle that is sent to the ESCs when the throttle at minimum stick position and the craft is armed. <br><br>Increase it to gain more idle speed and avoid desyncs. Too high and the craft feels floaty. Too low and the motors can desync or be slow to start up.<br><br>In 4.3, when Dynamic Idle is active, the static idle value is disregarded, because the idle value is continually adjusted to maintain the configured minimum rpm on the slowest motor." "message": "The 'Motor Idle (static)' value is the percent of maximum throttle that is sent to the ESCs when the throttle at minimum stick position and the craft is armed. <br><br>Increase it to gain more idle speed and avoid desyncs. Too high and the craft feels floaty. Too low and the motors can desync or be slow to start up.<br><br>In 4.3, when Dynamic Idle is active, the static idle value is disregarded, because the idle value is continually adjusted to maintain the configured minimum rpm on the slowest motor."

View File

@ -737,7 +737,9 @@ TABS.motors.initialize = function (callback) {
$('div.digitalIdlePercent').toggle(protocolConfigured && digitalProtocol); $('div.digitalIdlePercent').toggle(protocolConfigured && digitalProtocol);
$('input[name="digitalIdlePercent"]').prop('disabled', protocolConfigured && digitalProtocol && FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry); if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) {
$('input[name="digitalIdlePercent"]').prop('disabled', protocolConfigured && digitalProtocol && FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry);
}
if (FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry) { if (FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry) {
const dynamicIdle = FC.ADVANCED_TUNING.idleMinRpm * 100; const dynamicIdle = FC.ADVANCED_TUNING.idleMinRpm * 100;