If the user supplies an invalid session (as in not on the session
list), it will cause a backtrace, because the setup method from
Msf::PostMixin isn't actually called.
We have thought about implementing this in a new OptSession instead.
But you can't use or even pass framework to option_container.rb, so
this is NOT possible.
The original PR was #3956.
MSP-11672
Pass `'DeferModuleLoads' => false` to `Msf::Simple::Framework.create` so
that `framework.modules.init_module_paths` is only called once (directly
in `Msf::Ui::Console::Driver#initialize`) instead of twice (in
`Msf::Simple::Framework.create` and `Msf::Ui::Console::Driver#initialize).
MSP-11672
Calling init_module_paths takes 6 seconds on my machine even when there are no
files to that are changed just because it takes that long to walk the
directories and gather the mtime for each file. Therefore, calling it
more than once should be avoided. Also, there is no reason to call it
twice as to add paths later, `modules.add_module_paths` should be used.
commit 7f659547b3b5d8de34a1e4b136b5e899ae7878da
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 1 07:54:53 2014 -0600
Add a pointer to true and correct docs
See #4000. Seems kind of pointless to ship all these bytes when we host
everything on GitHub and provide tools to generate docs yourself.
commit 01668c8529454ffb0438aadef62eafb5045503ce
Author: Tod Beardsley <todb@metasploit.com>
Date: Mon Dec 1 07:39:11 2014 -0600
Remove old documentation
The last significant commit in this directory was a844b5c3 , which
touched a sample browser module. Before that, changes were either
ranging across the codebase, or surgical removal of out of date
documentation.
This all is looking to me like fairly useless historical artifacts.
See #4000 for more discussion.