fd20eba35e
Expanding the title and desc for external_ip
...
Also allowing the capitalization on "via" to be small.
2013-03-20 14:42:12 -05:00
45db43d2b3
Merge branch 'msftidy/no-twitter-handles' of github.com:todb-r7/metasploit-framework into todb-r7-msftidy/no-twitter-handles
2013-02-04 14:21:40 -06:00
e8def29b4f
Dropping all twitter handles
...
Also adds "pbot" as an accepted lowercase word. This will come up pretty
routinley for functions and stuff.
2013-02-01 16:33:52 -06:00
7b6d1f4fdd
Actually test alternate rubies.
2013-02-01 13:36:15 -06:00
bf013ba65f
Add more words to ignore
2013-01-10 01:54:19 -06:00
acdce4c876
Correct unicode probs
2013-01-04 14:09:37 -06:00
3dc051c296
Remove return
2012-12-14 11:07:41 -06:00
4011c8dba7
Ignore refs commented out
2012-12-14 10:17:10 -06:00
3297db7bf7
Add function check_ref_identifiers
2012-12-13 17:13:53 -06:00
ab26995910
Add more words to ignore
2012-12-13 13:21:34 -06:00
9a2cb7eddf
Improve title casing check
...
Sometimes the first letter of a word shouldn't be capitalized.
If you do, it may actually be technically incorrect. For example:
a function name, a filename, or even a software name like freeFTPd.
We should ignore scenarios like those.
2012-12-13 13:07:23 -06:00
d90d41d706
Allow version or build numbers
2012-12-13 12:47:36 -06:00
438c18472e
damn it, typo
2012-12-13 12:44:15 -06:00
d8b78868c9
Change case checking code
2012-12-13 12:43:12 -06:00
cdb47bfcfc
Forgot to uncomment back
2012-12-13 12:31:03 -06:00
6f747f16a0
Add another word to ignore
2012-12-13 12:26:32 -06:00
0c84cd0d01
Ignore function names
2012-12-13 12:22:52 -06:00
a049327f21
Ignore certain words
2012-12-13 12:21:22 -06:00
051fe4ddd4
Make exceptions for check_title_format
...
It's not always possible or technically correct to uppercase every
word. For example, sometimes a module may contain a filename or
function name. We should allow these conditions to pass.
2012-12-13 12:11:27 -06:00
014269cd25
Small changes
2012-12-12 15:47:04 -06:00
ee1aaac61f
Look for SVN keywords that no longer use.
2012-12-12 14:27:08 -06:00
86f41c4e6a
Forgot to remove some code
2012-12-12 11:57:28 -06:00
37efe53ac8
I hope this works better
2012-12-12 11:41:36 -06:00
a8084d6412
Add badchars check for module title and author names
2012-12-11 16:17:29 -06:00
bd0352de19
Delete comment
2012-10-29 08:33:01 -05:00
ac90d21725
Msftidy checks for file loads
2012-10-29 08:27:22 -05:00
a11d16ea30
More strict on check_disclosure_date
2012-10-14 19:06:36 -05:00
2b9c04318f
No more check_executable, check extname instead.
...
When File.executable?() is used, it checks if the file is an
executable AND that exe permission is set. Well, we don't really
have to set the permission we can still load/use the module. So
really, all we care is the module must be a ".rb" to make sure
it loads at startup. So that's what we need to check.
2012-10-12 14:37:42 -05:00
2bbbbee381
Make the check_executable warning easier to understand.
2012-10-12 09:33:18 -05:00
dc71771dda
Change some texts
...
Changes include:
* Make invalid ranking an error, because it may affect module
search in msfconsole, or the metasploit site.
* Make invalid disclosure format an error, same concern as above.
* Plus other changes
2012-10-12 09:11:34 -05:00
a5cdf5df90
Fix check_executable
2012-10-12 03:16:50 -05:00
b89c4d1b7c
Rank checking should only run against exploit modules
2012-10-12 03:01:48 -05:00
82189d9f8c
Make msftidy's code more manageable, and more helpful output
2012-10-12 02:55:16 -05:00
25475ffc93
Msftidy fixes.
...
Whitespace on ie_execcommand_uaf, and skipping a known-weird caps check
on a particular software name.
2012-09-18 11:25:00 -05:00
90f3e755f5
Commenting out poor naming style checks
...
Too noisy when run against all the exploits -- it's a good idea but it's
too falsey at the moment to be useful.
2012-03-15 17:00:44 -05:00
9144c33345
MSFTidy check for capitalization in modules
...
And also fixes up a dozen or so failing modules.
2012-03-15 16:38:12 -05:00
28dbaee5ab
Do a strip() before regex check
2012-02-21 11:46:52 -06:00
1d71aec916
Fix DisclosureDate regex, and avoid checking Rank naming style
2012-02-21 01:04:05 -06:00
ce356402d0
Avoid checking var naming style if it's a JavaScript variable
2012-02-18 17:58:36 -06:00
ea5594316f
Add feature to check function/variable naming style
2012-02-18 17:29:14 -06:00
4e32bfce22
Add a check for poorly designed arg list
2012-02-13 21:03:13 -06:00
2d35cf4b66
"stack overflow" in exploits most likely means "stack bof". In aux modules, it's "stack exhaustion"
2012-02-05 17:48:05 -06:00
caee1bba28
Only flag bad term 'stack overflow' if it's an exploit module.
2012-02-05 16:07:55 -06:00
4027f6180c
Better disclosure format check
2012-02-05 15:39:36 -06:00
a6d59bd823
special case handler
2012-01-31 20:49:08 -06:00
4d61a12076
add a note so we can alert
2012-01-30 01:52:49 -06:00
7e25f9a6cc
Death to unicode
...
Apologies to the authors whose names I am now intentionally misspelling.
Maybe in another 10 years, we can guarantee that all terminals and
machine parsers are okay with unicode suddenly popping up in strings.
Also adds a check in msftidy for stray unicode.
2012-01-10 14:54:55 -06:00
7de12fbf02
Adds a (slow) check for checking old rubies
...
This is mainly to avoid checking in modules that break Ruby 1.8.
Currently not terribly configurable, and since it's slow to
test ruby syntaces against different ruby versions, it's off
by default. Enable by setting an environment variable of
MSF_CHECK_OLD_RUBIES to any value.
2011-12-12 15:12:01 -06:00
f503bd9488
Fixes #5749 by converting to unix-style linefeeds and forcing jtr modules to read files as binary, and updating msftidy to allow for r+b as a ghetto append.
2011-11-28 17:52:34 -06:00
e598a40aca
Updating msftidy to not care about SVN specific properties.
2011-11-22 18:33:44 -06:00
Tod Beardsley
sinn3r
Jonathan Cran