Commit Graph

94 Commits (ce5be2221522c5fcf72f8b93b272cdd57315fe03)

Author SHA1 Message Date
sinn3r 719db5d2b1 Fix #4119 - SMB lost search ID (sid) in find_first method
This will fix issue #4119. A bug in the find_first method in rex
SMB.

When the SMB client requests a TRANS2_FIND_FIRST2 for retriving
information about what items a directory has, the server returns
a response that contains an SID - a search identifier for the
transaction. If the SMB client wants more data, it must send a
TRANS2_FIND_NEXT2 request with the same SID. And then the server
will continue sending more until it runs out.

The root cause of this bug is that after the TRANS2_FIND_FIRST2
request is sent, our SMB's find_first method forgets the SID at
the end of the loop (out of scope).
2014-11-11 12:35:07 -06:00
HD Moore b872fa0f0d Handle smb_recv corner case with a cache, clean up find_*, cosmetic 2014-06-23 16:14:18 -05:00
Tod Beardsley feaf6c23cf
Merge and Unconflict client.rb, new module splat
The only conflict was the regex option for no encoding, which was added
after @Meatballs1's original PR for rapid7/metasploit-framework#1421

Also fixes the module with the new license splat.

Conflicts:
	lib/rex/proto/smb/client.rb
2013-12-30 16:53:13 -06:00
HD Moore 72dff03426 FixRM #8396 change all lib use of regex to 8-bit pattern 2013-09-12 16:58:49 -05:00
Tab Assassin 785c2eeb95 Retab changes for PR #1421 2013-09-05 16:20:04 -05:00
Tab Assassin a5cf67a9af Merge for retab 2013-09-05 16:19:51 -05:00
Tab Assassin 7e5e0f7fc8 Retab lib 2013-08-30 16:28:33 -05:00
sinn3r add294d999 Fix potential nil in last_filename
Replacing #2060.  It is possible to get a nil in last_filename if
the sub! function doesn't find any 0x00s to replace, so instead
it's best to use sub(), which should at least return the original
filename.  To make sure we don't hit any other unknown conditions
that may result in nil last_filename, it's also convert with to_s
to make sure it's always a string.
2013-07-09 12:50:19 -05:00
James Lee 0a9b00e24c Apparently missed part of mubix's original changes
Used by auxiliary/admin/smb/list_directory
2013-03-07 21:20:46 -06:00
James Lee 867ab2f269 Whitespace 2013-02-18 19:01:03 -06:00
Meatballs 739204b86d Build upon A.Maloteaux's SMB fixes 2013-01-31 20:17:25 +00:00
Meatballs 1e60817ec9 Remember the SMB Changes 2013-01-31 20:07:48 +00:00
Alexandre Maloteaux c0c3dff4e6 Several fixes for smb, mainly win 8 compatibility 2012-11-28 22:49:40 +01:00
Meatballs e1a4ec2fcc Fix to SMB Client when using find_first on a directory with exactly 20 files. 2012-10-17 21:58:20 +01:00
Tod Beardsley b457289e01 Merge remote branch 'webstersprodigy/module-http-ntlmrelay' 2012-08-21 15:28:50 -05:00
HD Moore c25ebabce0 Fix up incompatibility with MaxDataSize (thanks @mubix) 2012-07-23 13:40:41 -05:00
webstersprodigy d56ccc69b9 Forgot to git add client.rb 2012-07-22 20:13:57 -04:00
Rob Fuller 70017511f5 Implement proto/smb/client find_next for find_files
Squashed commit of the following:

commit b5370b24d48a0b79d13cff465ef1fe53738754d0
Author: Rob Fuller <jd.mubix@gmail.com>
Date:   Sat Jul 21 01:52:31 2012 -0400

    add some documentation for smb client

commit 92438f515ef272337ce02b6deebb35f62a50f0a3
Author: Rob Fuller <jd.mubix@gmail.com>
Date:   Fri Jul 20 03:09:27 2012 -0400

    adds find_next to find_files

[Closes #627]
2012-07-21 00:03:19 -06:00
Rob Fuller df7af9df40 Fix an errant bitwise-and used as bool
Squashed commit of the following:

commit 748ab76d71422e5909dc29403fd24ceb025504b5
Author: Rob Fuller <jd.mubix@gmail.com>
Date:   Fri Jul 20 02:50:50 2012 -0400

    fixes dir/file check

[Closes #626]
2012-07-20 16:29:53 -06:00
HD Moore 9d16a1a472 Fix some SMB operations that dont like this value 2012-07-20 16:25:00 -05:00
webstersprodigy f50843e0b7 Adding http_ntlmrelay module 2012-07-09 22:56:24 -04:00
HD Moore d656e3185f Mark all libraries as defaulting to 8-bit strings 2012-06-29 00:18:28 -05:00
James Lee 7c85a2796a Whitespace cleanup 2012-05-24 17:10:26 -06:00
amaloteaux 3e0982a792 enable ntlmv2 by default for smb, mssql and http
git-svn-id: file:///home/svn/framework3/trunk@12227 4d416f70-5f16-0410-b530-b9f4589650da
2011-04-03 21:06:50 +00:00
amaloteaux c5e137d7d3 correct a bug on ntlm signing
git-svn-id: file:///home/svn/framework3/trunk@12211 4d416f70-5f16-0410-b530-b9f4589650da
2011-04-01 20:58:11 +00:00
James Lee b823ea9876 fix undefined method error by using the correct class
git-svn-id: file:///home/svn/framework3/trunk@12169 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-28 18:42:22 +00:00
amaloteaux 19a4a2d88a move some code from lib/rex/proto/smb/client to lib/rex/proto/ntlm/util and add a mini mixin for ntlm
git-svn-id: file:///home/svn/framework3/trunk@12162 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-27 20:14:56 +00:00
amaloteaux a7d2a34fe2 move comment
git-svn-id: file:///home/svn/framework3/trunk@11972 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-16 00:27:44 +00:00
amaloteaux b7a0a305ee allow psexec to success when SPN validation level is required on windows seven / 2008r2 servers
git-svn-id: file:///home/svn/framework3/trunk@11971 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-16 00:12:07 +00:00
amaloteaux b5323c129c when ntlmssp is not used, better to disable signing then raising an error
git-svn-id: file:///home/svn/framework3/trunk@11918 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 21:51:11 +00:00
amaloteaux fea87fb82b enable pass-the-hash when signing is required
git-svn-id: file:///home/svn/framework3/trunk@11917 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 21:13:04 +00:00
amaloteaux 2fa2ca174c use the correct exception
git-svn-id: file:///home/svn/framework3/trunk@11916 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 17:31:53 +00:00
HD Moore 612c2e6796 This commit fixes much of the NTLM crypt code to work properly again, fixing #3918 as well.
git-svn-id: file:///home/svn/framework3/trunk@11914 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 05:04:42 +00:00
HD Moore 046d75533a This patch adds a method for recognizing LM/NTLM hashes, disables signing when no user is specified and the server denies our NTLMSSP logon with an empty user, and cleans up the indents and formatting for some of the new code
git-svn-id: file:///home/svn/framework3/trunk@11912 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 03:35:25 +00:00
HD Moore 315a1cb4f2 Disable signing when we reach this corner case, required to setup null sessions to XP SP2/SP3 (no domain)
git-svn-id: file:///home/svn/framework3/trunk@11910 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 03:08:11 +00:00
amaloteaux b04ac2d446 enable pass-the-hash for ntlmv2 as well, signing is not yet suported
git-svn-id: file:///home/svn/framework3/trunk@11908 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 02:41:50 +00:00
amaloteaux 1f948c1e17 re-enable pass-the-hash for smb client when ntlmv1 or ntlm2_session is used ( ntlmv2 or signing not yet supported but coming soon)
git-svn-id: file:///home/svn/framework3/trunk@11906 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-09 01:56:09 +00:00
amaloteaux 5f6995e8d3 enable ntlmv2 and signing for smb client stack (pth implementation is coming), fixes #11678 and #152
git-svn-id: file:///home/svn/framework3/trunk@11893 4d416f70-5f16-0410-b530-b9f4589650da
2011-03-07 19:57:53 +00:00
Joshua Drake 465fe7c60d nice work troulouliou, shuffling comments only
git-svn-id: file:///home/svn/framework3/trunk@10427 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-21 16:24:18 +00:00
HD Moore 3204b3ad83 Patch for the SMB timestamp parser which allows it to function in GMT+ zones
git-svn-id: file:///home/svn/framework3/trunk@10425 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-21 14:21:38 +00:00
Joshua Drake ff22e5212e revert to backward compatible method of using utc+zone
git-svn-id: file:///home/svn/framework3/trunk@10367 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-18 05:09:47 +00:00
Joshua Drake b22c24289d fix up the simple.client.system_time and underlying stuffs
git-svn-id: file:///home/svn/framework3/trunk@10362 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-18 01:12:44 +00:00
HD Moore 012654947a Store the time zone as well
git-svn-id: file:///home/svn/framework3/trunk@10357 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-17 21:19:04 +00:00
HD Moore 31f5ee512c Store the server time in Ruby object format
git-svn-id: file:///home/svn/framework3/trunk@10354 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-17 21:03:08 +00:00
HD Moore 44a67d0440 Typo fix
git-svn-id: file:///home/svn/framework3/trunk@10315 4d416f70-5f16-0410-b530-b9f4589650da
2010-09-14 18:20:17 +00:00
Joshua Drake 626f7e0c66 add a flag indication not to recv to various smb/client methods
git-svn-id: file:///home/svn/framework3/trunk@10037 4d416f70-5f16-0410-b530-b9f4589650da
2010-08-18 17:20:55 +00:00
HD Moore 6b25b1024e Always try to read the NB header first to get the length
git-svn-id: file:///home/svn/framework3/trunk@9826 4d416f70-5f16-0410-b530-b9f4589650da
2010-07-14 17:07:10 +00:00
HD Moore dfa7fb7d0b Move away from Kernel.select in exchange for IO.select, solves some issues with windows compatibility
git-svn-id: file:///home/svn/framework3/trunk@9330 4d416f70-5f16-0410-b530-b9f4589650da
2010-05-20 20:42:17 +00:00
Joshua Drake 71a2064520 closes #1408 - merge patch from Mike Ryan
git-svn-id: file:///home/svn/framework3/trunk@8963 4d416f70-5f16-0410-b530-b9f4589650da
2010-03-31 02:25:44 +00:00
HD Moore 5dd404abd6 Fix an issue with 1.9.1 compat
git-svn-id: file:///home/svn/framework3/trunk@8818 4d416f70-5f16-0410-b530-b9f4589650da
2010-03-14 16:20:24 +00:00