Metasploit::Framework::Credential and Metasploit::Credential::Core need to be consumable by the login scanners. the easiest way to do this was to create a shared to_credential method on both that return Metasploit::Framework::Credential MSP-9912