test platform selection

added tests around platform selection

lib/msf/core/payload_generator.rb

@@ -71,12 +71,16 @@ module Msf
 
     # @return [Msf::Module::PlatformList] It will be empty if no valid platforms found
     def platform_list
-      begin
+      if platform.blank?
-        list = ::Msf::Module::PlatformList.transform(platform)
-      rescue
         list = Msf::Module::PlatformList.new
+      else
+        begin
+          list = ::Msf::Module::PlatformList.transform(platform)
+        rescue
+          list = Msf::Module::PlatformList.new
+        end
       end
-      return list
+      list
     end
 
     def choose_platform(mod)

spec/lib/msf/core/payload_generator_spec.rb

@@ -123,4 +123,71 @@ describe Msf::PayloadGenerator do
     end
   end
 
+  context 'checking platforms' do
+    let(:payload_module) { framework.payloads.create(payload)}
+
+    context 'when not given a platform' do
+      let(:platform) { '' }
+
+      context '#platform_list' do
+        it 'returns an empty PlatformList' do
+          expect(payload_generator.platform_list.platforms).to be_empty
+        end
+      end
+
+      context '#choose_platform' do
+        it 'chooses the platform list for the module' do
+          expect(payload_generator.choose_platform(payload_module).platforms).to eq [Msf::Module::Platform::Windows]
+        end
+      end
+
+    end
+
+    context 'when given an invalid platform' do
+      let(:platform) { 'foobar' }
+
+      context '#platform_list' do
+        it 'returns an empty PlatformList' do
+          expect(payload_generator.platform_list.platforms).to be_empty
+        end
+      end
+
+      context '#choose_platform' do
+        it 'chooses the platform list for the module' do
+          expect(payload_generator.choose_platform(payload_module).platforms).to eq [Msf::Module::Platform::Windows]
+        end
+      end
+
+    end
+
+    context 'when given a valid platform' do
+
+      context '#platform_list' do
+        it 'returns a PlatformList containing the Platform class' do
+          expect(payload_generator.platform_list.platforms.first).to eq Msf::Module::Platform::Windows
+        end
+      end
+
+      context '#choose_platform' do
+        context 'when the chosen platform matches the module' do
+          it 'returns the PlatformList for the selected platform' do
+            expect(payload_generator.choose_platform(payload_module).platforms).to eq payload_generator.platform_list.platforms
+          end
+        end
+
+        context 'when the chosen platform and module do not match' do
+          let(:platform) { "linux" }
+          it 'returns an empty PlatformList' do
+            expect(payload_generator.choose_platform(payload_module).platforms).to be_empty
+          end
+        end
+      end
+
+    end
+
+  end
+
+
+
+
 end