Support the subject field

documentation/modules/auxiliary/client/mms/send_mms.md

@@ -69,6 +69,10 @@ The password you use to log into the SMTP server.
 
 The FROM field of SMTP. In some cases, it may be used as ```SMTPUSER```.
 
+**MMSSUBJECT**
+
+The MMS subject. Some carriers require this in order to receive the text, such as AT&T.
+
 ## Supported Carrier Gateways
 
 The module supports the following carriers:

lib/msf/core/auxiliary/mms.rb

@@ -17,6 +17,7 @@ module Msf
         [
           OptString.new('SMTPFROM', [false, 'The FROM field for SMTP', '']),
           OptString.new('SMTPADDRESS', [ true, 'The SMTP server to use to send the text messages']),
+          OptString.new('MMSSUBJECT', [false, 'The Email subject', '']),
           OptPort.new('SMTPPORT', [true, 'The SMTP port to use to send the text messages', 25]),
           OptString.new('SMTPUSERNAME', [true, 'The SMTP account to use to send the text messages']),
           OptString.new('SMTPPASSWORD', [true, 'The SMTP password to use to send the text messages']),
@@ -43,22 +44,25 @@ module Msf
     #   mms.send_mms_to_phones(numbers, 'hello world?', '/tmp/test.jpg', 'image/jpeg')
     #
     # @param phone_numbers [<String>Array] An array of numbers of try (of the same carrier)
+    # @param subject [String] MMS subject
     # @param message [String] The text to send.
+    # @param attachment_path [String] Optional
+    # @param ctype [String] Optional
     #
     # @return [void]
-    def send_mms(phone_numbers, message, attachment_path=nil, ctype=nil)
+    def send_mms(phone_numbers, subject, message, attachment_path=nil, ctype=nil)
       smtp = Rex::Proto::Mms::Model::Smtp.new(
         address: datastore['SMTPADDRESS'],
         port: datastore['SMTPPORT'],
         username: datastore['SMTPUSERNAME'],
         password: datastore['SMTPPASSWORD'],
         login_type: datastore['SmtpLoginType'].to_sym,
-        from: datastore['SMTPFROM']
+        from: datastore['SMTPFROM'],
       )
 
       carrier = datastore['MMSCARRIER'].to_sym
       mms = Rex::Proto::Mms::Client.new(carrier: carrier, smtp_server: smtp)
-      mms.send_mms_to_phones(phone_numbers, message, attachment_path, ctype)
+      mms.send_mms_to_phones(phone_numbers, subject, message, attachment_path, ctype)
     end
 
   end

lib/rex/proto/mms/client.rb

@@ -32,12 +32,13 @@ module Rex
         # Sends a media text to multiple recipients.
         #
         # @param phone_numbers [<String>Array] An array of phone numbers.
+        # @param subject [String] MMS subject
         # @param message [String] The message to send.
         # @param attachment_path [String] (Optional) The attachment to include
         # @param ctype [String] (Optional) The content type to use for the attachment
         #
         # @return [void]
-        def send_mms_to_phones(phone_numbers, message, attachment_path=nil, ctype=nil)
+        def send_mms_to_phones(phone_numbers, subject, message, attachment_path=nil, ctype=nil)
           carrier     = Rex::Proto::Mms::Model::GATEWAYS[self.carrier]
           recipients  = phone_numbers.collect { |p| "#{p}@#{carrier}" }
           address     = self.smtp_server.address

lib/rex/proto/mms/model/message.rb

@@ -26,6 +26,10 @@ module Rex
           #   @return [String] The to field in the email
           attr_accessor :to
 
+          # @!attribute subject
+          #   @return [String] The subject of the email
+          attr_accessor :subject
+
           # @!attribute attachment_name
           #   @return [String] The attachment base name extracted from :attachment
           attr_accessor :attachment_name
@@ -88,6 +92,7 @@ module Rex
             mms = "MIME-Version: 1.0\n"
             mms << "From: #{self.from}\n"
             mms << "To: #{self.to}\n"
+            mms << "Subject: #{self.subject}\n"
             mms << "Content-Type: multipart/mixed; boundary=#{body.bound}\n"
             mms << "\n"
             mms << body.to_s.gsub(/\-\-\r\n\r\n\-\-_/, "--\n--_")

modules/auxiliary/client/mms/send_mms.rb

@@ -25,7 +25,7 @@ class MetasploitModule < Msf::Auxiliary
     phone_numbers = datastore['CELLNUMBERS'].split
     print_status("Sending mms message to #{phone_numbers.length} number(s)...")
     begin
-      res = send_mms(phone_numbers, datastore['TEXTMESSAGE'], datastore['MMSFILE'], datastore['MMSFILECTYPE'])
+      res = send_mms(phone_numbers, datastore['MMSSUBJECT'], datastore['TEXTMESSAGE'], datastore['MMSFILE'], datastore['MMSFILECTYPE'])
       print_status("Done.")
     rescue Rex::Proto::Mms::Exception => e
       print_error(e.message)

spec/lib/rex/proto/mms/model/message_spec.rb

@@ -9,6 +9,7 @@ RSpec.describe Rex::Proto::Mms::Model::Message do
   let(:filecontent)  { 'file content' }
   let(:from)         { 'sender@example.com' }
   let(:to)           { 'receiver@example.com' }
+  let(:subject)      { 'subject' }
 
   before(:each) do
     allow(File).to receive(:read).and_return(filecontent)
@@ -18,6 +19,7 @@ RSpec.describe Rex::Proto::Mms::Model::Message do
     described_class.new(
       from: from,
       to: to,
+      subject: subject,
       message: message,
       content_type: content_type,
       attachment_path: attachment
@@ -44,6 +46,10 @@ RSpec.describe Rex::Proto::Mms::Model::Message do
     it 'sets to' do
       expect(subject.to).to eq(to)
     end
+
+    it 'sets subject' do
+      expect(subject.to).to receive(subject)
+    end
   end
 
   describe '#to_s' do