Land #3158, msftidy rank check for aux modules

modules/auxiliary/gather/mantisbt_admin_sqli.rb

@@ -6,7 +6,6 @@
 require 'msf/core'
 
 class Metasploit4 < Msf::Auxiliary
-  Rank = GoodRanking
 
   include Msf::Exploit::Remote::HttpClient
 
@@ -100,5 +99,6 @@ class Metasploit4 < Msf::Auxiliary
       print_good("File saved to: #{path}")
     end
   end
+
 end
 

tools/msftidy.rb

@@ -470,6 +470,11 @@ class Msftidy
       if ln =~ /\[['"]Set-Cookie['"]\]/i
         warn("Do not read Set-Cookie header directly, use res.get_cookies instead: #{ln}", idx)
       end
+
+      # Auxiliary modules do not have a rank attribute
+      if ln =~ /^\s*Rank\s*=\s*/ and @source =~ /<\sMsf::Auxiliary/
+        warn("Auxiliary modules have no 'Rank': #{ln}", idx)
+      end
     }
   end