add more specs

added more specs around telnet specific validations

spec/lib/metasploit/framework/login_scanner/telnet_spec.rb

@@ -11,4 +11,68 @@ describe Metasploit::Framework::LoginScanner::Telnet do
   it { should respond_to :banner_timeout }
   it { should respond_to :telnet_timeout }
 
+  context 'validations' do
+    context 'banner_timeout' do
+      it 'is not valid for a non-number' do
+        login_scanner.banner_timeout = "a"
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:banner_timeout]).to include "is not a number"
+      end
+
+      it 'is not valid for a floating point' do
+        login_scanner.banner_timeout = 5.76
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:banner_timeout]).to include "must be an integer"
+      end
+
+      it 'is not valid for a negative number' do
+        login_scanner.banner_timeout = -8
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:banner_timeout]).to include "must be greater than or equal to 1"
+      end
+
+      it 'is not valid for 0' do
+        login_scanner.banner_timeout = 0
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:banner_timeout]).to include "must be greater than or equal to 1"
+      end
+
+      it 'is valid for a legitimate  number' do
+        login_scanner.port = rand(1000) + 1
+        expect(login_scanner.errors[:banner_timeout]).to be_empty
+      end
+    end
+
+    context 'telnet_timeout' do
+      it 'is not valid for a non-number' do
+        login_scanner.telnet_timeout = "a"
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:telnet_timeout]).to include "is not a number"
+      end
+
+      it 'is not valid for a floating point' do
+        login_scanner.telnet_timeout = 5.76
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:telnet_timeout]).to include "must be an integer"
+      end
+
+      it 'is not valid for a negative number' do
+        login_scanner.telnet_timeout = -8
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:telnet_timeout]).to include "must be greater than or equal to 1"
+      end
+
+      it 'is not valid for 0' do
+        login_scanner.telnet_timeout = 0
+        expect(login_scanner).to_not be_valid
+        expect(login_scanner.errors[:telnet_timeout]).to include "must be greater than or equal to 1"
+      end
+
+      it 'is valid for a legitimate  number' do
+        login_scanner.port = rand(1000) + 1
+        expect(login_scanner.errors[:telnet_timeout]).to be_empty
+      end
+    end
+  end
+
 end