Don't modify argument in place

2015-03-31 10:41:24 -05:00 · 2015-03-31 10:41:24 -05:00 · a1a7faa77a
parent 7e559f7b13
commit a1a7faa77a
1 changed files with 2 additions and 0 deletions
--- a/lib/msf/core/db_manager/exploit_attempt.rb
+++ b/lib/msf/core/db_manager/exploit_attempt.rb
@ -80,6 +80,8 @@ module Msf::DBManager::ExploitAttempt

    # Look up or generate the service as appropriate
    if port and svc.nil?
+      # it is rude to modify arguments in place
+      opts = opts.dup
      opts[:proto] ||= "tcp"
      opts[:service] = report_service(
        workspace: wspace, host: host, port: port, proto: prot