Land #8830, Cleanup auxiliary/scanner/msf/msf_rpc_login

modules/auxiliary/scanner/msf/msf_rpc_login.rb

@@ -3,22 +3,25 @@
 # Current source: https://github.com/rapid7/metasploit-framework
 ##
 
+require 'msf/core/rpc/v10/client'
+
 class MetasploitModule < Msf::Auxiliary
+  include Msf::Exploit::Remote::Tcp
   include Msf::Auxiliary::Report
   include Msf::Auxiliary::AuthBrute
   include Msf::Auxiliary::Scanner
 
-  def initialize
+  def initialize(info = {})
-    super(
+    super(update_info(info,
       'Name'          => 'Metasploit RPC Interface Login Utility',
       'Description'   => %q{
         This module simply attempts to login to a
         Metasploit RPC interface using a specific
         user/pass.
       },
-      'Author'         => [ 'Vlatko Kosturjak <kost[at]linux.hr>' ],
+      'Author'        => [ 'Vlatko Kosturjak <kost[at]linux.hr>' ],
-      'License'        => MSF_LICENSE
+      'License'       => MSF_LICENSE
-    )
+    ))
 
     register_options(
       [
@@ -27,34 +30,21 @@ class MetasploitModule < Msf::Auxiliary
         OptBool.new('BLANK_PASSWORDS', [false, "Try blank passwords for all users", false]),
         OptBool.new('SSL', [ true, "Negotiate SSL for outgoing connections", true])
       ])
+
     register_autofilter_ports([3790])
-
-  end
-
-  @@loaded_msfrpc = false
-  begin
-    require 'msf/core/rpc/v10/client'
-    @@loaded_msfrpc = true
-  rescue LoadError
   end
 
   def run_host(ip)
-
-    unless @@loaded_msfrpc
-      print_error("You don't have 'msgpack', please install that gem manually.")
-      return
-    end
-
     begin
       @rpc = Msf::RPC::Client.new(
-        :host => datastore['RHOST'],
+        :host => rhost,
-        :port => datastore['RPORT'],
+        :port => rport,
-        :ssl  => datastore['SSL']
+        :ssl  => ssl
       )
     rescue ::Interrupt
       raise $!
-    rescue ::Exception => e
+    rescue => e
-      vprint_error("#{datastore['SSL'].to_s} Cannot create RPC client : #{e.to_s}")
+      vprint_error("Cannot create RPC client : #{e}")
       return
     end
 
@@ -90,27 +80,29 @@ class MetasploitModule < Msf::Auxiliary
     create_credential_login(login_data)
   end
 
-  def do_login(user='msf', pass='msf')
+  def do_login(user = 'msf', pass = 'msf')
     vprint_status("Trying username:'#{user}' with password:'#{pass}'")
     begin
       res = @rpc.login(user, pass)
       if res
         print_good("SUCCESSFUL LOGIN. '#{user}' : '#{pass}'")
         report_cred(
-          ip: datastore['RHOST'],
+          ip: rhost,
-          port: datastore['RPORT'],
+          port: rport,
           service_name: 'msf-rpc',
           user: user,
-          password: pass,
+          password: pass
-          proof: res.body
         )
-        @rpc.close
         return :next_user
       end
-    rescue  => e
+    rescue Rex::ConnectionRefused => e
-      vprint_status("#{datastore['SSL'].to_s} - Bad login")
+      print_error("Connection refused : #{e}")
-      @rpc.close
+      return :abort
+    rescue => e
+      vprint_status("#{peer} - Bad login")
       return :skip_pass
     end
+  ensure
+    @rpc.close
   end
 end