infosecn1nja
/
metasploit-framework
mirror of https://github.com/infosecn1nja/metasploit-framework.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Prefer case statement over long if block

GSoC/Meterpreter_Web_Console
William Vu 2019-02-01 14:40:09 -06:00
parent 2640ecb4c4
commit 7b88277c6f
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/auxiliary/scanner/ubiquiti/ubiquiti_discover.rb
View File

@ -58,26 +58,27 @@ class MetasploitModule < Msf::Auxiliary
next next
end end
# name # name
if type == 0x0b case type
when 0x0b
info['name'] = field_data info['name'] = field_data
# MAC # MAC
elsif type == 0x01 when 0x01
info['macs'] << field_data.each_byte.map { |b| b.to_s(16) }.join(':') info['macs'] << field_data.each_byte.map { |b| b.to_s(16) }.join(':')
# MAC and IP # MAC and IP
elsif type == 0x02 when 0x02
info['macs'] << field_data.slice(0,6).each_byte.map { |b| b.to_s(16) }.join(':') info['macs'] << field_data.slice(0,6).each_byte.map { |b| b.to_s(16) }.join(':')
info['ips'] << field_data.slice(6,4).each_byte.map { |b| b.to_i }.join('.') info['ips'] << field_data.slice(6,4).each_byte.map { |b| b.to_i }.join('.')
# long model # long model
elsif type == 0x14 when 0x14
info['model_long'] = field_data info['model_long'] = field_data
# short model # short model
elsif type == 0x0c when 0x0c
info['model_short'] = field_data info['model_short'] = field_data
# firmware version # firmware version
elsif type == 0x03 when 0x03
info['firmware'] = field_data info['firmware'] = field_data
# essid in some situations # essid in some situations
elsif type == 0x0d when 0x0d
info['essid'] = field_data info['essid'] = field_data
else else
vprint_warning("#{shost}:#{sport} skipping unhandled #{length}-byte field type '#{type}': '#{field_data.unpack("H*")}'") vprint_warning("#{shost}:#{sport} skipping unhandled #{length}-byte field type '#{type}': '#{field_data.unpack("H*")}'")