Remove rubocop and msftidy touchpoints
Rubocop replaces the default YAML library which makes development testing difficult. It does not cause problems on Travis, but according to reports, it does cause instability with many individual dev environments. While I would love to have a more solid source of this bug report, right now this was an oral report from @shuckins-r7 (who I tend to believe a lot).bug/bundler_fix
Tod Beardsley
parent
351b687759
commit
47cb906408
58
.rubocop.yml
58
.rubocop.yml
|
|
@ -1,58 +0,0 @@
|
||||||
# This list was created by analyzing the last three months (51 modules)
|
|
||||||
# committed to Metasploit Framework. Many, many older modules will have
|
|
||||||
# offenses, but this should at least provide a baseline for new modules.
|
|
||||||
#
|
|
||||||
# Updates to this file should include a 'Description' parameter for
|
|
||||||
# any explaination needed.
|
|
||||||
|
|
||||||
inherit_from: .rubocop_todo.yml
|
|
||||||
|
|
||||||
Style/ClassLength:
|
|
||||||
Description: 'Most Metasploit modules are quite large. This is ok.'
|
|
||||||
Enabled: true
|
|
||||||
Exclude:
|
|
||||||
- 'modules/**/*'
|
|
||||||
|
|
||||||
Style/Documentation:
|
|
||||||
Enabled: true
|
|
||||||
Description: 'Most Metasploit modules do not have class documentation.'
|
|
||||||
Exclude:
|
|
||||||
- 'modules/**/*'
|
|
||||||
|
|
||||||
Style/Encoding:
|
|
||||||
Enabled: true
|
|
||||||
Description: 'We prefer binary to UTF-8.'
|
|
||||||
EnforcedStyle: 'when_needed'
|
|
||||||
|
|
||||||
Style/LineLength:
|
|
||||||
Description: >-
|
|
||||||
Metasploit modules often pattern match against very
|
|
||||||
long strings when identifying targets.
|
|
||||||
Enabled: true
|
|
||||||
Max: 180
|
|
||||||
|
|
||||||
Style/MethodLength:
|
|
||||||
Enabled: true
|
|
||||||
Description: >-
|
|
||||||
While the style guide suggests 10 lines, exploit definitions
|
|
||||||
often exceed 200 lines.
|
|
||||||
Max: 300
|
|
||||||
|
|
||||||
Style/NumericLiterals:
|
|
||||||
Enabled: false
|
|
||||||
Description: 'This often hurts readability for exploit-ish code.'
|
|
||||||
|
|
||||||
Style/PercentLiteralDelimiters:
|
|
||||||
Enabled: false
|
|
||||||
Description: >-
|
|
||||||
Metasploit devs tend to prefer [] over %w() for
|
|
||||||
nearly all cases, since we often deal with funny
|
|
||||||
looking arrays of nonwords. Consistency here is
|
|
||||||
preferred over element type safety.
|
|
||||||
|
|
||||||
Style/WordArray:
|
|
||||||
Enabled: false
|
|
||||||
Description: >-
|
|
||||||
Metasploit devs have grown comforatble with curly
|
|
||||||
braces over parens for %w. Disabling this check
|
|
||||||
prefers consistency.
|
|
||||||
|
|
@ -1,730 +0,0 @@
|
||||||
# This configuration was generated by `rubocop --auto-gen-config`
|
|
||||||
# on 2014-07-29 16:18:04 -0500 using RuboCop version 0.23.0.
|
|
||||||
# The point is for the user to remove these configuration records
|
|
||||||
# one by one as the offenses are removed from the code base.
|
|
||||||
# Note that changes in the inspected code, or installation of new
|
|
||||||
# versions of RuboCop, may require this file to be generated again.
|
|
||||||
|
|
||||||
# Offense count: 10
|
|
||||||
Lint/AmbiguousOperator:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 8
|
|
||||||
Lint/AmbiguousRegexpLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1395
|
|
||||||
# Configuration parameters: AllowSafeAssignment.
|
|
||||||
Lint/AssignmentInCondition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 105
|
|
||||||
Lint/BlockAlignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 7
|
|
||||||
Lint/ConditionPosition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 119
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Lint/DeprecatedClassMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 5
|
|
||||||
Lint/ElseLayout:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1
|
|
||||||
Lint/EmptyInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 746
|
|
||||||
# Configuration parameters: AlignWith, SupportedStyles.
|
|
||||||
Lint/EndAlignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3
|
|
||||||
Lint/EnsureReturn:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 43
|
|
||||||
Lint/Eval:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 586
|
|
||||||
Lint/HandleExceptions:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 107
|
|
||||||
Lint/LiteralInCondition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 8
|
|
||||||
Lint/LiteralInInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 30
|
|
||||||
Lint/Loop:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 51
|
|
||||||
Lint/ParenthesesAsGroupedExpression:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2
|
|
||||||
Lint/RequireParentheses:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 526
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Lint/RescueException:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 82
|
|
||||||
Lint/ShadowingOuterLocalVariable:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 19
|
|
||||||
Lint/SpaceBeforeFirstArg:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 395
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Lint/StringConversionInInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 83
|
|
||||||
Lint/UnderscorePrefixedVariableName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 18
|
|
||||||
Lint/UnreachableCode:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 950
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Lint/UnusedBlockArgument:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1554
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Lint/UnusedMethodArgument:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 21
|
|
||||||
Lint/UselessAccessModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2236
|
|
||||||
Lint/UselessAssignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1
|
|
||||||
Lint/UselessComparison:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 4
|
|
||||||
Lint/UselessSetterCall:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 131
|
|
||||||
Lint/Void:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 178
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/AccessModifierIndentation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 346
|
|
||||||
Style/AccessorMethodName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 195
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/Alias:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1007
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/AlignArray:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1205
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
|
|
||||||
Style/AlignHash:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2822
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/AlignParameters:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 9507
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/AndOr:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 9
|
|
||||||
Style/AsciiComments:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 193
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/BlockComments:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 841
|
|
||||||
Style/BlockNesting:
|
|
||||||
Max: 8
|
|
||||||
|
|
||||||
# Offense count: 3258
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/Blocks:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2245
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/BracesAroundHashParameters:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 17
|
|
||||||
Style/CaseEquality:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1843
|
|
||||||
# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep.
|
|
||||||
Style/CaseIndentation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 562
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/CharacterLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 80
|
|
||||||
Style/ClassAndModuleCamelCase:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 309
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/ClassAndModuleChildren:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 352
|
|
||||||
# Configuration parameters: CountComments.
|
|
||||||
Style/ClassLength:
|
|
||||||
Max: 38107
|
|
||||||
|
|
||||||
# Offense count: 203
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/ClassMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 311
|
|
||||||
Style/ClassVars:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 364
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: PreferredMethods.
|
|
||||||
Style/CollectionMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 315
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/ColonMethodCall:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 233
|
|
||||||
# Configuration parameters: Keywords.
|
|
||||||
Style/CommentAnnotation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 375
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/CommentIndentation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 450
|
|
||||||
Style/ConstantName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2713
|
|
||||||
Style/CyclomaticComplexity:
|
|
||||||
Max: 259
|
|
||||||
|
|
||||||
# Offense count: 275
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/DefWithParentheses:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 159
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/DeprecatedHashMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1455
|
|
||||||
Style/Documentation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 18
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/DotPosition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 70
|
|
||||||
Style/DoubleNegation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 16
|
|
||||||
Style/EachWithObject:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 490
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: AllowAdjacentOneLineDefs.
|
|
||||||
Style/EmptyLineBetweenDefs:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3753
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/EmptyLines:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 64
|
|
||||||
Style/EmptyLinesAroundAccessModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 8506
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/EmptyLinesAroundBody:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 164
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/EmptyLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 10
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/Encoding:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1
|
|
||||||
Style/EndBlock:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1
|
|
||||||
Style/EndOfLine:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 26
|
|
||||||
Style/EvenOdd:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 44
|
|
||||||
# Configuration parameters: Exclude.
|
|
||||||
Style/FileName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 108
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/For:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 981
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/FormatString:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 243
|
|
||||||
# Configuration parameters: AllowedVariables.
|
|
||||||
Style/GlobalVars:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 727
|
|
||||||
# Configuration parameters: MinBodyLength.
|
|
||||||
Style/GuardClause:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 11295
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/HashSyntax:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2551
|
|
||||||
# Configuration parameters: MaxLineLength.
|
|
||||||
Style/IfUnlessModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 82
|
|
||||||
Style/IfWithSemicolon:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2056
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/IndentArray:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3023
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/IndentHash:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1257
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/IndentationConsistency:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 4705
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/IndentationWidth:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 302
|
|
||||||
Style/Lambda:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 4664
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/LeadingCommentSpace:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3304
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/LineEndConcatenation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 127
|
|
||||||
Style/LineLength:
|
|
||||||
Max: 5614
|
|
||||||
|
|
||||||
# Offense count: 1480
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/MethodCallParentheses:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 28
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/MethodDefParentheses:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 22
|
|
||||||
# Configuration parameters: CountComments.
|
|
||||||
Style/MethodLength:
|
|
||||||
Max: 38090
|
|
||||||
|
|
||||||
# Offense count: 278
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/MethodName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 27
|
|
||||||
Style/MultilineBlockChain:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 93
|
|
||||||
Style/MultilineIfThen:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 19
|
|
||||||
Style/MultilineTernaryOperator:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3497
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/NegatedIf:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 85
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/NegatedWhile:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 53
|
|
||||||
Style/NestedTernaryOperator:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 972
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/Next:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 587
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/NilComparison:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 311
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: IncludeSemanticChanges.
|
|
||||||
Style/NonNilCheck:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 5052
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/Not:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 72
|
|
||||||
Style/OneLineConditional:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 28
|
|
||||||
Style/OpMethod:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 94
|
|
||||||
# Configuration parameters: CountKeywordArgs.
|
|
||||||
Style/ParameterLists:
|
|
||||||
Max: 14
|
|
||||||
|
|
||||||
# Offense count: 3567
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: AllowSafeAssignment.
|
|
||||||
Style/ParenthesesAroundCondition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1030
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/PerlBackrefs:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 154
|
|
||||||
# Configuration parameters: NamePrefixBlacklist.
|
|
||||||
Style/PredicateName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 165
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/Proc:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 100
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/RaiseArgs:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 286
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/RedundantBegin:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 269
|
|
||||||
Style/RedundantException:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3440
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: AllowMultipleReturnValues.
|
|
||||||
Style/RedundantReturn:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 3162
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/RedundantSelf:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 237
|
|
||||||
# Configuration parameters: MaxSlashes.
|
|
||||||
Style/RegexpLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 349
|
|
||||||
Style/RescueModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 203
|
|
||||||
Style/SelfAssignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 485
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: AllowAsExpressionSeparator.
|
|
||||||
Style/Semicolon:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2468
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/SignalException:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 126
|
|
||||||
# Configuration parameters: Methods.
|
|
||||||
Style/SingleLineBlockParams:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 480
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: AllowIfMethodIsEmpty.
|
|
||||||
Style/SingleLineMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 482
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SingleSpaceBeforeFirstArg:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 8
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAfterColon:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 66361
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAfterComma:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1387
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAfterControlKeyword:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 35
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAfterMethodName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 154
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAfterNot:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAfterSemicolon:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2592
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/SpaceAroundEqualsInParameterDefault:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 9743
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceAroundOperators:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 390
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/SpaceBeforeBlockBraces:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1297
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceBeforeComment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 7
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceBeforeModifierKeyword:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1342
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
|
|
||||||
Style/SpaceInsideBlockBraces:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 24964
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceInsideBrackets:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 2807
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
|
|
||||||
Style/SpaceInsideHashLiteralBraces:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 5223
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpaceInsideParens:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 729
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/SpecialGlobalVars:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 111166
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/StringLiterals:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 382
|
|
||||||
Style/Tab:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 568
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/TrailingBlankLines:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 6257
|
|
||||||
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
|
|
||||||
Style/TrailingComma:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1803
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/TrailingWhitespace:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 141
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
|
|
||||||
Style/TrivialAccessors:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 22
|
|
||||||
Style/UnlessElse:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 216
|
|
||||||
Style/UnneededCapitalW:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 13
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/UnneededPercentX:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 93
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/VariableInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 740
|
|
||||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
||||||
Style/VariableName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 1520
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/WhenThen:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 33
|
|
||||||
# Cop supports --auto-correct.
|
|
||||||
Style/WhileUntilDo:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Offense count: 129
|
|
||||||
# Configuration parameters: MaxLineLength.
|
|
||||||
Style/WhileUntilModifier:
|
|
||||||
Enabled: false
|
|
||||||
2
Gemfile
2
Gemfile
|
|
@ -37,8 +37,6 @@ group :pcap do
|
||||||
end
|
end
|
||||||
|
|
||||||
group :development do
|
group :development do
|
||||||
# Style/sanity checking Ruby code
|
|
||||||
gem 'rubocop'
|
|
||||||
# Markdown formatting for yard
|
# Markdown formatting for yard
|
||||||
gem 'redcarpet'
|
gem 'redcarpet'
|
||||||
# generating documentation
|
# generating documentation
|
||||||
|
|
|
||||||
|
|
@ -335,15 +335,6 @@ class Msftidy
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
# Explicitly skip this check if we're suppressing info messages
|
|
||||||
# anyway, since it takes a fair amount of time per module to perform.
|
|
||||||
def check_rubocop
|
|
||||||
return true if SUPPRESS_INFO_MESSAGES
|
|
||||||
out = %x{rubocop -n #{@full_filepath}}
|
|
||||||
ret = $?
|
|
||||||
info("Fails to pass Rubocop Ruby style guidelines (run 'rubocop #{@full_filepath}' to see violations)") unless ret.exitstatus == 0
|
|
||||||
end
|
|
||||||
|
|
||||||
def check_old_rubies
|
def check_old_rubies
|
||||||
return true unless CHECK_OLD_RUBIES
|
return true unless CHECK_OLD_RUBIES
|
||||||
return true unless Object.const_defined? :RVM
|
return true unless Object.const_defined? :RVM
|
||||||
|
|
@ -611,7 +602,6 @@ def run_checks(full_filepath)
|
||||||
tidy.check_vuln_codes
|
tidy.check_vuln_codes
|
||||||
tidy.check_vars_get
|
tidy.check_vars_get
|
||||||
tidy.check_newline_eof
|
tidy.check_newline_eof
|
||||||
tidy.check_rubocop
|
|
||||||
tidy.check_sock_get
|
tidy.check_sock_get
|
||||||
tidy.check_udp_sock_get
|
tidy.check_udp_sock_get
|
||||||
return tidy
|
return tidy
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue