Merge branch 'master' of https://github.com/rapid7/metasploit-framework

spec/lib/active_record/connection_adapters/abstract_adapter/connection_pool_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 # helps with environment configuration to use for connection to database

spec/lib/fastlib_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'msf/core'

spec/lib/msf/core/data_store_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/data_store'

spec/lib/msf/core/exploit/http/client_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'msf/core'

spec/lib/msf/core/module_manager_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 #

spec/lib/msf/core/modules/error_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 describe Msf::Modules::Error do

spec/lib/msf/core/modules/loader/archive_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'msf/core'

spec/lib/msf/core/modules/loader/base_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'msf/core'

spec/lib/msf/core/modules/loader/directory_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 require 'msf/core'
 require 'msf/core/modules/loader/directory'

spec/lib/msf/core/modules/metasploit_class_compatibility_error_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'msf/core/modules/metasploit_class_compatibility_error'

spec/lib/msf/core/modules/namespace_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'msf/core'

spec/lib/msf/core/modules/version_compatibility_error_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 describe Msf::Modules::VersionCompatibilityError do

spec/lib/msf/core/option_container_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/options/opt_address_range_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/options/opt_address_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/options/opt_bool_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/options/opt_int_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/options/opt_path_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/options/opt_port_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'spec_helper'
 require 'msf/core/option_container'

spec/lib/msf/core/task_manager_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'msf/core'
 require 'msf/core/task_manager'

spec/lib/msf/util/exe_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'msf/core'
 require 'msf/base/simple'

spec/lib/rex/encoding/xor/byte_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding: binary -*-
 
 require 'rex/encoding/xor/byte'
 require 'spec_helper'

spec/lib/rex/encoding/xor/dword_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding: binary -*-
 
 require 'rex/encoding/xor/dword'
 require 'spec_helper'

spec/lib/rex/encoding/xor/qword_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding: binary -*-
 
 require 'rex/encoding/xor/qword'
 require 'spec_helper'

spec/lib/rex/encoding/xor/word_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding: binary -*-
 
 require 'rex/encoding/xor/word'
 require 'spec_helper'

spec/lib/rex/parser/nmap_xml_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 require 'rex/parser/nmap_xml'
 

spec/lib/rex/post/meterpreter/packet_parser_spec.rb

@@ -1,9 +1,10 @@
+# -*- coding:binary -*-
 require 'rex/post/meterpreter/packet'
 require 'rex/post/meterpreter/packet_parser'
 
 
 describe Rex::Post::Meterpreter::PacketParser do
-  subject{
+  subject(:parser){
     Rex::Post::Meterpreter::PacketParser.new
   }
   before(:each) do
@@ -17,41 +18,17 @@ describe Rex::Post::Meterpreter::PacketParser do
     end
   end
 
-  it "should respond to cipher" do
-    subject.should respond_to :cipher
-  end
-
-  it "should respond to raw" do
-    subject.should respond_to :raw
-  end
-
-  it "should respond to reset" do
-    subject.should respond_to :reset
-  end
-
-  it "should respond to recv" do
-    subject.should respond_to :recv
-  end
-
-  it "should respond to hdr_length_left" do
-    subject.should respond_to :hdr_length_left
-  end
-
-  it "should respond to payload_length_left" do
-    subject.should respond_to :payload_length_left
-  end
-
   it "should initialise with expected defaults" do
-    subject.send(:raw).should == ""
-    subject.send(:hdr_length_left).should == 8
-    subject.send(:payload_length_left).should == 0
+    parser.send(:raw).should == ""
+    parser.send(:hdr_length_left).should == 8
+    parser.send(:payload_length_left).should == 0
   end
 
   it "should parse valid raw data into a packet object" do
     while @raw.length >0
-      parsed_packet = subject.recv(@sock)
+      parsed_packet = parser.recv(@sock)
     end
-    parsed_packet.class.should == Rex::Post::Meterpreter::Packet
+    parsed_packet.should be_a Rex::Post::Meterpreter::Packet
     parsed_packet.type.should == Rex::Post::Meterpreter::PACKET_TYPE_REQUEST
     parsed_packet.method?("test_method").should == true
   end

spec/lib/rex/post/meterpreter/packet_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'rex/post/meterpreter/packet'
 
 describe Rex::Post::Meterpreter::Tlv do

spec/lib/rex/proto/http/client_request_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'spec_helper'
 
 require 'rex/proto/http/client_request'

spec/lib/rex/proto/http/client_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'rex/proto/http/client'
 
 # Note: Some of these tests require a failed

spec/lib/rex/socket/range_walker_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'rex/socket/range_walker'
 
 describe Rex::Socket::RangeWalker do

spec/lib/rex/sslscan/result_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'rex/sslscan/result'
 
 describe Rex::SSLScan::Result do

spec/lib/rex/sslscan/scanner_spec.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'rex/sslscan/scanner'
 require 'rex/thread_factory'
 require 'rex/text'

spec/spec_helper.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'rubygems'
 require 'bundler'
 Bundler.require(:default, :test, :db)

spec/support/shared/contexts/database_cleaner.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'metasploit/framework/database'
 
 shared_context 'DatabaseCleaner' do

spec/support/shared/contexts/msf/modules/error_attributes.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_context 'Msf::Modules::Error attributes' do
 	let(:causal_message) do
 		'rspec'

spec/support/shared/contexts/msf/modules/loader_base.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_context "Msf::Modules::Loader::Base" do
 	let(:parent_path) do
 		parent_pathname.to_s

spec/support/shared/contexts/msf/simple/framework.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'msf/base/simple/framework'
 require 'metasploit/framework'
 

spec/support/shared/examples/msf/db_manager/import_msf_xml.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 require 'builder'
 
 shared_examples_for 'Msf::DBManager::ImportMsfXml' do

spec/support/shared/examples/msf/db_manager/import_msf_xml/check_msf_xml_version_with_root_tag.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_examples_for 'Msf::DBManager::ImportMsfXml#check_msf_xml_version! with root tag' do |root_tag, options={}|
 	options.assert_valid_keys(:allow_yaml)
 	allow_yaml = options.fetch(:allow_yaml)

spec/support/shared/examples/msf/db_manager/import_msf_xml/import_msf_web_element_specialization.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_examples_for 'Msf::DBManager::ImportMsfXml#import_msf_web_element specialization' do
 	it 'should call #import_msf_web_element with element' do
 		db_manager.should_receive(:import_msf_web_element).with(element, anything)

spec/support/shared/examples/msf/modules/error_subclass_initialize.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_examples_for 'Msf::Modules::Error subclass #initialize' do
 	context 'instance methods' do
 		context '#initialize' do

spec/support/shared/examples/msf/modules/loader_archive_read_module_content.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_examples_for 'Msf::Modules::Loader::Archive#read_module_content' do
 	it 'should be able to read the module content' do
 		archived_module_content = subject.send(:read_module_content, @parent_path, type, module_reference_name)

spec/support/shared/examples/msf/modules/version_compatibility_error.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_examples_for 'Msf::Modules::VersionCompatibilityError' do
 	let(:error) do
 		begin

spec/support/shared/examples/options.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 
 shared_examples_for "an option" do |valid_values, invalid_values|
   subject do

spec/support/shared/examples/typed_path.rb

@@ -1,3 +1,4 @@
+# -*- coding:binary -*-
 shared_examples_for 'typed_path' do |map|
 	map ||= {}
 	if map.length < 1

spec/support/shared/examples/xor_encoder.rb

@@ -1,3 +1,4 @@
+# -*- coding: binary -*-
 shared_examples_for 'an xor encoder' do |keysize|
 
 	it "should encode one block" do