Add new method for fetching parsed cookies from an HTTP response

This fixed #9332.
MS-2855/keylogger-mettle-extension
Jon Hart 2017-12-20 16:19:44 -08:00
parent fe4c701016
commit 2e62d77e36
No known key found for this signature in database
GPG Key ID: 2FA9F0A3AFA8E9D3
2 changed files with 38 additions and 1 deletions

View File

@ -1,4 +1,5 @@
# -*- coding: binary -*-
require 'cgi'
require 'uri'
require 'rex/proto/http'
require 'nokogiri'
@ -84,6 +85,18 @@ class Response < Packet
return cookies.strip
end
#
# Gets cookies from the Set-Cookie header in a parsed format
#
def get_cookies_parsed
if (self.headers.include?('Set-Cookie'))
ret = CGI::Cookie::parse(self.headers['Set-Cookie'])
else
ret = {}
end
ret
end
# Returns a parsed HTML document.
# Instead of using regexes to parse the HTML body, you should use this and use the Nokogiri API.

View File

@ -133,6 +133,14 @@ RSpec.describe Rex::Proto::Http::Response do
HEREDOC
end
let (:get_cookies_spaces_and_missing_semicolon) do
<<-HEREDOC.gsub(/^ {6}/, '')
HTTP/1.1 200 OK
Set-Cookie: k1=v1; k2=v2;k3=v3
HEREDOC
end
let (:meta_name) do
'META_NAME'
end
@ -176,7 +184,7 @@ RSpec.describe Rex::Proto::Http::Response do
<genre>Computer</genre>
<price>44.95</price>
<publish_date>2000-10-01</publish_date>
<description>An in-depth look at creating applications
<description>An in-depth look at creating applications
with XML.</description>
</book>
</catalog>
@ -396,6 +404,22 @@ RSpec.describe Rex::Proto::Http::Response do
expect(cookies_array).to include(*expected_cookies)
end
it 'parses cookies with inconsistent spacing and a missing trailing semicolons' do
resp = described_class.new()
resp.parse(self.send :get_cookies_spaces_and_missing_semicolon)
cookies = resp.get_cookies_parsed
names = cookies.keys.sort
values = []
cookies.each do |_, parsed|
parsed.value.each do |value|
values << value
end
end
values.sort!
expect(names).to eq(%w(k1 k2 k3))
expect(values).to eq(%w(v1 v2 v3))
end
end
end