Merge branch 'useragent_cleanup' of git://github.com/ChrisJohnRiley/metasploit-framework into ChrisJohnRiley-useragent_cleanup

modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb

@@ -48,11 +48,7 @@ class Metasploit3 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'	 => "/dswsbobje/services/listServices",
-			'method'  => 'GET',
+			'method'  => 'GET'
-				'headers' => {
-					'User-Agent' => datastore['UserAgent']
-				}
-
 		}, 25)
 		return if not res
 

modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb

@@ -44,11 +44,7 @@ class Metasploit3 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'	 => "/PlatformServices/service/app/logon.object",
-			'method'  => 'GET',
+			'method'  => 'GET'
-				'headers' => {
-					'User-Agent' => datastore['UserAgent']
-				}
-
 		}, 25)
 		return if not res
 

modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb

@@ -50,11 +50,7 @@ class Metasploit3 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'    => normalize_uri(datastore['URI']) + "/services/listServices",
-			'method' => 'GET',
+			'method' => 'GET'
-				'headers' => {
-					'User-Agent' => datastore['UserAgent']
-				}
-
 		}, 25)
 		return if not res
 

modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb

@@ -49,11 +49,7 @@ class Metasploit3 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'    => normalize_uri(datastore['URI']) + "/services/listServices",
-			'method' => 'GET',
+			'method' => 'GET'
-				'headers' => {
-					'User-Agent' => datastore['UserAgent']
-				}
-
 		}, 25)
 		return if not res or res.code != 200
 

modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb

@@ -47,8 +47,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'     => normalize_uri(datastore['URI']),
-			'method'  => 'GET',
+			'method'  => 'GET'
-			'headers' => {'User-Agent' => datastore['UserAgent']}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_brute_login.rb

@@ -52,11 +52,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'     => normalize_uri(datastore['URI']),
-			'method'  => 'GET',
+			'method'  => 'GET'
-			'headers' =>
-				{
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb

@@ -50,12 +50,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'     => normalize_uri(datastore['URI']),
-			'method'  => 'GET',
+			'method'  => 'GET'
-			'headers' =>
-				{
-					'User-Agent' => datastore['UserAgent']
-				}
-
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb

@@ -50,11 +50,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'      => normalize_uri(datastore['URI']),
-			'method'   => 'GET',
+			'method'   => 'GET'
-			'headers'  =>
-				{
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb

@@ -50,11 +50,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'      => normalize_uri(datastore['URI']),
-			'method'   => 'GET',
+			'method'   => 'GET'
-			'headers'  =>
-				{
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_getlogfiles.rb

@@ -41,8 +41,8 @@ class Metasploit4 < Msf::Auxiliary
 				Opt::RPORT(50013),
 				OptString.new('URI', [false, 'Path to the SAP Management Console ', '/']),
 				OptString.new('RFILE', [ true, 'The name of the file to download ', 'sapstart.log']),
-				OptString.new('FILETYPE', [true, 'Specify LOGFILE or TRACEFILE', 'TRACEFILE']),
+				OptEnum.new('FILETYPE', [true, 'Specify LOGFILE or TRACEFILE', 'TRACEFILE', ['TRACEFILE','LOGFILE']]),
-				OptBool.new('GETALL', [ false, 'Download all available files (WARNING: may take long!)', false]),
+				OptBool.new('GETALL', [ false, 'Download all available files (WARNING: may take a long time!)', false])
 			], self.class)
 		register_autofilter_ports([ 50013 ])
 		deregister_options('RHOST')

modules/auxiliary/scanner/sap/sap_mgmt_con_getprocessparameter.rb

@@ -51,11 +51,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'      => normalize_uri(datastore['URI']),
-			'method'   => 'GET',
+			'method'   => 'GET'
-			'headers'  =>
-				{
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_listlogfiles.rb

@@ -39,7 +39,7 @@ class Metasploit4 < Msf::Auxiliary
 			[
 				Opt::RPORT(50013),
 				OptString.new('URI', [false, 'Path to the SAP Management Console ', '/']),
-				OptString.new('FILETYPE', [true, 'Specify LOGFILE or TRACEFILE', 'TRACEFILE']),
+				OptEnum.new('FILETYPE', [true, 'Specify LOGFILE or TRACEFILE', 'TRACEFILE', ['TRACEFILE','LOGFILE']])
 			], self.class)
 		register_autofilter_ports([ 50013 ])
 		deregister_options('RHOST')
@@ -52,11 +52,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'      => normalize_uri(datastore['URI']),
-			'method'   => 'GET',
+			'method'   => 'GET'
-			'headers'  =>
-				{
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb

@@ -50,10 +50,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'      => normalize_uri(datastore['URI']),
-			'method'   => 'GET',
+			'method'   => 'GET'
-			'headers' => {
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res

modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb

@@ -50,10 +50,7 @@ class Metasploit4 < Msf::Auxiliary
 	def run_host(ip)
 		res = send_request_cgi({
 			'uri'	 => normalize_uri(datastore['URI']),
-			'method'  => 'GET',
+			'method'  => 'GET'
-				'headers' => {
-					'User-Agent' => datastore['UserAgent']
-				}
 		}, 25)
 
 		if not res