Do a little better password management for services that don't ask for usernames -- fingerprint them ahead of time, and resort the credentials list in a usernameless way. Also, this allows telnet RST's to be treated just as busy services, since sometimes telnet servers get persnickety about a lot of login attempts, but they do come back shortly.

git-svn-id: file:///home/svn/framework3/trunk@8920 4d416f70-5f16-0410-b530-b9f4589650da

lib/msf/core/auxiliary/auth_brute.rb

@@ -41,6 +41,7 @@ def each_user_pass(&block)
 		credentials = gen_blank_passwords(users,credentials) + credentials
 	end
 	credentials.concat(combine_users_and_passwords(users,passwords))
+	credentials = just_uniq_passwords(credentials) if @strip_usernames
 	credentials.each do |u,p|
 		fq_user = "%s:%s:%s" % [datastore['RHOST'], datastore['RPORT'], u]
 		userpass_sleep_interval unless @@credentials_tried.empty?
@@ -58,6 +59,11 @@ def each_user_pass(&block)
 	return
 end
 
+def just_uniq_passwords(credentials)
+	new_creds = credentials.map{|x| x[0] = ""; x}
+	credentials.uniq
+end
+
 def gen_blank_passwords(user_array,cred_array)
 	blank_passwords = []
 	unless user_array.empty?

modules/auxiliary/scanner/telnet/telnet_login.rb

@@ -67,6 +67,11 @@ class Metasploit3 < Msf::Auxiliary
 
 		self.password_only = []
 
+		if connect_reset_safe == :connected
+			@strip_usernames = true if password_prompt? 
+			self.sock.close
+		end
+
 		begin
 			each_user_pass do |user, pass|
 				Timeout.timeout(overall_timeout) do
@@ -81,16 +86,19 @@ class Metasploit3 < Msf::Auxiliary
 	def try_user_pass(user, pass)
 		vprint_status "#{rhost}:#{rport} Telnet - Attempting: '#{user}':'#{pass}'"
 		ret = do_login(user,pass)
-    if ret == :no_auth_required
+		case ret
+		when :no_auth_required
 			print_good "#{rhost}:#{rport} Telnet - No authentication required!"
 			return :abort
-		elsif ret == :no_pass_prompt
+		when :no_pass_prompt
 			vprint_status "#{rhost}:#{rport} Telnet - Skipping '#{user}' due to missing password prompt"
 			return :next_user
-		elsif ret == :timeout
+		when :timeout
 			vprint_status "#{rhost}:#{rport} Telnet - Skipping '#{user}':'#{pass}' due to timeout"
-		elsif ret == :busy
-			vprint_status "#{rhost}:#{rport} Telnet - Skipping '#{user}':'#{pass}' due to busy state"
+		when :busy
+			vprint_error "#{rhost}:#{rport} Telnet - Skipping '#{user}':'#{pass}' due to busy state"
+		when :refused
+			vprint_error "#{rhost}:#{rport} Telnet - Skipping '#{user}':'#{pass}' due to connection refused."
 		else
 			if login_succeeded?
 				start_telnet_session(rhost,rport,user,pass)
@@ -99,11 +107,25 @@ class Metasploit3 < Msf::Auxiliary
 		end
 	end
 
+	# Sometimes telnet servers start RSTing if you get them angry.
+	# This is a short term fix; the problem is that we don't know
+	# if it's going to reset forever, or just this time, or randomly.
+	# A better solution is to get the socket connect to try again
+	# with a little backoff. 
+	def connect_reset_safe
+		begin
+			connect
+		rescue Rex::ConnectionRefused
+			return :refused
+		end
+		return :connected
+	end
+
 	# Making this serial since the @attempts counting business is causing
 	# all kinds of syncing problems.
 	def do_login(user,pass)
 
-		connect
+		return :refused if connect_reset_safe == :refused
 
 		begin
 
@@ -124,11 +146,11 @@ class Metasploit3 < Msf::Auxiliary
 			user = ''
 
 			if password_only.include?(pass)
-				print_status("#{rhost}:#{rport} only asks for a password that we already tried: '#{pass}'")
+				print_status("#{rhost}:#{rport} - Telnet - skipping already tried password '#{pass}'")
 				return :tried
 			end
 
-			print_status("#{rhost}:#{rport} only asks for a password, trying #{pass}")
+			print_status("#{rhost}:#{rport} - Telnet - trying password only authentication with password '#{pass}'")
 			password_only << pass
 		else
 			send_user(user)