Adds some light testing for Rex's HTTP client lib

In light ofi PR #1476, it would be nice to have some basic, modern,
maintained testing on Rex's HTTP Client proto library.

My rspec fu is quite weak, of course, but this should cover the very
basic cases. There are lots of pending holes, but hey, it's a start.

lib/rex/proto/http/client.rb

@@ -420,7 +420,8 @@ class Client
 		!(self.username.nil?) && self.username != ''
 	end
 
-	#
+	alias :has_creds? :have_creds?
+
 	# Params -
 	#    res = The 401 response we need to auth from
 	#    opts = the opts used to generate the request that created this response

spec/lib/rex/proto/http/client.rb

@@ -0,0 +1,244 @@
+require 'rex/proto/http/client'
+
+# Note: Some of these tests require a failed
+# connection to 127.0.0.1:1. If you have some crazy local
+# firewall that is dropping packets to this, your tests
+# might be slow. I wonder how Travis-CI will react to this...
+
+# Set a standard excuse that indicates that the method
+# under test needs to be first examined to figure out
+# what's sane and what's not.
+def excuse_lazy(test_method=nil)
+	ret = "need to determine pass/fail criteria"
+	test_method ? ret << " for #{test_method.inspect}" : ret
+end
+
+# Complain about not having a "real" connection (can be mocked)
+def excuse_needs_connection
+	"need to actually set up an HTTP server to test"
+end
+
+# Complain about not having a real auth server (can be mocked)
+def excuse_needs_auth
+	"need to set up an HTTP authentication challenger"
+end
+
+describe Rex::Proto::Http::Client do
+
+	ip = "1.2.3.4"
+
+	cli = Rex::Proto::Http::Client.new(ip)
+	it "should respond to intialize" do
+		cli.should be
+	end
+
+	it "should have a set of default instance variables" do
+		cli.instance_variable_get(:@hostname).should == ip
+		cli.instance_variable_get(:@port).should == 80
+		cli.instance_variable_get(:@context).should == {}
+		cli.instance_variable_get(:@ssl).should be_false
+		cli.instance_variable_get(:@proxies).should be_nil
+		cli.instance_variable_get(:@username).should be_empty
+		cli.instance_variable_get(:@password).should be_empty
+		cli.config.should be_a_kind_of Hash
+		cli.config_types.should be_a_kind_of Hash
+	end
+
+	it "should produce a raw HTTP request" do
+		cli.request_raw.should be_a_kind_of Rex::Proto::Http::Request
+	end
+
+	it "should produce a CGI HTTP request" do
+		cli.request_cgi.should be_a_kind_of Rex::Proto::Http::Request
+	end
+
+	it "should attempt to connect to a server" do
+		this_cli = Rex::Proto::Http::Client.new("127.0.0.1", 1)
+		expect { this_cli.connect(1) }.to raise_error ::Rex::ConnectionRefused
+	end
+
+	it "should be able to close a connection" do
+		cli.close.should be_nil
+	end
+
+	it "should send a request and receive a response" do
+		# cli.send_recv
+		pending excuse_needs_connection
+	end
+
+	it "should send a request and receive a response without auth handling" do
+		# cli._send_recv
+		pending excuse_needs_connection
+	end
+
+	it "should send a request" do
+		# cli.send_request
+		pending excuse_needs_connection
+	end
+
+	it "should test for credentials" do
+		cli.should_not have_creds
+		this_cli = Rex::Proto::Http::Client.new("127.0.0.1", 1, {}, false, nil, nil, "user1", "pass1" )
+		this_cli.should have_creds
+	end
+
+	it "should send authentication" do
+		pending excuse_needs_connection
+	end
+
+	it "should produce a basic authentication header" do
+		u = "user1"
+		p = "pass1"
+		b64 = ["#{u}:#{p}"].pack("m*").strip
+		cli.basic_auth_header("user1","pass1").should == "Basic #{b64}"
+	end
+
+	it "should perform digest authentication" do
+		# cli.digest_auth
+		pending excuse_needs_auth
+	end
+
+	it "should perform negotiate authentication" do
+		# cli.negotiate_auth
+		pending excuse_needs_auth
+	end
+
+	it "should get a response" do
+		# cli.read_response
+		pending excuse_needs_connection
+	end
+
+	it "should end a connection with a stop" do
+		cli.stop.should be_nil
+	end
+
+	it "should test if a connection is valid" do
+		cli.conn?.should be_false
+	end
+
+	it "should tell if pipelining is enabled" do
+		cli.pipelining?.should be_false
+		this_cli = Rex::Proto::Http::Client.new("127.0.0.1", 1)
+		this_cli.pipeline = true
+		this_cli.pipelining?.should be_true
+	end
+
+	it "should return an encoded URI" do
+		pending excuse_lazy :set_encode_uri
+	end
+
+	it "should return an encoded query string" do
+		pending excuse_lazy :set_encode_qa
+	end
+
+	# These set_ methods all exercise the evasion opts, looks like
+
+	it "should set and return the URI" do
+		pending excuse_lazy :set_uri
+	end
+
+	it "should set and return the CGI" do
+		pending excuse_lazy :set_cgi
+	end
+
+	it "should set and return the HTTP verb" do
+		pending excuse_lazy :set_method
+	end
+
+	it "should set and return the version string" do
+		pending excuse_lazy :set_version
+	end
+
+	it "should set and return the HTTP seperator and body string" do
+		pending excuse_lazy :set_body
+	end
+
+	it "should set and return the path" do
+		pending excuse_lazy :set_path_info
+	end
+
+	it "should set and return the whitespace between method and URI" do
+		pending excuse_lazy :set_method_uri_spacer
+	end
+
+	it "should set and return the whitespace between the version and URI" do
+		pending excuse_lazy :set_uri_version_spacer
+	end
+
+	it "should set and return padding before the URI" do
+		pending excuse_lazy :set_uri_prepend
+	end
+
+	it "should set and return padding after the URI" do
+		cli.set_uri_append.should be_empty
+	end
+
+	it "should set and return the host header" do
+		pending excuse_lazy :set_host_header
+	end
+
+	it "should set and return the agent header" do
+		pending excuse_lazy :set_agent_header
+	end
+
+	it "should set and return the cookie header" do
+		pending excuse_lazy :set_cookie_header
+	end
+
+
+	it "should set and return the content-type header" do
+		pending excuse_lazy :set_cookie_header
+	end
+
+	it "should set and return the content-length header" do
+		pending excuse_lazy :set_content_len_header
+	end
+
+	it "should set and return the basic authentication header" do
+		pending excuse_lazy :set_basic_auth_header
+	end
+
+	it "should set and return any extra headers" do
+		pending excuse_lazy :set_extra_headers
+	end
+
+	it "should set the chunked encoding header" do
+		pending excuse_lazy :set_chunked_header
+	end
+
+	it "should set and return raw_headers" do
+		pending "#set_raw_headers() doesn't seem to actually do anything"
+	end
+
+	it "should set and return a formatted header" do
+		pending :set_formatted_header
+	end
+
+	it "should respond to its various accessors" do
+		cli.should respond_to :config
+		cli.should respond_to :config_types
+		cli.should respond_to :pipeline
+		cli.should respond_to :local_host
+		cli.should respond_to :local_port
+		cli.should respond_to :conn
+		cli.should respond_to :context
+		cli.should respond_to :proxies
+		cli.should respond_to :username
+		cli.should respond_to :password
+		cli.should respond_to :junk_pipeline
+		# These are supposed to be protected
+		cli.should respond_to :ssl
+		cli.should respond_to :ssl_version
+		cli.should respond_to :hostname
+		cli.should respond_to :port
+	end
+
+	# Not super sure why these are protected...
+	it "should refuse access to its protected accessors" do
+		expect {cli.ssl}.to raise_error NoMethodError
+		expect {cli.ssl_version}.to raise_error NoMethodError
+		expect {cli.hostname}.to raise_error NoMethodError
+		expect {cli.port}.to raise_error NoMethodError
+	end
+
+end