2010-11-05 00:05:34 +00:00
|
|
|
#!/usr/bin/env ruby
|
2013-10-16 15:40:42 +00:00
|
|
|
# -*- coding: binary -*-
|
2010-11-05 00:05:34 +00:00
|
|
|
#
|
|
|
|
# Check (recursively) for style compliance violations and other
|
|
|
|
# tree inconsistencies.
|
|
|
|
#
|
2014-04-02 16:12:00 +00:00
|
|
|
# by jduck, todb, and friends
|
2010-11-05 00:05:34 +00:00
|
|
|
#
|
2013-10-16 15:40:42 +00:00
|
|
|
require 'fileutils'
|
|
|
|
require 'find'
|
2014-01-31 20:19:04 +00:00
|
|
|
require 'time'
|
2010-11-05 00:05:34 +00:00
|
|
|
|
2011-12-12 21:12:01 +00:00
|
|
|
CHECK_OLD_RUBIES = !!ENV['MSF_CHECK_OLD_RUBIES']
|
2014-06-12 18:46:10 +00:00
|
|
|
SUPPRESS_INFO_MESSAGES = !!ENV['MSF_SUPPRESS_INFO_MESSAGES']
|
2015-01-21 17:52:39 +00:00
|
|
|
TITLE_WHITELIST = %w{
|
2015-01-21 17:50:50 +00:00
|
|
|
a an and as at avserve callmenum configdir connect debug docbase dtspcd
|
2015-01-21 20:01:44 +00:00
|
|
|
execve file for from getinfo goaway gsad hetro historysearch htpasswd ibstat
|
|
|
|
id in inetd iseemedia jhot libxslt lmgrd lnk load main map migrate mimencode
|
|
|
|
multisort name net netcat nodeid ntpd nttrans of on onreadystatechange or
|
|
|
|
ovutil path pbot pfilez pgpass pingstr pls popsubfolders prescan readvar
|
|
|
|
relfile rev rexec rlogin rsh rsyslog sa sadmind say sblistpack spamd
|
|
|
|
sreplace tagprinter the tnftp to twikidraw udev uplay user username via
|
|
|
|
welcome with ypupdated zsudo
|
2015-01-21 17:50:50 +00:00
|
|
|
}
|
2011-12-12 21:12:01 +00:00
|
|
|
|
|
|
|
if CHECK_OLD_RUBIES
|
2013-09-30 18:47:53 +00:00
|
|
|
require 'rvm'
|
|
|
|
warn "This is going to take a while, depending on the number of Rubies you have installed."
|
2011-12-12 21:12:01 +00:00
|
|
|
end
|
2011-10-16 15:53:19 +00:00
|
|
|
|
2012-10-12 07:55:16 +00:00
|
|
|
class String
|
2013-09-30 18:47:53 +00:00
|
|
|
def red
|
|
|
|
"\e[1;31;40m#{self}\e[0m"
|
|
|
|
end
|
2010-11-05 00:05:34 +00:00
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def yellow
|
|
|
|
"\e[1;33;40m#{self}\e[0m"
|
|
|
|
end
|
2013-01-04 20:09:37 +00:00
|
|
|
|
2013-10-16 15:40:42 +00:00
|
|
|
def green
|
|
|
|
"\e[1;32;40m#{self}\e[0m"
|
|
|
|
end
|
|
|
|
|
2014-04-21 16:04:14 +00:00
|
|
|
def cyan
|
|
|
|
"\e[1;36;40m#{self}\e[0m"
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def ascii_only?
|
|
|
|
self =~ Regexp.new('[\x00-\x08\x0b\x0c\x0e-\x19\x7f-\xff]', nil, 'n') ? false : true
|
|
|
|
end
|
2010-11-05 00:05:34 +00:00
|
|
|
end
|
|
|
|
|
2012-10-12 07:55:16 +00:00
|
|
|
class Msftidy
|
2011-12-12 21:12:01 +00:00
|
|
|
|
2014-01-31 20:19:04 +00:00
|
|
|
# Status codes
|
|
|
|
OK = 0x00
|
|
|
|
WARNINGS = 0x10
|
|
|
|
ERRORS = 0x20
|
|
|
|
|
2014-08-26 20:30:08 +00:00
|
|
|
# Some compiles regexes
|
|
|
|
REGEX_MSF_EXPLOIT = / \< Msf::Exploit/
|
|
|
|
REGEX_IS_BLANK_OR_END = /^\s*end\s*$/
|
|
|
|
|
2014-01-31 20:19:04 +00:00
|
|
|
attr_reader :full_filepath, :source, :stat, :name, :status
|
2013-10-16 15:40:42 +00:00
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def initialize(source_file)
|
2013-10-16 15:40:42 +00:00
|
|
|
@full_filepath = source_file
|
2015-12-22 21:38:31 +00:00
|
|
|
@module_type = File.dirname(File.expand_path(@full_filepath))[/\/modules\/([^\/]+)/, 1]
|
2013-09-30 18:47:53 +00:00
|
|
|
@source = load_file(source_file)
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines = @source.lines # returns an enumerator
|
2014-01-31 20:19:04 +00:00
|
|
|
@status = OK
|
2013-10-16 15:40:42 +00:00
|
|
|
@name = File.basename(source_file)
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
public
|
|
|
|
|
|
|
|
#
|
2014-01-31 20:19:04 +00:00
|
|
|
# Display a warning message, given some text and a number. Warnings
|
|
|
|
# are usually style issues that may be okay for people who aren't core
|
|
|
|
# Framework developers.
|
2013-09-30 18:47:53 +00:00
|
|
|
#
|
2014-01-31 20:19:04 +00:00
|
|
|
# @return status [Integer] Returns WARNINGS unless we already have an
|
|
|
|
# error.
|
|
|
|
def warn(txt, line=0) line_msg = (line>0) ? ":#{line}" : ''
|
2014-03-01 11:02:41 +00:00
|
|
|
puts "#{@full_filepath}#{line_msg} - [#{'WARNING'.yellow}] #{cleanup_text(txt)}"
|
2014-01-31 20:19:04 +00:00
|
|
|
@status == ERRORS ? @status = ERRORS : @status = WARNINGS
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
|
2014-01-31 20:19:04 +00:00
|
|
|
#
|
|
|
|
# Display an error message, given some text and a number. Errors
|
|
|
|
# can break things or are so egregiously bad, style-wise, that they
|
|
|
|
# really ought to be fixed.
|
|
|
|
#
|
|
|
|
# @return status [Integer] Returns ERRORS
|
2013-09-30 18:47:53 +00:00
|
|
|
def error(txt, line=0)
|
2014-01-23 20:21:48 +00:00
|
|
|
line_msg = (line>0) ? ":#{line}" : ''
|
2014-03-01 11:02:41 +00:00
|
|
|
puts "#{@full_filepath}#{line_msg} - [#{'ERROR'.red}] #{cleanup_text(txt)}"
|
2014-01-31 20:19:04 +00:00
|
|
|
@status = ERRORS
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
|
2014-01-31 20:19:04 +00:00
|
|
|
# Currently unused, but some day msftidy will fix errors for you.
|
2013-10-16 15:40:42 +00:00
|
|
|
def fixed(txt, line=0)
|
2014-01-23 20:21:48 +00:00
|
|
|
line_msg = (line>0) ? ":#{line}" : ''
|
2014-03-01 11:02:41 +00:00
|
|
|
puts "#{@full_filepath}#{line_msg} - [#{'FIXED'.green}] #{cleanup_text(txt)}"
|
2013-10-16 15:40:42 +00:00
|
|
|
end
|
|
|
|
|
2014-04-21 16:04:14 +00:00
|
|
|
#
|
|
|
|
# Display an info message. Info messages do not alter the exit status.
|
|
|
|
#
|
|
|
|
def info(txt, line=0)
|
2014-06-12 18:46:10 +00:00
|
|
|
return if SUPPRESS_INFO_MESSAGES
|
2014-04-21 16:04:14 +00:00
|
|
|
line_msg = (line>0) ? ":#{line}" : ''
|
|
|
|
puts "#{@full_filepath}#{line_msg} - [#{'INFO'.cyan}] #{cleanup_text(txt)}"
|
|
|
|
end
|
2013-09-30 18:47:53 +00:00
|
|
|
|
|
|
|
##
|
|
|
|
#
|
|
|
|
# The functions below are actually the ones checking the source code
|
|
|
|
#
|
|
|
|
##
|
|
|
|
|
2013-11-05 17:49:15 +00:00
|
|
|
def check_mode
|
|
|
|
unless (@stat.mode & 0111).zero?
|
|
|
|
warn("Module should not be marked executable")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-11-08 22:11:48 +00:00
|
|
|
def check_shebang
|
2014-08-26 20:30:08 +00:00
|
|
|
if @lines.first =~ /^#!/
|
2013-11-08 22:11:48 +00:00
|
|
|
warn("Module should not have a #! line")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-05-29 16:52:17 +00:00
|
|
|
# Updated this check to see if Nokogiri::XML.parse is being called
|
|
|
|
# specifically. The main reason for this concern is that some versions
|
|
|
|
# of libxml2 are still vulnerable to XXE attacks. REXML is safer (and
|
|
|
|
# slower) since it's pure ruby. Unfortunately, there is no pure Ruby
|
|
|
|
# HTML parser (except Hpricot which is abandonware) -- easy checks
|
|
|
|
# can avoid Nokogiri (most modules use regex anyway), but more complex
|
|
|
|
# checks tends to require Nokogiri for HTML element and value parsing.
|
2014-02-02 17:51:21 +00:00
|
|
|
def check_nokogiri
|
2014-05-29 16:52:17 +00:00
|
|
|
msg = "Using Nokogiri in modules can be risky, use REXML instead."
|
2014-02-02 17:51:21 +00:00
|
|
|
has_nokogiri = false
|
2014-05-29 16:52:17 +00:00
|
|
|
has_nokogiri_xml_parser = false
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines.each do |line|
|
2014-05-29 18:06:47 +00:00
|
|
|
if has_nokogiri
|
|
|
|
if line =~ /Nokogiri::XML\.parse/ or line =~ /Nokogiri::XML::Reader/
|
2014-05-29 16:52:17 +00:00
|
|
|
has_nokogiri_xml_parser = true
|
|
|
|
break
|
|
|
|
end
|
2014-05-29 18:06:47 +00:00
|
|
|
else
|
2014-07-17 16:29:13 +00:00
|
|
|
has_nokogiri = line_has_require?(line, 'nokogiri')
|
2014-02-02 17:51:21 +00:00
|
|
|
end
|
|
|
|
end
|
2014-05-29 16:52:17 +00:00
|
|
|
error(msg) if has_nokogiri_xml_parser
|
2014-02-02 17:51:21 +00:00
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def check_ref_identifiers
|
|
|
|
in_super = false
|
|
|
|
in_refs = false
|
|
|
|
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines.each do |line|
|
2014-01-30 20:39:28 +00:00
|
|
|
if !in_super and line =~ /\s+super\(/
|
2013-09-30 18:47:53 +00:00
|
|
|
in_super = true
|
|
|
|
elsif in_super and line =~ /[[:space:]]*def \w+[\(\w+\)]*/
|
|
|
|
in_super = false
|
|
|
|
break
|
|
|
|
end
|
|
|
|
|
2014-01-09 02:32:30 +00:00
|
|
|
if in_super and line =~ /["']References["'][[:space:]]*=>/
|
2013-09-30 18:47:53 +00:00
|
|
|
in_refs = true
|
|
|
|
elsif in_super and in_refs and line =~ /^[[:space:]]+\],*/m
|
|
|
|
break
|
|
|
|
elsif in_super and in_refs and line =~ /[^#]+\[[[:space:]]*['"](.+)['"][[:space:]]*,[[:space:]]*['"](.+)['"][[:space:]]*\]/
|
|
|
|
identifier = $1.strip.upcase
|
|
|
|
value = $2.strip
|
|
|
|
|
|
|
|
case identifier
|
|
|
|
when 'CVE'
|
2015-04-01 03:15:33 +00:00
|
|
|
warn("Invalid CVE format: '#{value}'") if value !~ /^\d{4}\-\d{4,}$/
|
2013-09-30 18:47:53 +00:00
|
|
|
when 'OSVDB'
|
|
|
|
warn("Invalid OSVDB format: '#{value}'") if value !~ /^\d+$/
|
|
|
|
when 'BID'
|
|
|
|
warn("Invalid BID format: '#{value}'") if value !~ /^\d+$/
|
|
|
|
when 'MSB'
|
|
|
|
warn("Invalid MSB format: '#{value}'") if value !~ /^MS\d+\-\d+$/
|
|
|
|
when 'MIL'
|
|
|
|
warn("milw0rm references are no longer supported.")
|
|
|
|
when 'EDB'
|
|
|
|
warn("Invalid EDB reference") if value !~ /^\d+$/
|
|
|
|
when 'US-CERT-VU'
|
|
|
|
warn("Invalid US-CERT-VU reference") if value !~ /^\d+$/
|
2013-10-21 20:30:07 +00:00
|
|
|
when 'ZDI'
|
|
|
|
warn("Invalid ZDI reference") if value !~ /^\d{2}-\d{3}$/
|
2015-07-30 04:22:48 +00:00
|
|
|
when 'WPVDB'
|
|
|
|
warn("Invalid WPVDB reference") if value !~ /^\d+$/
|
2015-09-02 04:25:01 +00:00
|
|
|
when 'PACKETSTORM'
|
|
|
|
warn("Invalid PACKETSTORM reference") if value !~ /^\d+$/
|
2013-09-30 18:47:53 +00:00
|
|
|
when 'URL'
|
|
|
|
if value =~ /^http:\/\/www\.osvdb\.org/
|
|
|
|
warn("Please use 'OSVDB' for '#{value}'")
|
|
|
|
elsif value =~ /^http:\/\/cvedetails\.com\/cve/
|
|
|
|
warn("Please use 'CVE' for '#{value}'")
|
|
|
|
elsif value =~ /^http:\/\/www\.securityfocus\.com\/bid\//
|
|
|
|
warn("Please use 'BID' for '#{value}'")
|
|
|
|
elsif value =~ /^http:\/\/www\.microsoft\.com\/technet\/security\/bulletin\//
|
|
|
|
warn("Please use 'MSB' for '#{value}'")
|
|
|
|
elsif value =~ /^http:\/\/www\.exploit\-db\.com\/exploits\//
|
|
|
|
warn("Please use 'EDB' for '#{value}'")
|
|
|
|
elsif value =~ /^http:\/\/www\.kb\.cert\.org\/vuls\/id\//
|
|
|
|
warn("Please use 'US-CERT-VU' for '#{value}'")
|
2015-07-30 04:33:48 +00:00
|
|
|
elsif value =~ /^https:\/\/wpvulndb\.com\/vulnerabilities\//
|
2015-07-30 04:22:48 +00:00
|
|
|
warn("Please use 'WPVDB' for '#{value}'")
|
2015-12-24 17:12:24 +00:00
|
|
|
elsif value =~ /^https?:\/\/(?:[^\.]+\.)?packetstormsecurity\.(?:com|net|org)\//
|
2015-09-02 04:25:01 +00:00
|
|
|
warn("Please use 'PACKETSTORM' for '#{value}'")
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-07-17 16:29:13 +00:00
|
|
|
# See if 'require "rubygems"' or equivalent is used, and
|
|
|
|
# warn if so. Since Ruby 1.9 this has not been necessary and
|
|
|
|
# the framework only suports 1.9+
|
|
|
|
def check_rubygems
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines.each do |line|
|
2014-07-17 16:29:13 +00:00
|
|
|
if line_has_require?(line, 'rubygems')
|
|
|
|
warn("Explicitly requiring/loading rubygems is not necessary")
|
|
|
|
break
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
# Does the given line contain a require/load of the specified library?
|
|
|
|
def line_has_require?(line, lib)
|
|
|
|
line =~ /^\s*(require|load)\s+['"]#{lib}['"]/
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def check_snake_case_filename
|
|
|
|
sep = File::SEPARATOR
|
|
|
|
good_name = Regexp.new "^[a-z0-9_#{sep}]+\.rb$"
|
|
|
|
unless @name =~ good_name
|
|
|
|
warn "Filenames should be alphanum and snake case."
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-10-15 18:35:52 +00:00
|
|
|
def check_comment_splat
|
|
|
|
if @source =~ /^# This file is part of the Metasploit Framework and may be subject to/
|
2015-03-10 04:59:13 +00:00
|
|
|
warn("Module contains old license comment.")
|
2013-10-15 18:35:52 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def check_old_keywords
|
|
|
|
max_count = 10
|
|
|
|
counter = 0
|
|
|
|
if @source =~ /^##/
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines.each do |line|
|
2013-09-30 18:47:53 +00:00
|
|
|
# If exists, the $Id$ keyword should appear at the top of the code.
|
|
|
|
# If not (within the first 10 lines), then we assume there's no
|
|
|
|
# $Id$, and then bail.
|
|
|
|
break if counter >= max_count
|
|
|
|
|
|
|
|
if line =~ /^#[[:space:]]*\$Id\$/i
|
|
|
|
warn("Keyword $Id$ is no longer needed.")
|
|
|
|
break
|
|
|
|
end
|
|
|
|
|
|
|
|
counter += 1
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-01-09 02:32:30 +00:00
|
|
|
if @source =~ /["']Version["'][[:space:]]*=>[[:space:]]*['"]\$Revision\$['"]/
|
2013-09-30 18:47:53 +00:00
|
|
|
warn("Keyword $Revision$ is no longer needed.")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_verbose_option
|
|
|
|
if @source =~ /Opt(Bool|String).new\([[:space:]]*('|")VERBOSE('|")[[:space:]]*,[[:space:]]*\[[[:space:]]*/
|
|
|
|
warn("VERBOSE Option is already part of advanced settings, no need to add it manually.")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_badchars
|
|
|
|
badchars = %Q|&<=>|
|
|
|
|
|
|
|
|
in_super = false
|
|
|
|
in_author = false
|
|
|
|
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines.each do |line|
|
2013-09-30 18:47:53 +00:00
|
|
|
#
|
|
|
|
# Mark our "super" code block
|
|
|
|
#
|
2014-01-30 20:39:28 +00:00
|
|
|
if !in_super and line =~ /\s+super\(/
|
2013-09-30 18:47:53 +00:00
|
|
|
in_super = true
|
|
|
|
elsif in_super and line =~ /[[:space:]]*def \w+[\(\w+\)]*/
|
|
|
|
in_super = false
|
|
|
|
break
|
|
|
|
end
|
|
|
|
|
|
|
|
#
|
|
|
|
# While in super() code block
|
|
|
|
#
|
2014-01-09 02:32:30 +00:00
|
|
|
if in_super and line =~ /["']Name["'][[:space:]]*=>[[:space:]]*['|"](.+)['|"]/
|
2013-09-30 18:47:53 +00:00
|
|
|
# Now we're checking the module titlee
|
|
|
|
mod_title = $1
|
|
|
|
mod_title.each_char do |c|
|
|
|
|
if badchars.include?(c)
|
|
|
|
error("'#{c}' is a bad character in module title.")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
if not mod_title.ascii_only?
|
|
|
|
error("Please avoid unicode or non-printable characters in module title.")
|
|
|
|
end
|
|
|
|
|
|
|
|
# Since we're looking at the module title, this line clearly cannot be
|
|
|
|
# the author block, so no point to run more code below.
|
|
|
|
next
|
|
|
|
end
|
|
|
|
|
2015-11-06 21:23:14 +00:00
|
|
|
# XXX: note that this is all very fragile and regularly incorrectly parses
|
|
|
|
# the author
|
2013-09-30 18:47:53 +00:00
|
|
|
#
|
|
|
|
# Mark our 'Author' block
|
|
|
|
#
|
2014-01-09 02:32:30 +00:00
|
|
|
if in_super and !in_author and line =~ /["']Author["'][[:space:]]*=>/
|
2013-09-30 18:47:53 +00:00
|
|
|
in_author = true
|
|
|
|
elsif in_super and in_author and line =~ /\],*\n/ or line =~ /['"][[:print:]]*['"][[:space:]]*=>/
|
|
|
|
in_author = false
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
|
|
#
|
2015-11-06 21:23:14 +00:00
|
|
|
# While in 'Author' block, check for malformed authors
|
2013-09-30 18:47:53 +00:00
|
|
|
#
|
|
|
|
if in_super and in_author
|
2015-11-06 21:23:14 +00:00
|
|
|
if line =~ /Author['"]\s*=>\s*['"](.*)['"],/
|
|
|
|
author_name = Regexp.last_match(1)
|
|
|
|
elsif line =~ /Author/
|
2013-09-30 18:47:53 +00:00
|
|
|
author_name = line.scan(/\[[[:space:]]*['"](.+)['"]/).flatten[-1] || ''
|
|
|
|
else
|
|
|
|
author_name = line.scan(/['"](.+)['"]/).flatten[-1] || ''
|
|
|
|
end
|
|
|
|
|
|
|
|
if author_name =~ /^@.+$/
|
|
|
|
error("No Twitter handles, please. Try leaving it in a comment instead.")
|
|
|
|
end
|
|
|
|
|
|
|
|
if not author_name.ascii_only?
|
|
|
|
error("Please avoid unicode or non-printable characters in Author")
|
|
|
|
end
|
2015-11-06 21:23:14 +00:00
|
|
|
|
|
|
|
unless author_name.empty?
|
|
|
|
author_open_brackets = author_name.scan('<').size
|
|
|
|
author_close_brackets = author_name.scan('>').size
|
|
|
|
if author_open_brackets != author_close_brackets
|
|
|
|
error("Author has unbalanced brackets: #{author_name}")
|
|
|
|
end
|
|
|
|
end
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_extname
|
|
|
|
if File.extname(@name) != '.rb'
|
|
|
|
error("Module should be a '.rb' file, or it won't load.")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-04-11 02:44:00 +00:00
|
|
|
def check_old_rubies
|
2013-09-30 18:47:53 +00:00
|
|
|
return true unless CHECK_OLD_RUBIES
|
|
|
|
return true unless Object.const_defined? :RVM
|
2013-10-16 15:40:42 +00:00
|
|
|
puts "Checking syntax for #{@name}."
|
2013-09-30 18:47:53 +00:00
|
|
|
rubies ||= RVM.list_strings
|
2013-10-16 15:40:42 +00:00
|
|
|
res = %x{rvm all do ruby -c #{@full_filepath}}.split("\n").select {|msg| msg =~ /Syntax OK/}
|
2013-09-30 18:47:53 +00:00
|
|
|
error("Fails alternate Ruby version check") if rubies.size != res.size
|
|
|
|
end
|
|
|
|
|
2014-08-26 20:30:08 +00:00
|
|
|
def is_exploit_module?
|
|
|
|
ret = false
|
|
|
|
if @source =~ REGEX_MSF_EXPLOIT
|
|
|
|
# having Msf::Exploit is good indicator, but will false positive on
|
|
|
|
# specs and other files containing the string, but not really acting
|
|
|
|
# as exploit modules, so here we check the file for some actual contents
|
|
|
|
# this could be done in a simpler way, but this let's us add more later
|
|
|
|
msf_exploit_line_no = nil
|
|
|
|
@lines.each_with_index do |line, idx|
|
2014-08-27 01:36:28 +00:00
|
|
|
if line =~ REGEX_MSF_EXPLOIT
|
2014-08-26 20:30:08 +00:00
|
|
|
# note the line number
|
|
|
|
msf_exploit_line_no = idx
|
|
|
|
elsif msf_exploit_line_no
|
|
|
|
# check there is anything but empty space between here and the next end
|
|
|
|
# something more complex could be added here
|
|
|
|
if line !~ REGEX_IS_BLANK_OR_END
|
|
|
|
# if the line is not 'end' and is not blank, prolly exploit module
|
|
|
|
ret = true
|
|
|
|
break
|
|
|
|
else
|
|
|
|
# then keep checking in case there are more than one Msf::Exploit
|
|
|
|
msf_exploit_line_no = nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
ret
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def check_ranking
|
2014-08-26 20:30:08 +00:00
|
|
|
return unless is_exploit_module?
|
2013-09-30 18:47:53 +00:00
|
|
|
|
|
|
|
available_ranks = [
|
|
|
|
'ManualRanking',
|
|
|
|
'LowRanking',
|
|
|
|
'AverageRanking',
|
|
|
|
'NormalRanking',
|
|
|
|
'GoodRanking',
|
|
|
|
'GreatRanking',
|
|
|
|
'ExcellentRanking'
|
|
|
|
]
|
|
|
|
|
|
|
|
if @source =~ /Rank \= (\w+)/
|
|
|
|
if not available_ranks.include?($1)
|
|
|
|
error("Invalid ranking. You have '#{$1}'")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_disclosure_date
|
2014-04-07 19:21:04 +00:00
|
|
|
return if @source =~ /Generic Payload Handler/
|
2013-09-30 18:47:53 +00:00
|
|
|
|
|
|
|
# Check disclosure date format
|
2014-01-09 02:32:30 +00:00
|
|
|
if @source =~ /["']DisclosureDate["'].*\=\>[\x0d\x20]*['\"](.+)['\"]/
|
2013-09-30 18:47:53 +00:00
|
|
|
d = $1 #Captured date
|
|
|
|
# Flag if overall format is wrong
|
|
|
|
if d =~ /^... \d{1,2}\,* \d{4}/
|
|
|
|
# Flag if month format is wrong
|
|
|
|
m = d.split[0]
|
|
|
|
months = [
|
|
|
|
'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun',
|
|
|
|
'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'
|
|
|
|
]
|
|
|
|
|
|
|
|
error('Incorrect disclosure month format') if months.index(m).nil?
|
|
|
|
else
|
|
|
|
error('Incorrect disclosure date format')
|
|
|
|
end
|
|
|
|
else
|
2014-08-26 20:30:08 +00:00
|
|
|
error('Exploit is missing a disclosure date') if is_exploit_module?
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_title_casing
|
2014-01-09 02:32:30 +00:00
|
|
|
if @source =~ /["']Name["'][[:space:]]*=>[[:space:]]*['"](.+)['"],*$/
|
2013-09-30 18:47:53 +00:00
|
|
|
words = $1.split
|
|
|
|
words.each do |word|
|
2015-01-21 17:52:39 +00:00
|
|
|
if TITLE_WHITELIST.include?(word)
|
2013-09-30 18:47:53 +00:00
|
|
|
next
|
|
|
|
elsif word =~ /^[a-z]+$/
|
|
|
|
warn("Suspect capitalization in module title: '#{word}'")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_bad_terms
|
|
|
|
# "Stack overflow" vs "Stack buffer overflow" - See explanation:
|
|
|
|
# http://blogs.technet.com/b/srd/archive/2009/01/28/stack-overflow-stack-exhaustion-not-the-same-as-stack-buffer-overflow.aspx
|
2015-12-24 18:54:13 +00:00
|
|
|
if @module_type == 'exploit' && @source.gsub("\n", "") =~ /stack[[:space:]]+overflow/i
|
2013-09-30 18:47:53 +00:00
|
|
|
warn('Contains "stack overflow" You mean "stack buffer overflow"?')
|
2015-12-24 18:54:13 +00:00
|
|
|
elsif @module_type == 'auxiliary' && @source.gsub("\n", "") =~ /stack[[:space:]]+overflow/i
|
2013-09-30 18:47:53 +00:00
|
|
|
warn('Contains "stack overflow" You mean "stack exhaustion"?')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-12-22 21:38:31 +00:00
|
|
|
def check_bad_super_class
|
|
|
|
# skip payloads, as they don't have a super class
|
|
|
|
return if @module_type == 'payloads'
|
|
|
|
|
|
|
|
# get the super class in an ugly way
|
2016-03-08 13:02:44 +00:00
|
|
|
unless (super_class = @source.scan(/class Metasploit(?:\d|Module)\s+<\s+(\S+)/).flatten.first)
|
2015-12-22 21:38:31 +00:00
|
|
|
error('Unable to determine super class')
|
|
|
|
return
|
|
|
|
end
|
|
|
|
|
|
|
|
prefix_super_map = {
|
2015-12-23 16:33:47 +00:00
|
|
|
'auxiliary' => /^Msf::Auxiliary$/,
|
|
|
|
'exploits' => /^Msf::Exploit(?:::Local|::Remote)?$/,
|
2015-12-22 21:38:31 +00:00
|
|
|
'encoders' => /^(?:Msf|Rex)::Encoder/,
|
|
|
|
'nops' => /^Msf::Nop$/,
|
|
|
|
'post' => /^Msf::Post$/
|
|
|
|
}
|
|
|
|
|
|
|
|
if prefix_super_map.key?(@module_type)
|
|
|
|
unless super_class =~ prefix_super_map[@module_type]
|
|
|
|
error("Invalid super class for #{@module_type} module (found '#{super_class}', expected something like #{prefix_super_map[@module_type]}")
|
|
|
|
end
|
|
|
|
else
|
|
|
|
warn("Unexpected and potentially incorrect super class found ('#{super_class}')")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def check_function_basics
|
|
|
|
functions = @source.scan(/def (\w+)\(*(.+)\)*/)
|
|
|
|
|
|
|
|
functions.each do |func_name, args|
|
|
|
|
# Check argument length
|
|
|
|
args_length = args.split(",").length
|
|
|
|
warn("Poorly designed argument list in '#{func_name}()'. Try a hash.") if args_length > 6
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-08 13:02:44 +00:00
|
|
|
def check_bad_class_name
|
|
|
|
if @source =~ /^\s*class (Metasploit\d+)\s*</
|
2016-03-16 17:31:24 +00:00
|
|
|
warn("Please use 'MetasploitModule' as the class name (you used #{Regexp.last_match(1)})")
|
2016-03-08 13:02:44 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
def check_lines
|
|
|
|
url_ok = true
|
|
|
|
no_stdio = true
|
|
|
|
in_comment = false
|
|
|
|
in_literal = false
|
|
|
|
src_ended = false
|
|
|
|
idx = 0
|
|
|
|
|
2014-08-26 20:30:08 +00:00
|
|
|
@lines.each do |ln|
|
2013-09-30 18:47:53 +00:00
|
|
|
idx += 1
|
|
|
|
|
|
|
|
# block comment awareness
|
|
|
|
if ln =~ /^=end$/
|
|
|
|
in_comment = false
|
|
|
|
next
|
|
|
|
end
|
|
|
|
in_comment = true if ln =~ /^=begin$/
|
|
|
|
next if in_comment
|
|
|
|
|
|
|
|
# block string awareness (ignore indentation in these)
|
|
|
|
in_literal = false if ln =~ /^EOS$/
|
|
|
|
next if in_literal
|
|
|
|
in_literal = true if ln =~ /\<\<-EOS$/
|
|
|
|
|
|
|
|
# ignore stuff after an __END__ line
|
|
|
|
src_ended = true if ln =~ /^__END__$/
|
|
|
|
next if src_ended
|
|
|
|
|
|
|
|
if ln =~ /[\x00-\x08\x0b\x0c\x0e-\x19\x7f-\xff]/
|
|
|
|
error("Unicode detected: #{ln.inspect}", idx)
|
|
|
|
end
|
|
|
|
|
|
|
|
if ln =~ /[ \t]$/
|
|
|
|
warn("Spaces at EOL", idx)
|
|
|
|
end
|
|
|
|
|
2013-10-01 17:22:46 +00:00
|
|
|
# Check for mixed tab/spaces. Upgrade this to an error() soon.
|
2013-09-30 18:47:53 +00:00
|
|
|
if (ln.length > 1) and (ln =~ /^([\t ]*)/) and ($1.match(/\x20\x09|\x09\x20/))
|
|
|
|
warn("Space-Tab mixed indent: #{ln.inspect}", idx)
|
|
|
|
end
|
|
|
|
|
2013-10-01 17:22:46 +00:00
|
|
|
# Check for tabs. Upgrade this to an error() soon.
|
|
|
|
if (ln.length > 1) and (ln =~ /^\x09/)
|
|
|
|
warn("Tabbed indent: #{ln.inspect}", idx)
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
if ln =~ /\r$/
|
|
|
|
warn("Carriage return EOL", idx)
|
|
|
|
end
|
|
|
|
|
|
|
|
url_ok = false if ln =~ /\.com\/projects\/Framework/
|
|
|
|
if ln =~ /File\.open/ and ln =~ /[\"\'][arw]/
|
|
|
|
if not ln =~ /[\"\'][wra]\+?b\+?[\"\']/
|
|
|
|
warn("File.open without binary mode", idx)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
if ln =~/^[ \t]*load[ \t]+[\x22\x27]/
|
|
|
|
error("Loading (not requiring) a file: #{ln.inspect}", idx)
|
|
|
|
end
|
|
|
|
|
|
|
|
# The rest of these only count if it's not a comment line
|
2015-02-09 19:40:18 +00:00
|
|
|
next if ln =~ /^[[:space:]]*#/
|
2013-09-30 18:47:53 +00:00
|
|
|
|
2013-11-20 23:53:25 +00:00
|
|
|
if ln =~ /\$std(?:out|err)/i or ln =~ /[[:space:]]puts/
|
|
|
|
next if ln =~ /^[\s]*["][^"]+\$std(?:out|err)/
|
2013-09-30 18:47:53 +00:00
|
|
|
no_stdio = false
|
|
|
|
error("Writes to stdout", idx)
|
|
|
|
end
|
|
|
|
|
2014-05-12 19:23:30 +00:00
|
|
|
# do not read Set-Cookie header (ignore commented lines)
|
2015-02-09 23:01:29 +00:00
|
|
|
if ln =~ /^(?!\s*#).+\[['"]Set-Cookie['"]\](?!\s*=[^=~]+)/i
|
2014-03-01 12:30:24 +00:00
|
|
|
warn("Do not read Set-Cookie header directly, use res.get_cookies instead: #{ln}", idx)
|
|
|
|
end
|
2014-03-28 21:43:53 +00:00
|
|
|
|
|
|
|
# Auxiliary modules do not have a rank attribute
|
2015-12-24 18:54:13 +00:00
|
|
|
if ln =~ /^\s*Rank\s*=\s*/ && @module_type == 'auxiliary'
|
2014-03-28 21:43:53 +00:00
|
|
|
warn("Auxiliary modules have no 'Rank': #{ln}", idx)
|
|
|
|
end
|
2014-12-11 22:10:07 +00:00
|
|
|
|
2015-02-09 22:18:43 +00:00
|
|
|
if ln =~ /^\s*def\s+(?:[^\(\)#]*[A-Z]+[^\(\)]*)(?:\(.*\))?$/
|
2014-12-11 22:10:07 +00:00
|
|
|
warn("Please use snake case on method names: #{ln}", idx)
|
|
|
|
end
|
2015-04-16 18:04:08 +00:00
|
|
|
|
2015-04-16 19:51:31 +00:00
|
|
|
if ln =~ /^\s*fail_with\(/
|
2015-04-16 23:00:08 +00:00
|
|
|
unless ln =~ /^\s*fail_with\(Failure\:\:(?:None|Unknown|Unreachable|BadConfig|Disconnected|NotFound|UnexpectedReply|TimeoutExpired|UserInterrupt|NoAccess|NoTarget|NotVulnerable|PayloadFailed),/
|
2015-04-16 19:43:47 +00:00
|
|
|
error("fail_with requires a valid Failure:: reason as first parameter: #{ln}", idx)
|
|
|
|
end
|
2015-04-16 18:04:08 +00:00
|
|
|
end
|
2015-04-16 19:43:47 +00:00
|
|
|
|
2015-08-12 18:55:55 +00:00
|
|
|
if ln =~ /['"]ExitFunction['"]\s*=>/
|
|
|
|
warn("Please use EXITFUNC instead of ExitFunction #{ln}", idx)
|
|
|
|
end
|
|
|
|
|
2014-08-26 20:30:08 +00:00
|
|
|
end
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
|
|
|
|
2014-01-22 21:26:16 +00:00
|
|
|
def check_vuln_codes
|
|
|
|
checkcode = @source.scan(/(Exploit::)?CheckCode::(\w+)/).flatten[1]
|
|
|
|
if checkcode and checkcode !~ /^Unknown|Safe|Detected|Appears|Vulnerable|Unsupported$/
|
2014-01-23 20:21:48 +00:00
|
|
|
error("Unrecognized checkcode: #{checkcode}")
|
2014-01-22 21:26:16 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-04-14 19:49:26 +00:00
|
|
|
def check_vars_get
|
2014-04-22 17:24:06 +00:00
|
|
|
test = @source.scan(/send_request_cgi\s*\(\s*\{?\s*['"]uri['"]\s*=>\s*[^=})]*?\?[^,})]+/im)
|
2014-03-01 11:02:41 +00:00
|
|
|
unless test.empty?
|
|
|
|
test.each { |item|
|
2014-04-22 17:24:06 +00:00
|
|
|
info("Please use vars_get in send_request_cgi: #{item}")
|
2014-03-01 11:02:41 +00:00
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-06-17 13:44:43 +00:00
|
|
|
def check_newline_eof
|
|
|
|
if @source !~ /(?:\r\n|\n)\z/m
|
|
|
|
info('Please add a newline at the end of the file')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-06-30 05:40:06 +00:00
|
|
|
def check_sock_get
|
|
|
|
if @source =~ /\s+sock\.get(\s*|\(|\d+\s*|\d+\s*,\d+\s*)/m && @source !~ /sock\.get_once/
|
|
|
|
info('Please use sock.get_once instead of sock.get')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_udp_sock_get
|
2014-07-14 19:36:08 +00:00
|
|
|
if @source =~ /udp_sock\.get/m && @source !~ /udp_sock\.get\([a-zA-Z0-9]+/
|
2014-06-30 05:40:06 +00:00
|
|
|
info('Please specify a timeout to udp_sock.get')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-12-12 02:36:42 +00:00
|
|
|
# At one point in time, somebody committed a module with a bad metasploit.com URL
|
|
|
|
# in the header -- http//metasploit.com/download rather than http://metasploit.com/download.
|
|
|
|
# This module then got copied and committed 20+ times and is used in numerous other places.
|
|
|
|
# This ensures that this stops.
|
2014-12-11 22:10:07 +00:00
|
|
|
def check_invalid_url_scheme
|
2015-01-09 21:07:21 +00:00
|
|
|
test = @source.scan(/^#.+http\/\/(?:www\.)?metasploit.com/)
|
2014-12-11 22:10:07 +00:00
|
|
|
unless test.empty?
|
2015-01-22 20:27:34 +00:00
|
|
|
test.each { |item|
|
2014-12-11 22:10:07 +00:00
|
|
|
info("Invalid URL: #{item}")
|
2015-01-22 20:27:34 +00:00
|
|
|
}
|
2014-12-11 22:10:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-04-21 16:27:22 +00:00
|
|
|
# Check for (v)print_debug usage, since it doesn't exist anymore
|
|
|
|
#
|
|
|
|
# @see https://github.com/rapid7/metasploit-framework/issues/3816
|
|
|
|
def check_print_debug
|
|
|
|
if @source =~ /print_debug/
|
|
|
|
error('Please don\'t use (v)print_debug, use vprint_(status|good|error|warning) instead')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-04-21 16:56:41 +00:00
|
|
|
# Check for modules registering the DEBUG datastore option
|
|
|
|
#
|
|
|
|
# @see https://github.com/rapid7/metasploit-framework/issues/3816
|
2015-04-21 17:22:24 +00:00
|
|
|
def check_register_datastore_debug
|
2015-04-21 17:13:40 +00:00
|
|
|
if @source =~ /Opt.*\.new\(["'](?i)DEBUG(?-i)["']/
|
2015-04-21 16:56:41 +00:00
|
|
|
error('Please don\'t register a DEBUG datastore option, it has an special meaning and is used for development')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-04-21 17:22:24 +00:00
|
|
|
# Check for modules using the DEBUG datastore option
|
|
|
|
#
|
|
|
|
# @see https://github.com/rapid7/metasploit-framework/issues/3816
|
|
|
|
def check_use_datastore_debug
|
|
|
|
if @source =~ /datastore\[["'](?i)DEBUG(?-i)["']\]/
|
|
|
|
error('Please don\'t use the DEBUG datastore option in production, it has an special meaning and is used for development')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-12-24 18:54:13 +00:00
|
|
|
#
|
|
|
|
# Run all the msftidy checks.
|
|
|
|
#
|
|
|
|
def run_checks
|
|
|
|
check_mode
|
|
|
|
check_shebang
|
|
|
|
check_nokogiri
|
|
|
|
check_rubygems
|
|
|
|
check_ref_identifiers
|
|
|
|
check_old_keywords
|
|
|
|
check_verbose_option
|
|
|
|
check_badchars
|
|
|
|
check_extname
|
|
|
|
check_old_rubies
|
|
|
|
check_ranking
|
|
|
|
check_disclosure_date
|
|
|
|
check_title_casing
|
|
|
|
check_bad_terms
|
|
|
|
check_bad_super_class
|
2016-03-08 13:02:44 +00:00
|
|
|
check_bad_class_name
|
2015-12-24 18:54:13 +00:00
|
|
|
check_function_basics
|
|
|
|
check_lines
|
|
|
|
check_snake_case_filename
|
|
|
|
check_comment_splat
|
|
|
|
check_vuln_codes
|
|
|
|
check_vars_get
|
|
|
|
check_newline_eof
|
|
|
|
check_sock_get
|
|
|
|
check_udp_sock_get
|
|
|
|
check_invalid_url_scheme
|
|
|
|
check_print_debug
|
|
|
|
check_register_datastore_debug
|
|
|
|
check_use_datastore_debug
|
|
|
|
end
|
|
|
|
|
2013-09-30 18:47:53 +00:00
|
|
|
private
|
|
|
|
|
|
|
|
def load_file(file)
|
|
|
|
f = open(file, 'rb')
|
2013-11-05 17:49:15 +00:00
|
|
|
@stat = f.stat
|
|
|
|
buf = f.read(@stat.size)
|
2013-09-30 18:47:53 +00:00
|
|
|
f.close
|
|
|
|
return buf
|
|
|
|
end
|
2014-03-01 11:02:41 +00:00
|
|
|
|
|
|
|
def cleanup_text(txt)
|
|
|
|
# remove line breaks
|
|
|
|
txt = txt.gsub(/[\r\n]/, ' ')
|
|
|
|
# replace multiple spaces by one space
|
|
|
|
txt.gsub(/\s{2,}/, ' ')
|
|
|
|
end
|
2012-10-12 07:55:16 +00:00
|
|
|
end
|
2010-11-05 00:05:34 +00:00
|
|
|
|
|
|
|
##
|
|
|
|
#
|
|
|
|
# Main program
|
|
|
|
#
|
|
|
|
##
|
|
|
|
|
2015-12-24 18:54:13 +00:00
|
|
|
if __FILE__ == $PROGRAM_NAME
|
|
|
|
dirs = ARGV
|
2010-11-05 00:05:34 +00:00
|
|
|
|
2015-12-24 18:54:13 +00:00
|
|
|
@exit_status = 0
|
2014-01-31 20:19:04 +00:00
|
|
|
|
2015-12-24 18:54:13 +00:00
|
|
|
if dirs.length < 1
|
|
|
|
$stderr.puts "Usage: #{File.basename(__FILE__)} <directory or file>"
|
|
|
|
@exit_status = 1
|
|
|
|
exit(@exit_status)
|
|
|
|
end
|
2010-11-05 00:05:34 +00:00
|
|
|
|
2015-12-24 18:54:13 +00:00
|
|
|
dirs.each do |dir|
|
|
|
|
begin
|
|
|
|
Find.find(dir) do |full_filepath|
|
|
|
|
next if full_filepath =~ /\.git[\x5c\x2f]/
|
|
|
|
next unless File.file? full_filepath
|
|
|
|
next unless full_filepath =~ /\.rb$/
|
|
|
|
msftidy = Msftidy.new(full_filepath)
|
|
|
|
msftidy.run_checks
|
|
|
|
@exit_status = msftidy.status if (msftidy.status > @exit_status.to_i)
|
|
|
|
end
|
|
|
|
rescue Errno::ENOENT
|
|
|
|
$stderr.puts "#{File.basename(__FILE__)}: #{dir}: No such file or directory"
|
2013-11-20 22:36:07 +00:00
|
|
|
end
|
2013-09-30 18:47:53 +00:00
|
|
|
end
|
2014-01-31 20:19:04 +00:00
|
|
|
|
2015-12-24 18:54:13 +00:00
|
|
|
exit(@exit_status.to_i)
|
|
|
|
end
|