2014-07-29 21:48:49 +00:00
|
|
|
# This list was created by analyzing the last three months (51 modules)
|
|
|
|
# committed to Metasploit Framework. Many, many older modules will have
|
|
|
|
# offenses, but this should at least provide a baseline for new modules.
|
|
|
|
#
|
|
|
|
# Updates to this file should include a 'Description' parameter for
|
|
|
|
# any explaination needed.
|
2014-07-15 17:43:08 +00:00
|
|
|
|
2014-07-29 21:54:19 +00:00
|
|
|
inherit_from: .rubocop_todo.yml
|
2014-07-15 17:43:08 +00:00
|
|
|
|
|
|
|
Style/ClassLength:
|
2014-07-29 21:48:49 +00:00
|
|
|
Description: 'Most Metasploit modules are quite large. This is ok.'
|
|
|
|
Enabled: true
|
2014-07-15 17:43:08 +00:00
|
|
|
Exclude:
|
|
|
|
- 'modules/**/*'
|
2014-07-15 23:58:11 +00:00
|
|
|
|
2014-07-29 21:48:49 +00:00
|
|
|
Style/Documentation:
|
|
|
|
Enabled: true
|
|
|
|
Description: 'Most Metasploit modules do not have class documentation.'
|
2014-07-15 23:58:11 +00:00
|
|
|
Exclude:
|
|
|
|
- 'modules/**/*'
|
2014-07-29 21:48:49 +00:00
|
|
|
|
|
|
|
Style/Encoding:
|
|
|
|
Enabled: true
|
|
|
|
Description: 'We prefer binary to UTF-8.'
|
|
|
|
EnforcedStyle: 'when_needed'
|
|
|
|
|
|
|
|
Style/LineLength:
|
|
|
|
Description: >-
|
|
|
|
Metasploit modules often pattern match against very
|
|
|
|
long strings when identifying targets.
|
|
|
|
Enabled: true
|
|
|
|
Max: 180
|
|
|
|
|
|
|
|
Style/MethodLength:
|
|
|
|
Enabled: true
|
|
|
|
Description: >-
|
|
|
|
While the style guide suggests 10 lines, exploit definitions
|
|
|
|
often exceed 200 lines.
|
|
|
|
Max: 300
|
|
|
|
|
|
|
|
Style/NumericLiterals:
|
|
|
|
Enabled: false
|
|
|
|
Description: 'This often hurts readability for exploit-ish code.'
|
2014-07-30 15:28:12 +00:00
|
|
|
|
|
|
|
Style/PercentLiteralDelimiters:
|
|
|
|
Enabled: false
|
|
|
|
Description: >-
|
|
|
|
Metasploit devs tend to prefer [] over %w() for
|
|
|
|
nearly all cases, since we often deal with funny
|
|
|
|
looking arrays of nonwords. Consistency here is
|
|
|
|
preferred over element type safety.
|
|
|
|
|
|
|
|
Style/WordArray:
|
|
|
|
Enabled: false
|
|
|
|
Description: >-
|
|
|
|
Metasploit devs have grown comforatble with curly
|
|
|
|
braces over parens for %w. Disabling this check
|
|
|
|
prefers consistency.
|